From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org,
shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
keyrings-6DNke4IJHB0gsBAKwltoeQ@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Eric Paris <eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] KEYS/DNS: Fix ____call_usermodehelper() to not lose the session keyring
Date: Fri, 17 Jun 2011 10:56:51 +0100 [thread overview]
Message-ID: <23040.1308304611@redhat.com> (raw)
In-Reply-To: <BANLkTimxJ5kHOODSPqRPcgbObjZbfT59uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> PS. Possibly it might make more sense to just put the "struct cred *"
> pointer into the "struct subprocess_info" and not change any of the
> function prototypes at all?
That's the way I did it originally, but someone thought doing it with an init
function was a better idea:-/
Your suggestion is slightly complicated by the capability restriction stuff
that caused the breakage. That needs to hack the creds at some point.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
jmorris@namei.org, shirishpargaonkar@gmail.com,
keyrings@linux-nfs.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH] KEYS/DNS: Fix ____call_usermodehelper() to not lose the session keyring
Date: Fri, 17 Jun 2011 10:56:51 +0100 [thread overview]
Message-ID: <23040.1308304611@redhat.com> (raw)
In-Reply-To: <BANLkTimxJ5kHOODSPqRPcgbObjZbfT59uw@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> PS. Possibly it might make more sense to just put the "struct cred *"
> pointer into the "struct subprocess_info" and not change any of the
> function prototypes at all?
That's the way I did it originally, but someone thought doing it with an init
function was a better idea:-/
Your suggestion is slightly complicated by the capability restriction stuff
that caused the breakage. That needs to hack the creds at some point.
David
next prev parent reply other threads:[~2011-06-17 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 23:56 [PATCH] KEYS/DNS: Fix ____call_usermodehelper() to not lose the session keyring David Howells
2011-06-16 23:56 ` David Howells
[not found] ` <20110616235600.14345.16839.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2011-06-17 0:26 ` Linus Torvalds
2011-06-17 0:26 ` Linus Torvalds
[not found] ` <BANLkTimxJ5kHOODSPqRPcgbObjZbfT59uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-17 9:56 ` David Howells [this message]
2011-06-17 9:56 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23040.1308304611@redhat.com \
--to=dhowells-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org \
--cc=keyrings-6DNke4IJHB0gsBAKwltoeQ@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.