All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jasper Orschulko" <jasper@fancydomain.eu>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] sdbus-c++: Upgrade to 2.1.0 release
Date: Tue, 06 May 2025 04:25:40 -0700	[thread overview]
Message-ID: <23053.1746530740696323333@lists.openembedded.org> (raw)
In-Reply-To: <7c39f1e3-7f53-461e-be59-711a72292b5a@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

I stand corrected. :) Thanks for the info, I was not aware of this change!

A bit OT: https://docs.yoctoproject.org/bitbake/dev/bitbake-user-manual/bitbake-user-manual-fetching.html#git-fetcher-git could use a update then, as it still states:

> “tag”: Specifies a tag to use for the checkout. To correctly resolve tags, BitBake must access the network. For that reason, tags are often not used. As far as Git is concerned, the “tag” parameter behaves effectively the same as the “rev” parameter.

https://docs.yoctoproject.org/bitbake/dev/bitbake-user-manual/bitbake-user-manual-fetching.html#git-fetcher-git

On Tue, May 6, 2025 at 01:17 PM, Gyorgy Sarvari wrote:

> 
> On 5/6/25 13:10, Jasper Orschulko via lists.openembedded.org wrote:
> 
>> 
>>> And add tag to SRC_URI.
>> 
>> AFAIK this is not possible / bad practise, unless there were some
>> recent changes to OE that I am unaware of.
> 
> There were some recent developments[1] in this front. Now tags and the
> SRCREV are matched to each other, so you can be sure that the SRCREV is
> correlated to PV, and they are not randomly set.
> 
> [1]: e.g.
> https://git.openembedded.org/bitbake/commit/?id=d591d7633fe8d739ec00395920e44910b0b77e27
> 
> 
> 
>> You can either specify "rev" directly in the SRC_URI or SRCREV, not
>> both. So if you set rev to a git tag in SRC_URI, you cannot set a git
>> commit hash within SRCREV, thus you lose reproducibility since you are
>> now only referencing a floating rev. See also:
>> https://stackoverflow.com/questions/78127309/how-to-set-srcrev-for-git-tag-in-yocto/78127354#78127354
>> .
>> 
>> So setting the git commit hash in SRC_URI as rev or directly in SRCREV
>> is the way to go.
>> 
>> 
>> 
> 
>

[-- Attachment #2: Type: text/html, Size: 2463 bytes --]

  reply	other threads:[~2025-05-06 11:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:10 [meta-oe][PATCH] sdbus-c++: Upgrade to 2.1.0 release Thomas Noack
2025-04-30 14:59 ` [oe] " Khem Raj
2025-04-30 17:02   ` Marko, Peter
2025-05-06 11:10     ` Jasper Orschulko
2025-05-06 11:17       ` [oe] " Gyorgy Sarvari
2025-05-06 11:25         ` Jasper Orschulko [this message]
2025-05-06 11:17       ` Martin Jansa
2025-05-06 11:20       ` Marko, Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23053.1746530740696323333@lists.openembedded.org \
    --to=jasper@fancydomain.eu \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.