From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:39161 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbcKVJgj (ORCPT ); Tue, 22 Nov 2016 04:36:39 -0500 From: Laurent Pinchart To: Rob Herring Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Tomi Valkeinen , devicetree@vger.kernel.org Subject: Re: [PATCH v2 01/13] devicetree/bindings: display: Document common panel properties Date: Tue, 22 Nov 2016 11:36:55 +0200 Message-ID: <2307840.2mk6E40XHl@avalon> In-Reply-To: <20161121164815.bxca4rfvifloizdh@rob-hp-laptop> References: <1479526093-7014-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1479526093-7014-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161121164815.bxca4rfvifloizdh@rob-hp-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Rob, On Monday 21 Nov 2016 10:48:15 Rob Herring wrote: > On Sat, Nov 19, 2016 at 05:28:01AM +0200, Laurent Pinchart wrote: > > Document properties common to several display panels in a central > > location that can be referenced by the panel device tree bindings. > > Looks good. Just one comment... > > [...] > > > +Connectivity > > +------------ > > + > > +- ports: Panels receive video data through one or multiple connections. > > While > > + the nature of those connections is specific to the panel type, the > > + connectivity is expressed in a standard fashion using ports as > > specified in > > + the device graph bindings defined in > > + Documentation/devicetree/bindings/graph.txt. > > We allow panels to either use graph binding or be a child of the display > controller. I knew that some display controllers use a phandle to the panel (see the fsl,panel and nvidia,panel properties), but I didn't know we had panels as children of display controller nodes. I don't think we should allow that for anything but DSI panels, as the DT hierarchy is based on control buses. Are you sure we have other panels instantiated through that mechanism ? > Using the graph is preferred, but in the simple cases just a child node is > sufficient. This should be described here or somewhere in this doc. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 01/13] devicetree/bindings: display: Document common panel properties Date: Tue, 22 Nov 2016 11:36:55 +0200 Message-ID: <2307840.2mk6E40XHl@avalon> References: <1479526093-7014-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1479526093-7014-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161121164815.bxca4rfvifloizdh@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161121164815.bxca4rfvifloizdh@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: linux-renesas-soc@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKT24gTW9uZGF5IDIxIE5vdiAyMDE2IDEwOjQ4OjE1IFJvYiBIZXJyaW5nIHdyb3Rl Ogo+IE9uIFNhdCwgTm92IDE5LCAyMDE2IGF0IDA1OjI4OjAxQU0gKzAyMDAsIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gPiBEb2N1bWVudCBwcm9wZXJ0aWVzIGNvbW1vbiB0byBzZXZlcmFsIGRp c3BsYXkgcGFuZWxzIGluIGEgY2VudHJhbAo+ID4gbG9jYXRpb24gdGhhdCBjYW4gYmUgcmVmZXJl bmNlZCBieSB0aGUgcGFuZWwgZGV2aWNlIHRyZWUgYmluZGluZ3MuCj4gCj4gTG9va3MgZ29vZC4g SnVzdCBvbmUgY29tbWVudC4uLgo+IAo+IFsuLi5dCj4gCj4gPiArQ29ubmVjdGl2aXR5Cj4gPiAr LS0tLS0tLS0tLS0tCj4gPiArCj4gPiArLSBwb3J0czogUGFuZWxzIHJlY2VpdmUgdmlkZW8gZGF0 YSB0aHJvdWdoIG9uZSBvciBtdWx0aXBsZSBjb25uZWN0aW9ucy4KPiA+IFdoaWxlCj4gPiArICB0 aGUgbmF0dXJlIG9mIHRob3NlIGNvbm5lY3Rpb25zIGlzIHNwZWNpZmljIHRvIHRoZSBwYW5lbCB0 eXBlLCB0aGUKPiA+ICsgIGNvbm5lY3Rpdml0eSBpcyBleHByZXNzZWQgaW4gYSBzdGFuZGFyZCBm YXNoaW9uIHVzaW5nIHBvcnRzIGFzCj4gPiBzcGVjaWZpZWQgaW4KPiA+ICsgIHRoZSBkZXZpY2Ug Z3JhcGggYmluZGluZ3MgZGVmaW5lZCBpbgo+ID4gKyAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2dyYXBoLnR4dC4KPiAKPiBXZSBhbGxvdyBwYW5lbHMgdG8gZWl0aGVyIHVzZSBn cmFwaCBiaW5kaW5nIG9yIGJlIGEgY2hpbGQgb2YgdGhlIGRpc3BsYXkKPiBjb250cm9sbGVyLgoK SSBrbmV3IHRoYXQgc29tZSBkaXNwbGF5IGNvbnRyb2xsZXJzIHVzZSBhIHBoYW5kbGUgdG8gdGhl IHBhbmVsIChzZWUgdGhlIApmc2wscGFuZWwgYW5kIG52aWRpYSxwYW5lbCBwcm9wZXJ0aWVzKSwg YnV0IEkgZGlkbid0IGtub3cgd2UgaGFkIHBhbmVscyBhcyAKY2hpbGRyZW4gb2YgZGlzcGxheSBj b250cm9sbGVyIG5vZGVzLiBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCBhbGxvdyB0aGF0IGZvciAK YW55dGhpbmcgYnV0IERTSSBwYW5lbHMsIGFzIHRoZSBEVCBoaWVyYXJjaHkgaXMgYmFzZWQgb24g Y29udHJvbCBidXNlcy4gQXJlIAp5b3Ugc3VyZSB3ZSBoYXZlIG90aGVyIHBhbmVscyBpbnN0YW50 aWF0ZWQgdGhyb3VnaCB0aGF0IG1lY2hhbmlzbSA/Cgo+IFVzaW5nIHRoZSBncmFwaCBpcyBwcmVm ZXJyZWQsIGJ1dCBpbiB0aGUgc2ltcGxlIGNhc2VzIGp1c3QgYSBjaGlsZCBub2RlIGlzCj4gc3Vm ZmljaWVudC4gVGhpcyBzaG91bGQgYmUgZGVzY3JpYmVkIGhlcmUgb3Igc29tZXdoZXJlIGluIHRo aXMgZG9jLgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK