All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vudum, Lakshminarayana" <lakshminarayana.vudum@intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 9/9] tests/i915/gen9_exec_parse: Expect sync_fence_status to succeed
Date: Wed, 14 Jul 2021 17:38:59 +0000	[thread overview]
Message-ID: <230a51b2c1554090b637bc8145f2b55f@intel.com> (raw)
In-Reply-To: <20210714173141.1381686-10-jason@jlekstrand.net>

What is expected from myside? Should these email's I received go to a different person?

Lakshmi.
-----Original Message-----
From: Jason Ekstrand <jason@jlekstrand.net> 
Sent: Wednesday, July 14, 2021 10:32 AM
To: igt-dev@lists.freedesktop.org
Cc: Jason Ekstrand <jason@jlekstrand.net>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: [PATCH i-g-t 9/9] tests/i915/gen9_exec_parse: Expect sync_fence_status to succeed

i915 is switching to synchronously parse command buffers and deliver the error immediately instead of trying to propagate it to the fence.  We can assume that, if there is an error, it's returned from execbuf.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Cc: Lakshminarayana Vudum <lakshminarayana.vudum@intel.com>
---
 tests/i915/gen9_exec_parse.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/i915/gen9_exec_parse.c b/tests/i915/gen9_exec_parse.c index b35f2cb43..512891873 100644
--- a/tests/i915/gen9_exec_parse.c
+++ b/tests/i915/gen9_exec_parse.c
@@ -72,10 +72,8 @@ __checked_execbuf(int i915, struct drm_i915_gem_execbuffer2 *eb)
 	fence = eb->rsvd2 >> 32;
 
 	sync_fence_wait(fence, -1);
-	err = sync_fence_status(fence);
+	igt_assert(sync_fence_status(fence) >= 0);
 	close(fence);
-	if (err < 0)
-		return err;
 
 	return 0;
 }
--
2.31.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-07-14 17:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 17:31 [igt-dev] [PATCH i-g-t 0/9] Prepare for a synchronous command parser Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 1/9] lib/intel_ctx: Add a intel_ctx_cfg_engine_class helper Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 2/9] tests/i915/gem_eio: Convert to intel_ctx_t Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 3/9] tests/i915/gem_ctx_persistence: Use intel_ctx_t for hang subtests Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 4/9] i915: Improve the precision of command parser checks Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 5/9] tests/gem_exec_schedule: Use store_dword_plug again (v2) Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 6/9] Revert "test/i915/gem_exec_reloc: Restore interclient testings" Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 7/9] Revert "i915/gem_exec_reloc: Flood the ring with GPU relocs" Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 8/9] Revert "i915/gem_exec_reloc: Check that relocations do not block" Jason Ekstrand
2021-07-14 17:31 ` [igt-dev] [PATCH i-g-t 9/9] tests/i915/gen9_exec_parse: Expect sync_fence_status to succeed Jason Ekstrand
2021-07-14 17:38   ` Vudum, Lakshminarayana [this message]
2021-07-14 19:33     ` Jason Ekstrand
2021-07-15 12:33 ` [igt-dev] ✓ Fi.CI.BAT: success for Prepare for a synchronous command parser (rev2) Patchwork
2021-07-15 15:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-15 15:58   ` Vudum, Lakshminarayana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=230a51b2c1554090b637bc8145f2b55f@intel.com \
    --to=lakshminarayana.vudum@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.