From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 1/2] drm/bridge: dw-hdmi: support optional supply regulators Date: Fri, 05 Jun 2015 14:16:40 +0200 Message-ID: <23123577.mOoqGCAPdL@diego> References: <4184159.j0iXe39dFB@phil> <2619686.csNBBFyt8W@phil> <20150605110159.GA16254@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150605110159.GA16254@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King - ARM Linux , Pawel Moll , Ian Campbell , dianders@chromium.org, linux-rockchip@lists.infradead.org, Rob Herring , dri-devel@lists.freedesktop.org, Yakir Yang , Andy Yan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgVGhpZXJyeQoKQW0gRnJlaXRhZywgNS4gSnVuaSAyMDE1LCAxMzowMjowMSBzY2hyaWViIFRo aWVycnkgUmVkaW5nOgo+IE9uIE1vbiwgTWFyIDIzLCAyMDE1IGF0IDA3OjE3OjQ5UE0gKzAxMDAs IEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+ID4gSGkgUGhpbGlwcCwKPiA+IAo+ID4gQW0gRG9ubmVy c3RhZywgMTIuIE3DpHJ6IDIwMTUsIDIxOjQ1OjE5IHNjaHJpZWIgSGVpa28gU3R1ZWJuZXI6Cj4g PiA+IEF0IGxlYXN0IHRoZSBSb2NrY2hpcCB2YXJpYW50IG9mIHRoZSBkd19oZG1pIGNhbiBoYXZl IGNvbnRyb2xsYWJsZSBwb3dlcgo+ID4gPiBzdXBwbGllcyBwcm92aWRpbmcgMS4wIGFuZCAxLjhW LiBUaGVyZWZvcmUgYWRkIHRoZSBwb3NzaWJpbGl0eSBmb3IgdGhlCj4gPiA+IGdlbmVyaWMgYnJp ZGdlIGRyaXZlciB0byBlbmFibGUgc3VwcGxpZXMgcHJvdmlkZWQgYnkgdGhlIGh3LXNwZWNpZmlj Cj4gPiA+IGRyaXZlcnMuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBIZWlrbyBTdHVlYm5l ciA8aGVpa29Ac250ZWNoLmRlPgo+ID4gCj4gPiBkb2VzIHRoaXMgbG9vayBvayBub3c/Cj4gPiAK PiA+IEFuZCBhcyB3ZSB0YWxrZWQgYWJvdXQgaW4gQ2hlbW5pdHosIHdobyB3aWxsIGJlIHRha2lu ZyBzdWNoIGJyaWRnZS1yZWxhdGVkCj4gPiBjaGFuZ2VzLCBhcyB5b3UgbWVudGlvbmVkIHNvbWUg bGFzdCBicmlkZ2UtcGF0Y2hlcyBnb2luZyB0aHJvdWdoIFRoaWVycnkuCj4gCj4gU29ycnksIEkg aGFkIGNvbXBsZXRlbHkgbWlzc2VkIHRoaXMuCj4gCj4gPiA+IC0tLQo+ID4gPiBjaGFuZ2VzIHNp bmNlIHYyOgo+ID4gPiAtIHJlbmFtZSBzdXBwbGllcyB0byB0aGUgbmFtZXMgZm91bmQgaW4gdGhl IGhkbWkgSVAgZGF0YWJvb2sKPiA+ID4gY2hhbmdlcyBzaW5jZSB2MToKPiA+ID4gLSBmb2xsb3cg c3VnZ2VzdGlvbiBmcm9tIFJ1c3NlbGwgS2luZyB0byBrZWVwIHJlZ3VsYXRvciBoYW5kbGluZyBs b2NhbAo+ID4gPiAKPiA+ID4gICB0byB0aGUgcm9ja2NoaXAgaW1wbGVtZW50YXRpb24gZm9yIHRo ZSB0aW1lIGJlaW5nIGFuZCBvbmx5IGdlbmVyYWxpemUKPiA+ID4gICB3aGVuIGEgcmVhbCBzZWNv bmQgaW1wbGVtZW50YXRpb24gbmVlZHMgcmVndWxhdG9yIGhhbmRsaW5nCj4gPiA+ICAKPiA+ID4g IC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHdfaGRtaS50eHQgICAgIHwgIDUg KysrKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3X2hkbWktcm9ja2NoaXAuYyAg ICAgICAgfCAzMgo+ID4gPiAKPiA+ID4gKysrKysrKysrKysrKysrKysrKysrLSAyIGZpbGVzIGNo YW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYg LS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kd19o ZG1pLnR4dAo+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJp ZGdlL2R3X2hkbWkudHh0IGluZGV4Cj4gPiA+IGE5MDVjMTQuLmJiNzQ2NDAgMTAwNjQ0Cj4gPiA+ IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hk bWkudHh0Cj4gPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0v YnJpZGdlL2R3X2hkbWkudHh0Cj4gPiA+IEBAIC0yMiw2ICsyMiwxMSBAQCBPcHRpb25hbCBwcm9w ZXJ0aWVzCj4gPiA+IAo+ID4gPiAgLSBkZGMtaTJjLWJ1czogcGhhbmRsZSBvZiBhbiBJMkMgY29u dHJvbGxlciB1c2VkIGZvciBEREMgRURJRCBwcm9iaW5nCj4gPiA+ICAtIGNsb2NrcywgY2xvY2st bmFtZXM6IHBoYW5kbGUgdG8gdGhlIEhETUkgQ0VDIGNsb2NrLCBuYW1lIHNob3VsZCBiZQo+ID4g PiAgImNlYyIKPiA+ID4gCj4gPiA+ICtPcHRpb25hbCBzdXBwbGllczoKPiA+ID4gK3JvY2tjaGlw LHJrMzI4OC1kdy1oZG1pIGhhbmRsZXMgdHdvIG9wdGlvbmFsIHBvd2VyIHN1cHBsaWVzOgo+ID4g PiArLSB2cC1zdXBwbHk6IDEuMFYgcG93ZXIgc3VwcGx5Cj4gPiA+ICstIHZwaC1zdXBwbHk6IDEu OFYgcG93ZXIgc3VwcGx5Cj4gCj4gSWYgdGhpcyBpcyBzcGVjaWZpYyB0byB0aGUgUm9ja2NoaXAg aW1wbGVtZW50YXRpb24sIHNob3VsZG4ndCB0aGlzIGdvCj4gaW50byBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdmlkZW8vZHdfaGRtaS1yb2NrY2hpcC50eHQ/IEl0Cj4gY291bGQg dGhlbiBzaW1wbHkgZ28gaW50byB0aGUgUm9ja2NoaXAgRFJNIHRyZWUuCgphY3R1YWxseSwgd2Ug ZGV0ZXJtaW5lZCB0aGF0IHRoZSBzdXBwbHkgbmFtZXMgYXJlIHVuaXZlcnNhbCB0byB0aGUgSVAg KGJvdGggaW4gCmlteCBhbmQgcm9ja2NoaXAgYW5kIHByb2JhYmx5IG1vcmUgaWYgdGhlcmUgYXJl IG1vcmUgdXNlcnMgb3V0IHRoZXJlKS4gSnVzdCAKUnVzc2VsbCByZXF1ZXN0ZWQgdGhhdCB3ZSBk b24ndCBwb2xsdXRlIHRoZSBnZW5lcmljIGNvZGUgdW50aWwgbmVjZXNzYXJ5LCBhcyAKaXQgbG9v a3MgbGlrZSB0aGUgc3VwcGx5IG9mIHRob3NlIGlzIHNvbWVob3cgaGFuZGxlZCBpbnRlcm5hbGx5 IG9uIHRoZSBpbXguCgoKSGVpa28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Fri, 05 Jun 2015 14:16:40 +0200 Subject: [PATCH v3 1/2] drm/bridge: dw-hdmi: support optional supply regulators In-Reply-To: <20150605110159.GA16254@ulmo.nvidia.com> References: <4184159.j0iXe39dFB@phil> <2619686.csNBBFyt8W@phil> <20150605110159.GA16254@ulmo.nvidia.com> Message-ID: <23123577.mOoqGCAPdL@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thierry Am Freitag, 5. Juni 2015, 13:02:01 schrieb Thierry Reding: > On Mon, Mar 23, 2015 at 07:17:49PM +0100, Heiko Stuebner wrote: > > Hi Philipp, > > > > Am Donnerstag, 12. M?rz 2015, 21:45:19 schrieb Heiko Stuebner: > > > At least the Rockchip variant of the dw_hdmi can have controllable power > > > supplies providing 1.0 and 1.8V. Therefore add the possibility for the > > > generic bridge driver to enable supplies provided by the hw-specific > > > drivers. > > > > > > Signed-off-by: Heiko Stuebner > > > > does this look ok now? > > > > And as we talked about in Chemnitz, who will be taking such bridge-related > > changes, as you mentioned some last bridge-patches going through Thierry. > > Sorry, I had completely missed this. > > > > --- > > > changes since v2: > > > - rename supplies to the names found in the hdmi IP databook > > > changes since v1: > > > - follow suggestion from Russell King to keep regulator handling local > > > > > > to the rockchip implementation for the time being and only generalize > > > when a real second implementation needs regulator handling > > > > > > .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 5 ++++ > > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 32 > > > > > > +++++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > > b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt index > > > a905c14..bb74640 100644 > > > --- a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > > +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > > @@ -22,6 +22,11 @@ Optional properties > > > > > > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > > > - clocks, clock-names: phandle to the HDMI CEC clock, name should be > > > "cec" > > > > > > +Optional supplies: > > > +rockchip,rk3288-dw-hdmi handles two optional power supplies: > > > +- vp-supply: 1.0V power supply > > > +- vph-supply: 1.8V power supply > > If this is specific to the Rockchip implementation, shouldn't this go > into Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt? It > could then simply go into the Rockchip DRM tree. actually, we determined that the supply names are universal to the IP (both in imx and rockchip and probably more if there are more users out there). Just Russell requested that we don't pollute the generic code until necessary, as it looks like the supply of those is somehow handled internally on the imx. Heiko