Re: [PATCH] MIPS: Fix cacheinfo overflow

[Justin Chen <justin.chen@broadcom.com>]

On 02/10/2017 03:44 PM, James Hogan wrote:
> Hi Justin,
>
> On Fri, Feb 10, 2017 at 03:10:47PM -0800, Justin Chen wrote:
>> I actually submitted a v2 of the patch sometime back located here:
>> https://patchwork.linux-mips.org/patch/15107/
>>
>> The v2 had some code review changes from Matt Redfearn. These changes
>> indirectly got rid of the error, which was why I wasn't running into the
>> crash.
>
> Ah yes. It looks like Ralf applied the original patch on January 3rd,
> before the last 3 submissions of the patch.
>
> Incidentally, in future I'd recommend incrementing the patch version
> number each time you submit a new version, and mentioning what has
> changed in a comment at the bottom of the commit message (anything after
> "---" gets dropped when the patch is applied).
>
> A random example:
> https://patchwork.linux-mips.org/patch/15134/
Got it. Sorry, will do next time!
>
>>
>> Either way, whatever makes more sense, we can drop the other v1 patch
>> and add v2 or just add this patch on top.
>
> Since the patch has already been applied for a while and the merge
> window is imminent, I think its best to make do with fixup patches on
> top this time around.
Sounds good to me.
>
> Thanks
> James
>