From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ajmera, Megha" <megha.ajmera@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free
Date: Sun, 12 Mar 2023 15:34:33 +0100 [thread overview]
Message-ID: <2313696.BjyWNHgNrj@thomas> (raw)
In-Reply-To: <CH0PR11MB57247AF9CAD649FC14C3A0EBEBB49@CH0PR11MB5724.namprd11.prod.outlook.com>
> > When running the qos_sched app with separated worker and Tx threads, the
> > app would seg-fault after a short time of handling packets. The root
> > cause of this turns out to be an incorrect array index when freeing
> > unsent packets post-Tx. Rather than freeing packets using the "nb_tx"
> > value i.e. where transmission failed, the function was freeing packets
> > using the "nb_pkts" value, i.e. going beyond the number of packets
> > previously received into the buffer.
> >
> > Fixes: 39b25117c40b ("examples/qos_sched: remove Tx buffering")
> >
> > Reported-by: Megha Ajmera <megha.ajmera@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.
prev parent reply other threads:[~2023-03-12 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 14:09 [PATCH] examples/qos_sched: fix buffer overflow on mbuf free Bruce Richardson
2023-03-08 14:29 ` Dumitrescu, Cristian
2023-03-12 14:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2313696.BjyWNHgNrj@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=megha.ajmera@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.