From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 447B646B4 for ; Thu, 8 Sep 2022 16:51:42 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id d12-20020a05600c34cc00b003a83d20812fso2276091wmq.1 for ; Thu, 08 Sep 2022 09:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=mrMqJeHL2N1h5YAyTrrec9CeEwKwlyw0SO1YzY2f9pfRJGSVdOlHcFrmGSKiXw1Apo ScBrula6ozGf+tln/IXFTkzWqIP/D5NYEEBu7NoJUhGqkzh9AoM28r6qzDtTZnh0n+3O GZL9ws3a8VAdYQSSBtB2J6kXuKlcmNF+TpVV2dV+XviwVdibSwcjpfjg9Gl9Y9DvmMrQ 3vKTmRGcutvFGjffbl1PsGbkYZnm8Kp2ARj2Lt2IQCHG31+8QjhbI/CKAH4dd5s1Qrrq +f9+ZubY6dtkvfoydCQWiLB3p5YYO1z5Ko+pcWcIhAej+JfYw/33EgEj+9qNBA8a/AOM +upQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=BQkf1MkmIDT8EFe3zbnyEmo/s9rVL8apcgYCbicZguSpZ1+XZw9u1Sk5FmjnlXYcZF UK7Ir2JDDyMU2AWmit5p9KSiTZ9NMe9hfQA0DAWmhQE+xudB1TVOFM5SJhjDnIAF1mxj KalhHQNCRRqGcE4t+9Wywx5qYbXjd+4OTw0lpPid2ci30wwDT19ToNBUXUX61JYCxVlw OXhSz1SMTgwUtaU4+5cIyN+5gkc6eV7DxApRSg6722WEp3gdbBJEEgksmxPmISuR1RiB hKbCR/bIeuch6jLG1wV0Zl+vrlok07G8IiE+zfSJjBMB0x/XQAw1juf9S8wcKzq+0zTv OYLw== X-Gm-Message-State: ACgBeo3a9eFuKqvMuGzYRcJcWiD5gaC3hqqK21FqbNy8YfBJiOXXxwwn iUN9KSX4R5FZo28F00eCqFs= X-Google-Smtp-Source: AA6agR7PpD+198B5Y3yHlP3CrDqe+4xxzwp+pmGtD3TVKQAJdPtBsk5cDvgpY5VnGVgDIaunPcagbQ== X-Received: by 2002:a05:600c:3309:b0:3b2:973d:b533 with SMTP id q9-20020a05600c330900b003b2973db533mr2951570wmp.105.1662655900588; Thu, 08 Sep 2022 09:51:40 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b003a342933727sm3814303wmq.3.2022.09.08.09.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:51:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , dri-devel Subject: Re: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:51:38 +0200 Message-ID: <2313716.NG923GbCHz@kista> In-Reply-To: <1800669.atdPhlSkOF@kista> References: <20220906153034.153321-1-peron.clem@gmail.com> <1800669.atdPhlSkOF@kista> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 08. september 2022 ob 18:26:31 CEST je Jernej =C5=A0krabe= c napisal(a): > Dne torek, 06. september 2022 ob 21:26:34 CEST je Cl=C3=A9ment P=C3=A9ron= napisal(a): > > Hi Jernej, > >=20 > > On Tue, 6 Sept 2022 at 21:10, Jernej =C5=A0krabec >=20 > wrote: > > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Cl=C3=A9ment P=C3= =A9ron >=20 > napisal(a): > > > > Add an Operating Performance Points table for the GPU to > > > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > >=20 > > > > The voltage range is set with minimal voltage set to the target > > > > and the maximal voltage set to 1.2V. This allow DVFS framework to > > > > work properly on board with fixed regulator. > > > >=20 > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > --- > > > >=20 > > > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 87 > > > > +++++++++++++++++++ > > > > 1 file changed, 87 insertions(+) > > > > create mode 100644 > > > > arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > >=20 > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode > > > > 100644 > > > > index 000000000000..b48049c4fc85 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > @@ -0,0 +1,87 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +// Copyright (C) 2022 Cl=C3=A9ment P=C3=A9ron > > > > + > > > > +/ { > > > > + gpu_opp_table: opp-table-gpu { > > > > + compatible =3D "operating-points-v2"; > > > > + > > > > + opp-216000000 { > > > > + opp-hz =3D /bits/ 64 <216000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-264000000 { > > > > + opp-hz =3D /bits/ 64 <264000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > >=20 > > > As mentioned in clock patch review, rates below 288 MHz are deemed > > > unstable on GPU PLL by vendor GPU kernel driver. At least in the BSP > > > version that I have. Did you test these points? If not, better to drop > > > them. > >=20 > > I changed the governor to userspace and set the freq to 216MHz / 264MHz > > Run glmark2 and didn't observe any glitch nor issue. > >=20 > > I'm not sure if it's enough to say it's stable but I didn't observe > > any strange behavior. >=20 > Ok then. >=20 > Forgot to ask, where did you get 1.2 V as an upper limit? H6 datasheet li= sts > max. GPU voltage as 1.08 V. To answer my own question, absolute max. voltage is 1.3 V, so 1.2 V is stil= l=20 somewhat acceptable and in practice, fixed regulator on Tanix TX6 board is= =20 around 1.12 V. Boards with PMIC can set lower voltage anyway. All good. Acked-by: Jernej Skrabec =20 Best regards, Jernej =20 > > Regards, > > Clement > >=20 > > > Best regards, > > > Jernej > > >=20 > > > > + > > > > + opp-312000000 { > > > > + opp-hz =3D /bits/ 64 <312000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-336000000 { > > > > + opp-hz =3D /bits/ 64 <336000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-360000000 { > > > > + opp-hz =3D /bits/ 64 <360000000>; > > > > + opp-microvolt =3D <820000 820000 1200000>; > > > > + }; > > > > + > > > > + opp-384000000 { > > > > + opp-hz =3D /bits/ 64 <384000000>; > > > > + opp-microvolt =3D <830000 830000 1200000>; > > > > + }; > > > > + > > > > + opp-408000000 { > > > > + opp-hz =3D /bits/ 64 <408000000>; > > > > + opp-microvolt =3D <840000 840000 1200000>; > > > > + }; > > > > + > > > > + opp-420000000 { > > > > + opp-hz =3D /bits/ 64 <420000000>; > > > > + opp-microvolt =3D <850000 850000 1200000>; > > > > + }; > > > > + > > > > + opp-432000000 { > > > > + opp-hz =3D /bits/ 64 <432000000>; > > > > + opp-microvolt =3D <860000 860000 1200000>; > > > > + }; > > > > + > > > > + opp-456000000 { > > > > + opp-hz =3D /bits/ 64 <456000000>; > > > > + opp-microvolt =3D <870000 870000 1200000>; > > > > + }; > > > > + > > > > + opp-504000000 { > > > > + opp-hz =3D /bits/ 64 <504000000>; > > > > + opp-microvolt =3D <890000 890000 1200000>; > > > > + }; > > > > + > > > > + opp-540000000 { > > > > + opp-hz =3D /bits/ 64 <540000000>; > > > > + opp-microvolt =3D <910000 910000 1200000>; > > > > + }; > > > > + > > > > + opp-576000000 { > > > > + opp-hz =3D /bits/ 64 <576000000>; > > > > + opp-microvolt =3D <930000 930000 1200000>; > > > > + }; > > > > + > > > > + opp-624000000 { > > > > + opp-hz =3D /bits/ 64 <624000000>; > > > > + opp-microvolt =3D <950000 950000 1200000>; > > > > + }; > > > > + > > > > + opp-756000000 { > > > > + opp-hz =3D /bits/ 64 <756000000>; > > > > + opp-microvolt =3D <1040000 1040000 1200000>; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&gpu { > > > > + operating-points-v2 =3D <&gpu_opp_table>; > > > > +}; > > > > -- > > > > 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE65C54EE9 for ; Thu, 8 Sep 2022 16:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+2C1Jsi3+RwFWEEP3SLZFJO9Kmm+vPX64SwixiqsPSg=; b=3z8d0az95L2YoY zDiIsepzKNpr1MNTukd9DkSv7RE1b/gB+7UyKiyhRZjSunzV+dLA8StnlErwV/tW839gWmGM5gEtw vGuXr4QA8eDUUFgUCVYAuaK5OmiTiwJspaj6moslYmjaGCkMWVK4e/FYKj2lFJQe2qb24CBKeL/ct cIsHHUn2s18OA5oSyeMawZeNF6zPIReGNBQ+IBGtQ0dUqXRLgGhIVC7D2GfTYjH2xa8Ta/vUoVIHL Kx1AvrXH7Z2gPag9S+0ExOq7dOIPQQ0E+SLDhZfHJoU18S08pBUaElwwjz+7dkeOPXDvXw+34BPGV P3LX7lHHbxlP5MpspS9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWKkl-005yOR-42; Thu, 08 Sep 2022 16:51:47 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWKkh-005yLq-J8 for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 16:51:45 +0000 Received: by mail-wm1-x329.google.com with SMTP id bd26-20020a05600c1f1a00b003a5e82a6474so2271745wmb.4 for ; Thu, 08 Sep 2022 09:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=mrMqJeHL2N1h5YAyTrrec9CeEwKwlyw0SO1YzY2f9pfRJGSVdOlHcFrmGSKiXw1Apo ScBrula6ozGf+tln/IXFTkzWqIP/D5NYEEBu7NoJUhGqkzh9AoM28r6qzDtTZnh0n+3O GZL9ws3a8VAdYQSSBtB2J6kXuKlcmNF+TpVV2dV+XviwVdibSwcjpfjg9Gl9Y9DvmMrQ 3vKTmRGcutvFGjffbl1PsGbkYZnm8Kp2ARj2Lt2IQCHG31+8QjhbI/CKAH4dd5s1Qrrq +f9+ZubY6dtkvfoydCQWiLB3p5YYO1z5Ko+pcWcIhAej+JfYw/33EgEj+9qNBA8a/AOM +upQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=KGjcnUngz5Su813EI6LZWs/wxeFkVqKeG+L8loVS0iRl2najPWSwaVoZAGiCAQdhki BxQVomvmwMKXLx6OJ9Tud17m8EwXxXYij9VaaTja1okccvTEhJ6nqK+nkfVawpBGFq5s L/dpU6ZqsVV5o4ATEwUblk92HMv5XrRoIVSKcORzqzMkqlX1FS51nZSi19yC6j/aHygw A7Vyn2HTml/3WRWmNBqT/lI1nr4NjNFoH0n7RDZ3TFDvwtFdE/pqWhSZ0Pecv0CYmmvR 5q6NDg/2BuN+zit+Wg81A6xEACIJNqjv3vy9w0xOdI9jbv9/UnDmYLoBCvVhAhB1Cfly nB5w== X-Gm-Message-State: ACgBeo2+RZwQOxSUiDFfRG9pmtqCJ8ONQYIt1Bmv2o9VFpL0sWcPZcBw VvpFtzRvW3ZsWEt6b9yAuZYRT2WCMPufuQ== X-Google-Smtp-Source: AA6agR7PpD+198B5Y3yHlP3CrDqe+4xxzwp+pmGtD3TVKQAJdPtBsk5cDvgpY5VnGVgDIaunPcagbQ== X-Received: by 2002:a05:600c:3309:b0:3b2:973d:b533 with SMTP id q9-20020a05600c330900b003b2973db533mr2951570wmp.105.1662655900588; Thu, 08 Sep 2022 09:51:40 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b003a342933727sm3814303wmq.3.2022.09.08.09.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:51:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , dri-devel Subject: Re: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:51:38 +0200 Message-ID: <2313716.NG923GbCHz@kista> In-Reply-To: <1800669.atdPhlSkOF@kista> References: <20220906153034.153321-1-peron.clem@gmail.com> <1800669.atdPhlSkOF@kista> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_095143_680228_C3E851C8 X-CRM114-Status: GOOD ( 29.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAwOC4gc2VwdGVtYmVyIDIwMjIgb2IgMTg6MjY6MzEgQ0VTVCBqZSBKZXJu ZWogxaBrcmFiZWMgbmFwaXNhbChhKToKPiBEbmUgdG9yZWssIDA2LiBzZXB0ZW1iZXIgMjAyMiBv YiAyMToyNjozNCBDRVNUIGplIENsw6ltZW50IFDDqXJvbiBuYXBpc2FsKGEpOgo+ID4gSGkgSmVy bmVqLAo+ID4gCj4gPiBPbiBUdWUsIDYgU2VwdCAyMDIyIGF0IDIxOjEwLCBKZXJuZWogxaBrcmFi ZWMgPGplcm5lai5za3JhYmVjQGdtYWlsLmNvbT4KPiAKPiB3cm90ZToKPiA+ID4gRG5lIHRvcmVr LCAwNi4gc2VwdGVtYmVyIDIwMjIgb2IgMTc6MzA6MzIgQ0VTVCBqZSBDbMOpbWVudCBQw6lyb24K PiAKPiBuYXBpc2FsKGEpOgo+ID4gPiA+IEFkZCBhbiBPcGVyYXRpbmcgUGVyZm9ybWFuY2UgUG9p bnRzIHRhYmxlIGZvciB0aGUgR1BVIHRvCj4gPiA+ID4gZW5hYmxlIER5bmFtaWMgVm9sdGFnZSAm IEZyZXF1ZW5jeSBTY2FsaW5nIG9uIHRoZSBINi4KPiA+ID4gPiAKPiA+ID4gPiBUaGUgdm9sdGFn ZSByYW5nZSBpcyBzZXQgd2l0aCBtaW5pbWFsIHZvbHRhZ2Ugc2V0IHRvIHRoZSB0YXJnZXQKPiA+ ID4gPiBhbmQgdGhlIG1heGltYWwgdm9sdGFnZSBzZXQgdG8gMS4yVi4gVGhpcyBhbGxvdyBEVkZT IGZyYW1ld29yayB0bwo+ID4gPiA+IHdvcmsgcHJvcGVybHkgb24gYm9hcmQgd2l0aCBmaXhlZCBy ZWd1bGF0b3IuCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2zDqW1lbnQgUMOpcm9u IDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAKPiA+ID4gPiAgLi4u L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGktaDYtZ3B1LW9wcC5kdHNpIHwgODcKPiA+ID4gPiAg KysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgODcgaW5zZXJ0aW9u cygrKQo+ID4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQKPiA+ID4gPiAgYXJjaC9hcm02NC9ib290 L2R0cy9hbGx3aW5uZXIvc3VuNTBpLWg2LWdwdS1vcHAuZHRzaQo+ID4gPiA+IAo+ID4gPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGktaDYtZ3B1LW9w cC5kdHNpCj4gPiA+ID4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGktaDYt Z3B1LW9wcC5kdHNpIG5ldyBmaWxlIG1vZGUKPiA+ID4gPiAxMDA2NDQKPiA+ID4gPiBpbmRleCAw MDAwMDAwMDAwMDAuLmI0ODA0OWM0ZmM4NQo+ID4gPiA+IC0tLSAvZGV2L251bGwKPiA+ID4gPiAr KysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FsbHdpbm5lci9zdW41MGktaDYtZ3B1LW9wcC5kdHNp Cj4gPiA+ID4gQEAgLTAsMCArMSw4NyBAQAo+ID4gPiA+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRp ZmllcjogKEdQTC0yLjArIE9SIE1JVCkKPiA+ID4gPiArLy8gQ29weXJpZ2h0IChDKSAyMDIyIENs w6ltZW50IFDDqXJvbiA8cGVyb24uY2xlbUBnbWFpbC5jb20+Cj4gPiA+ID4gKwo+ID4gPiA+ICsv IHsKPiA+ID4gPiArICAgICBncHVfb3BwX3RhYmxlOiBvcHAtdGFibGUtZ3B1IHsKPiA+ID4gPiAr ICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAib3BlcmF0aW5nLXBvaW50cy12MiI7Cj4gPiA+ID4g Kwo+ID4gPiA+ICsgICAgICAgICAgICAgb3BwLTIxNjAwMDAwMCB7Cj4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8MjE2MDAwMDAwPjsKPiA+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw4MTAwMDAgODEwMDAwIDEyMDAwMDA+ Owo+ID4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAg ICBvcHAtMjY0MDAwMDAwIHsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0g L2JpdHMvIDY0IDwyNjQwMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAt bWljcm92b2x0ID0gPDgxMDAwMCA4MTAwMDAgMTIwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAg ICB9Owo+ID4gPiAKPiA+ID4gQXMgbWVudGlvbmVkIGluIGNsb2NrIHBhdGNoIHJldmlldywgcmF0 ZXMgYmVsb3cgMjg4IE1IeiBhcmUgZGVlbWVkCj4gPiA+IHVuc3RhYmxlIG9uIEdQVSBQTEwgYnkg dmVuZG9yIEdQVSBrZXJuZWwgZHJpdmVyLiBBdCBsZWFzdCBpbiB0aGUgQlNQCj4gPiA+IHZlcnNp b24gdGhhdCBJIGhhdmUuIERpZCB5b3UgdGVzdCB0aGVzZSBwb2ludHM/IElmIG5vdCwgYmV0dGVy IHRvIGRyb3AKPiA+ID4gdGhlbS4KPiA+IAo+ID4gSSBjaGFuZ2VkIHRoZSBnb3Zlcm5vciB0byB1 c2Vyc3BhY2UgYW5kIHNldCB0aGUgZnJlcSB0byAyMTZNSHogLyAyNjRNSHoKPiA+IFJ1biBnbG1h cmsyIGFuZCBkaWRuJ3Qgb2JzZXJ2ZSBhbnkgZ2xpdGNoIG5vciBpc3N1ZS4KPiA+IAo+ID4gSSdt IG5vdCBzdXJlIGlmIGl0J3MgZW5vdWdoIHRvIHNheSBpdCdzIHN0YWJsZSBidXQgSSBkaWRuJ3Qg b2JzZXJ2ZQo+ID4gYW55IHN0cmFuZ2UgYmVoYXZpb3IuCj4gCj4gT2sgdGhlbi4KPiAKPiBGb3Jn b3QgdG8gYXNrLCB3aGVyZSBkaWQgeW91IGdldCAxLjIgViBhcyBhbiB1cHBlciBsaW1pdD8gSDYg ZGF0YXNoZWV0IGxpc3RzCj4gbWF4LiBHUFUgdm9sdGFnZSBhcyAxLjA4IFYuCgpUbyBhbnN3ZXIg bXkgb3duIHF1ZXN0aW9uLCBhYnNvbHV0ZSBtYXguIHZvbHRhZ2UgaXMgMS4zIFYsIHNvIDEuMiBW IGlzIHN0aWxsIApzb21ld2hhdCBhY2NlcHRhYmxlIGFuZCBpbiBwcmFjdGljZSwgZml4ZWQgcmVn dWxhdG9yIG9uIFRhbml4IFRYNiBib2FyZCBpcyAKYXJvdW5kIDEuMTIgVi4gQm9hcmRzIHdpdGgg UE1JQyBjYW4gc2V0IGxvd2VyIHZvbHRhZ2UgYW55d2F5LgoKQWxsIGdvb2QuCkFja2VkLWJ5OiBK ZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAZ21haWwuY29tPgogCkJlc3QgcmVnYXJkcywK SmVybmVqCiAKPiA+IFJlZ2FyZHMsCj4gPiBDbGVtZW50Cj4gPiAKPiA+ID4gQmVzdCByZWdhcmRz LAo+ID4gPiBKZXJuZWoKPiA+ID4gCj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgICAgICAgb3Bw LTMxMjAwMDAwMCB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRz LyA2NCA8MzEyMDAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jv dm9sdCA9IDw4MTAwMDAgODEwMDAwIDEyMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgfTsK PiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAgICBvcHAtMzM2MDAwMDAwIHsKPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDwzMzYwMDAwMDA+Owo+ID4g PiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDgxMDAwMCA4MTAwMDAg MTIwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiA+ICsKPiA+ID4gPiArICAg ICAgICAgICAgIG9wcC0zNjAwMDAwMDAgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBv cHAtaHogPSAvYml0cy8gNjQgPDM2MDAwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgIG9wcC1taWNyb3ZvbHQgPSA8ODIwMDAwIDgyMDAwMCAxMjAwMDAwPjsKPiA+ID4gPiArICAg ICAgICAgICAgIH07Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgICAgICAgb3BwLTM4NDAwMDAw MCB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8Mzg0 MDAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw4 MzAwMDAgODMwMDAwIDEyMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4gPiAr Cj4gPiA+ID4gKyAgICAgICAgICAgICBvcHAtNDA4MDAwMDAwIHsKPiA+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw0MDgwMDAwMDA+Owo+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDg0MDAwMCA4NDAwMDAgMTIwMDAwMD47 Cj4gPiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICAg IG9wcC00MjAwMDAwMDAgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAv Yml0cy8gNjQgPDQyMDAwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1t aWNyb3ZvbHQgPSA8ODUwMDAwIDg1MDAwMCAxMjAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAg IH07Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgICAgICAgb3BwLTQzMjAwMDAwMCB7Cj4gPiA+ ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NDMyMDAwMDAwPjsK PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw4NjAwMDAgODYw MDAwIDEyMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4gPiArCj4gPiA+ID4g KyAgICAgICAgICAgICBvcHAtNDU2MDAwMDAwIHsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw0NTYwMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICBvcHAtbWljcm92b2x0ID0gPDg3MDAwMCA4NzAwMDAgMTIwMDAwMD47Cj4gPiA+ID4g KyAgICAgICAgICAgICB9Owo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICAgIG9wcC01MDQw MDAwMDAgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQg PDUwNDAwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQg PSA8ODkwMDAwIDg5MDAwMCAxMjAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgIH07Cj4gPiA+ ID4gKwo+ID4gPiA+ICsgICAgICAgICAgICAgb3BwLTU0MDAwMDAwMCB7Cj4gPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NTQwMDAwMDAwPjsKPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw5MTAwMDAgOTEwMDAwIDEyMDAw MDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgfTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAg ICAgICBvcHAtNTc2MDAwMDAwIHsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgb3BwLWh6 ID0gL2JpdHMvIDY0IDw1NzYwMDAwMDA+Owo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBv cHAtbWljcm92b2x0ID0gPDkzMDAwMCA5MzAwMDAgMTIwMDAwMD47Cj4gPiA+ID4gKyAgICAgICAg ICAgICB9Owo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICAgIG9wcC02MjQwMDAwMDAgewo+ ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDYyNDAwMDAw MD47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8OTUwMDAw IDk1MDAwMCAxMjAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgIH07Cj4gPiA+ID4gKwo+ID4g PiA+ICsgICAgICAgICAgICAgb3BwLTc1NjAwMDAwMCB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NzU2MDAwMDAwPjsKPiA+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDwxMDQwMDAwIDEwNDAwMDAgMTIwMDAwMD47Cj4g PiA+ID4gKyAgICAgICAgICAgICB9Owo+ID4gPiA+ICsgICAgIH07Cj4gPiA+ID4gK307Cj4gPiA+ ID4gKwo+ID4gPiA+ICsmZ3B1IHsKPiA+ID4gPiArICAgICBvcGVyYXRpbmctcG9pbnRzLXYyID0g PCZncHVfb3BwX3RhYmxlPjsKPiA+ID4gPiArfTsKPiA+ID4gPiAtLQo+ID4gPiA+IDIuMzQuMQoK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB28C38145 for ; Thu, 8 Sep 2022 16:51:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C72210EB78; Thu, 8 Sep 2022 16:51:46 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2524810EA02 for ; Thu, 8 Sep 2022 16:51:42 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id n17-20020a05600c501100b003a84bf9b68bso2269411wmr.3 for ; Thu, 08 Sep 2022 09:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=mrMqJeHL2N1h5YAyTrrec9CeEwKwlyw0SO1YzY2f9pfRJGSVdOlHcFrmGSKiXw1Apo ScBrula6ozGf+tln/IXFTkzWqIP/D5NYEEBu7NoJUhGqkzh9AoM28r6qzDtTZnh0n+3O GZL9ws3a8VAdYQSSBtB2J6kXuKlcmNF+TpVV2dV+XviwVdibSwcjpfjg9Gl9Y9DvmMrQ 3vKTmRGcutvFGjffbl1PsGbkYZnm8Kp2ARj2Lt2IQCHG31+8QjhbI/CKAH4dd5s1Qrrq +f9+ZubY6dtkvfoydCQWiLB3p5YYO1z5Ko+pcWcIhAej+JfYw/33EgEj+9qNBA8a/AOM +upQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=e5KYqEBWQ8THQ17spmw0xDJTw5S+n1XJ78rOUrMQLWE=; b=cQGhFpQuDthgFegxrRp9hPyhOaStmWtAxbO22tfxVKGvEu/f2uH0kD/kSGOHby7LTD EYPEUdo/VYdhEbHFuQftOJtZN40JKxXr4ADXVmLHMQ3SIcxxuLlZfUnFSFIJumUNjHR0 MWf5Q9HJFGrROAuTKmxtTV4IG9f+4Nt+jUT3cqaIVYhbwZSUgzLw5DcbjDodA2cLjpd6 i450j6Q5RoVCPRU034nxceyI1U3pHRekjcdl8qyR6sCCGij3Id0xDIfBUnHb80HJAfYI 9UZg2yF9LXH8gJAC7GhgFCb8zlfwxqtVKrqwj+YWNACdp3gJ3Q4fhY6tOWOe9TxYZbeA Heog== X-Gm-Message-State: ACgBeo3x23W07M0YyhL+kYh8TLjnlbaeXsemweIqQMHJ5vHcIr0f8ib1 3zDrgu3vBYAwm5l5NFqM8sI= X-Google-Smtp-Source: AA6agR7PpD+198B5Y3yHlP3CrDqe+4xxzwp+pmGtD3TVKQAJdPtBsk5cDvgpY5VnGVgDIaunPcagbQ== X-Received: by 2002:a05:600c:3309:b0:3b2:973d:b533 with SMTP id q9-20020a05600c330900b003b2973db533mr2951570wmp.105.1662655900588; Thu, 08 Sep 2022 09:51:40 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b003a342933727sm3814303wmq.3.2022.09.08.09.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 09:51:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Subject: Re: Re: Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table Date: Thu, 08 Sep 2022 18:51:38 +0200 Message-ID: <2313716.NG923GbCHz@kista> In-Reply-To: <1800669.atdPhlSkOF@kista> References: <20220906153034.153321-1-peron.clem@gmail.com> <1800669.atdPhlSkOF@kista> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Samuel Holland , linux-kernel , dri-devel , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , linux-sunxi@lists.linux.dev, linux-arm-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne =C4=8Detrtek, 08. september 2022 ob 18:26:31 CEST je Jernej =C5=A0krabe= c napisal(a): > Dne torek, 06. september 2022 ob 21:26:34 CEST je Cl=C3=A9ment P=C3=A9ron= napisal(a): > > Hi Jernej, > >=20 > > On Tue, 6 Sept 2022 at 21:10, Jernej =C5=A0krabec >=20 > wrote: > > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Cl=C3=A9ment P=C3= =A9ron >=20 > napisal(a): > > > > Add an Operating Performance Points table for the GPU to > > > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > >=20 > > > > The voltage range is set with minimal voltage set to the target > > > > and the maximal voltage set to 1.2V. This allow DVFS framework to > > > > work properly on board with fixed regulator. > > > >=20 > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > --- > > > >=20 > > > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 87 > > > > +++++++++++++++++++ > > > > 1 file changed, 87 insertions(+) > > > > create mode 100644 > > > > arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > >=20 > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file mode > > > > 100644 > > > > index 000000000000..b48049c4fc85 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > @@ -0,0 +1,87 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +// Copyright (C) 2022 Cl=C3=A9ment P=C3=A9ron > > > > + > > > > +/ { > > > > + gpu_opp_table: opp-table-gpu { > > > > + compatible =3D "operating-points-v2"; > > > > + > > > > + opp-216000000 { > > > > + opp-hz =3D /bits/ 64 <216000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-264000000 { > > > > + opp-hz =3D /bits/ 64 <264000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > >=20 > > > As mentioned in clock patch review, rates below 288 MHz are deemed > > > unstable on GPU PLL by vendor GPU kernel driver. At least in the BSP > > > version that I have. Did you test these points? If not, better to drop > > > them. > >=20 > > I changed the governor to userspace and set the freq to 216MHz / 264MHz > > Run glmark2 and didn't observe any glitch nor issue. > >=20 > > I'm not sure if it's enough to say it's stable but I didn't observe > > any strange behavior. >=20 > Ok then. >=20 > Forgot to ask, where did you get 1.2 V as an upper limit? H6 datasheet li= sts > max. GPU voltage as 1.08 V. To answer my own question, absolute max. voltage is 1.3 V, so 1.2 V is stil= l=20 somewhat acceptable and in practice, fixed regulator on Tanix TX6 board is= =20 around 1.12 V. Boards with PMIC can set lower voltage anyway. All good. Acked-by: Jernej Skrabec =20 Best regards, Jernej =20 > > Regards, > > Clement > >=20 > > > Best regards, > > > Jernej > > >=20 > > > > + > > > > + opp-312000000 { > > > > + opp-hz =3D /bits/ 64 <312000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-336000000 { > > > > + opp-hz =3D /bits/ 64 <336000000>; > > > > + opp-microvolt =3D <810000 810000 1200000>; > > > > + }; > > > > + > > > > + opp-360000000 { > > > > + opp-hz =3D /bits/ 64 <360000000>; > > > > + opp-microvolt =3D <820000 820000 1200000>; > > > > + }; > > > > + > > > > + opp-384000000 { > > > > + opp-hz =3D /bits/ 64 <384000000>; > > > > + opp-microvolt =3D <830000 830000 1200000>; > > > > + }; > > > > + > > > > + opp-408000000 { > > > > + opp-hz =3D /bits/ 64 <408000000>; > > > > + opp-microvolt =3D <840000 840000 1200000>; > > > > + }; > > > > + > > > > + opp-420000000 { > > > > + opp-hz =3D /bits/ 64 <420000000>; > > > > + opp-microvolt =3D <850000 850000 1200000>; > > > > + }; > > > > + > > > > + opp-432000000 { > > > > + opp-hz =3D /bits/ 64 <432000000>; > > > > + opp-microvolt =3D <860000 860000 1200000>; > > > > + }; > > > > + > > > > + opp-456000000 { > > > > + opp-hz =3D /bits/ 64 <456000000>; > > > > + opp-microvolt =3D <870000 870000 1200000>; > > > > + }; > > > > + > > > > + opp-504000000 { > > > > + opp-hz =3D /bits/ 64 <504000000>; > > > > + opp-microvolt =3D <890000 890000 1200000>; > > > > + }; > > > > + > > > > + opp-540000000 { > > > > + opp-hz =3D /bits/ 64 <540000000>; > > > > + opp-microvolt =3D <910000 910000 1200000>; > > > > + }; > > > > + > > > > + opp-576000000 { > > > > + opp-hz =3D /bits/ 64 <576000000>; > > > > + opp-microvolt =3D <930000 930000 1200000>; > > > > + }; > > > > + > > > > + opp-624000000 { > > > > + opp-hz =3D /bits/ 64 <624000000>; > > > > + opp-microvolt =3D <950000 950000 1200000>; > > > > + }; > > > > + > > > > + opp-756000000 { > > > > + opp-hz =3D /bits/ 64 <756000000>; > > > > + opp-microvolt =3D <1040000 1040000 1200000>; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&gpu { > > > > + operating-points-v2 =3D <&gpu_opp_table>; > > > > +}; > > > > -- > > > > 2.34.1