From: Benjamin Robin <benjamin.robin@bootlin.com>
To: ross.burton@arm.com, openembedded-core@lists.openembedded.org,
Antonin Godard <antonin.godard@bootlin.com>
Subject: Re: [OE-core] [RFC PATCH 1/3] sbom-cve-check: refactor do_sbom_cve_check
Date: Fri, 03 Apr 2026 10:33:50 +0200 [thread overview]
Message-ID: <2314615.72vocr9iq0@brobin-bootlin> (raw)
In-Reply-To: <DHJDKO2Y1ZO9.10477FJ3PZOPQ@bootlin.com>
On Friday, April 3, 2026 at 10:26 AM, Antonin Godard wrote:
> Hi,
>
> On Thu Apr 2, 2026 at 6:25 PM CEST, Ross Burton via lists.openembedded.org wrote:
> [...]
> > +
> > +
> > +python do_sbom_cve_check() {
>
> I'd suggest renaming it to do_sbom_cve_check_image so you'll have
> do_sbom_cve_check_image and do_sbom_cve_check_recipe in the third patch and
> there's less confusion?
>
> Antonin
>
I fully agree with this proposal.
And we should do this change as soon as possible, since we are renaming
a "public" interface.
--
Benjamin Robin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-04-03 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 16:25 [RFC PATCH 1/3] sbom-cve-check: refactor do_sbom_cve_check Ross Burton
2026-04-02 16:25 ` [RFC PATCH 2/3] sbom-cve-check: move to classes from classes-recipe Ross Burton
2026-04-02 16:30 ` Patchtest results for " patchtest
2026-04-02 16:25 ` [RFC PATCH 3/3] sbom-cve-check: add prototype recipe scanning task Ross Burton
2026-04-03 8:24 ` Benjamin Robin
2026-04-03 8:19 ` [RFC PATCH 1/3] sbom-cve-check: refactor do_sbom_cve_check Benjamin Robin
2026-04-03 8:26 ` [OE-core] " Antonin Godard
2026-04-03 8:33 ` Benjamin Robin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2314615.72vocr9iq0@brobin-bootlin \
--to=benjamin.robin@bootlin.com \
--cc=antonin.godard@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.