Re: virtfs-proxy-helper fails due to bogus libattr test

[Christian Schoenebeck via <qemu-devel@nongnu.org>]

On Dienstag, 12. Januar 2021 10:51:10 CET Olaf Hering wrote:
> Depending on the build environment, the meson test to find a suitable
> libattr fails. Something appends -O0 to CFLAGS.
> 
> I see no "-O0" in qemu.git. This is a regression, it worked in
> 553032db17440f8de011390e5a1cfddd13751b0b.
> 
> Does anyone happen to know what is causing this?

Putting Paolo in CC in case he's got some suspicion. I don't see something 
obvious right now.

Olaf, could you run a 'git bisect' to identify the relevant commit causing 
this?

> 
> Olaf
> 
> ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu
> --program-prefix= --disable-dependency-tracking --prefix=/usr
> --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
> --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64
> --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib
> --mandir=/usr/share/man --infodir=/usr/share/info
> --disable-dependency-tracking --cc=/usr/bin/gcc-10
> --host-cc=/usr/bin/gcc-10 --cxx=/usr/bin/g++-10
> --docdir=/usr/share/doc/packages --firmwarepath=/usr/share/qemu/firmware
> '--target-list=i386-softmmu x86_64-softmmu' '--audio-drv-list=alsa pa'
> --iasl=/usr/bin/iasl --install=/usr/bin/install --objcc=/usr/bin/false
> --python=/usr/bin/python3 --ninja=/usr/bin/ninja --tls-priority=NORMAL
> --with-git=/usr/bin/false --with-suffix=qemu --disable-docs --disable-gtk
> --disable-libnfs --disable-opengl --disable-rbd --disable-spice
> --disable-virglrenderer --disable-vte --enable-attr --disable-brlapi
> --disable-bsd-user --enable-bzip2 --enable-cap-ng --disable-capstone
> --disable-cocoa --enable-coroutine-pool --disable-crypto-afalg
> --enable-curl --enable-curses --disable-debug-info --disable-debug-mutex
> --disable-debug-tcg --with-default-devices --enable-docs --disable-fdt
> --enable-gcrypt --enable-gettext --disable-git-update --disable-glusterfs
> --enable-gnutls --enable-gtk --enable-guest-agent --disable-guest-agent-msi
> --disable-hax --disable-hvf --enable-iconv --disable-jemalloc
> --disable-keyring --enable-kvm --disable-libdaxctl --disable-libiscsi
> --enable-libnfs --enable-libssh --enable-libusb --enable-libxml2
> --enable-linux-aio --disable-linux-user --enable-live-block-migration
> --disable-lzo --disable-lzfse --disable-malloc-trim --disable-membarrier
> --enable-modules --disable-mpath --disable-netmap --disable-nettle
> --enable-numa --enable-opengl --enable-pie --enable-plugins
> --disable-qom-cast-debug --enable-rbd --disable-rdma --enable-replication
> --enable-rng-none --disable-safe-stack --disable-sanitizers --disable-sdl
> --disable-sdl-image --disable-seccomp --disable-slirp --disable-smartcard
> --disable-snappy --disable-sparse --enable-spice --enable-stack-protector
> --disable-strip --enable-system --enable-tcg --disable-tcg-interpreter
> --disable-tcmalloc --enable-tools --disable-tpm --disable-tsan
> --disable-u2f --enable-usb-redir --disable-user --enable-vde
> --enable-vhost-crypto --enable-vhost-net --enable-vhost-scsi
> --enable-vhost-user --enable-vhost-user-fs --enable-vhost-vsock
> --enable-virglrenderer --enable-virtfs --disable-virtiofsd --enable-vnc
> --disable-vnc-jpeg --enable-vnc-png --disable-vnc-sasl --enable-vte
> --disable-werror --disable-whpx --enable-xen --enable-xen-pci-passthrough
> --enable-xfsctl ....
> [  223s] Run-time dependency libnfs found: YES 4.0.0
> [  223s] None of 'CC_LD' are defined in the environment, not changing global
> flags. [  223s] Running compile:
> [  223s] Working directory: 
> /home/abuild/rpmbuild/BUILD/qemu-20210111T151535.b3f846c59d/build/meson-pri
> vate/tmpg908fqs3 [  223s] Command line:  /usr/bin/gcc-10
> -I/usr/include/ncursesw
> /home/abuild/rpmbuild/BUILD/qemu-20210111T151535.b3f846c59d/build/meson-pri
> vate/tmpg908fqs3/testfile.c -o
> /home/abuild/rpmbuild/BUILD/qemu-20210111T151535.b3f846c59d/build/meson-pri
> vate/tmpg908fqs3/output.exe -pipe -O2 -Wall -D_FORTIFY_SOURCE=2
> -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables
> -fstack-clash-protection -Werror=return-type -g -D_FILE_OFFSET_BITS=64 -O0
> -std=gnu99 [  223s]
> [  223s] Code:
> [  223s]
> [  223s]   #include <stddef.h>
> [  223s]   #include <sys/types.h>
> [  223s]   #ifdef CONFIG_LIBATTR
> [  223s]   #include <attr/xattr.h>
> [  223s]   #else
> [  223s]   #include <sys/xattr.h>
> [  223s]   #endif
> [  223s]   int main(void) { getxattr(NULL, NULL, NULL, 0); setxattr(NULL,
> NULL, NULL, 0, 0); return 0; } [  223s] Compiler stdout:
> [  223s]
> [  223s] Compiler stderr:
> [  223s]  In file included from /usr/include/sys/types.h:25,
> [  223s]                  from
> /home/abuild/rpmbuild/BUILD/qemu-20210111T151535.b3f846c59d/build/meson-pri
> vate/tmpg908fqs3/testfile.c:3: [  223s] /usr/include/features.h:397:4:
> warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O)
> [-Wcpp] [  223s]   397 | #  warning _FORTIFY_SOURCE requires compiling with
> optimization (-O) [  223s]       |    ^~~~~~~
> [  223s]
> [  223s] Dependency libseccomp skipped: feature seccomp disabled
> ....