From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 02/10] udmabuf: improve map_udmabuf error handling Date: Tue, 11 Sep 2018 12:37:48 +0300 Message-ID: <2321736.6fDm34KxGD@avalon> References: <20180911065921.23818-1-kraxel@redhat.com> <20180911065921.23818-3-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99C536E324 for ; Tue, 11 Sep 2018 09:37:37 +0000 (UTC) In-Reply-To: <20180911065921.23818-3-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list , dri-devel@lists.freedesktop.org, "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org SGkgR2VyZCwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlc2RheSwgMTEgU2VwdGVt YmVyIDIwMTggMDk6NTk6MTMgRUVTVCBHZXJkIEhvZmZtYW5uIHdyb3RlOgoKQSBjb21taXQgbWVz c2FnZSB3b3VsZCBiZSBuaWNlLCBmb3IgYWxsIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMuCgo+IFJl cG9ydGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2Fy ZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJlZGhhdC5jb20+ CgpSZXZpZXdlZC1ieTogUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGlu Y2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZG1hLWJ1Zi91ZG1hYnVm LmMgfCAyMSArKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1i dWYvdWRtYWJ1Zi5jIGIvZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYwo+IGluZGV4IGU2M2QzMDFi Y2IuLjE5YmQ5MTgyMDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL3VkbWFidWYuYwo+ ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi91ZG1hYnVmLmMKPiBAQCAtNTEsMjUgKzUxLDI0IEBAIHN0 YXRpYyBzdHJ1Y3Qgc2dfdGFibGUgKm1hcF91ZG1hYnVmKHN0cnVjdAo+IGRtYV9idWZfYXR0YWNo bWVudCAqYXQsIHsKPiAgCXN0cnVjdCB1ZG1hYnVmICp1YnVmID0gYXQtPmRtYWJ1Zi0+cHJpdjsK PiAgCXN0cnVjdCBzZ190YWJsZSAqc2c7Cj4gKwlpbnQgcmV0Owo+IAo+ICAJc2cgPSBremFsbG9j KHNpemVvZigqc2cpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghc2cpCj4gLQkJZ290byBlcnIxOwo+ IC0JaWYgKHNnX2FsbG9jX3RhYmxlX2Zyb21fcGFnZXMoc2csIHVidWYtPnBhZ2VzLCB1YnVmLT5w YWdlY291bnQsCj4gLQkJCQkgICAgICAwLCB1YnVmLT5wYWdlY291bnQgPDwgUEFHRV9TSElGVCwK PiAtCQkJCSAgICAgIEdGUF9LRVJORUwpIDwgMCkKPiAtCQlnb3RvIGVycjI7Cj4gKwkJcmV0dXJu IEVSUl9QVFIoLUVOT01FTSk7Cj4gKwlyZXQgPSBzZ19hbGxvY190YWJsZV9mcm9tX3BhZ2VzKHNn LCB1YnVmLT5wYWdlcywgdWJ1Zi0+cGFnZWNvdW50LAo+ICsJCQkJCTAsIHVidWYtPnBhZ2Vjb3Vu dCA8PCBQQUdFX1NISUZULAo+ICsJCQkJCUdGUF9LRVJORUwpOwo+ICsJaWYgKHJldCA8IDApCj4g KwkJZ290byBlcnI7Cj4gIAlpZiAoIWRtYV9tYXBfc2coYXQtPmRldiwgc2ctPnNnbCwgc2ctPm5l bnRzLCBkaXJlY3Rpb24pKQo+IC0JCWdvdG8gZXJyMzsKPiAtCj4gKwkJZ290byBlcnI7Cj4gIAly ZXR1cm4gc2c7Cj4gCj4gLWVycjM6Cj4gK2VycjoKPiAgCXNnX2ZyZWVfdGFibGUoc2cpOwo+IC1l cnIyOgo+ICAJa2ZyZWUoc2cpOwo+IC1lcnIxOgo+IC0JcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7 Cj4gKwlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ICB9Cj4gCj4gIHN0YXRpYyB2b2lkIHVubWFwX3Vk bWFidWYoc3RydWN0IGRtYV9idWZfYXR0YWNobWVudCAqYXQsCgotLSAKUmVnYXJkcywKCkxhdXJl bnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:34166 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbeIKOgG (ORCPT ); Tue, 11 Sep 2018 10:36:06 -0400 From: Laurent Pinchart To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, Sumit Semwal , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list Subject: Re: [PATCH 02/10] udmabuf: improve map_udmabuf error handling Date: Tue, 11 Sep 2018 12:37:48 +0300 Message-ID: <2321736.6fDm34KxGD@avalon> In-Reply-To: <20180911065921.23818-3-kraxel@redhat.com> References: <20180911065921.23818-1-kraxel@redhat.com> <20180911065921.23818-3-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Gerd, Thank you for the patch. On Tuesday, 11 September 2018 09:59:13 EEST Gerd Hoffmann wrote: A commit message would be nice, for all patches in this series. > Reported-by: Laurent Pinchart > Signed-off-by: Gerd Hoffmann Reviewed-by: Reviewed-by: Laurent Pinchart > --- > drivers/dma-buf/udmabuf.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index e63d301bcb..19bd918209 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -51,25 +51,24 @@ static struct sg_table *map_udmabuf(struct > dma_buf_attachment *at, { > struct udmabuf *ubuf = at->dmabuf->priv; > struct sg_table *sg; > + int ret; > > sg = kzalloc(sizeof(*sg), GFP_KERNEL); > if (!sg) > - goto err1; > - if (sg_alloc_table_from_pages(sg, ubuf->pages, ubuf->pagecount, > - 0, ubuf->pagecount << PAGE_SHIFT, > - GFP_KERNEL) < 0) > - goto err2; > + return ERR_PTR(-ENOMEM); > + ret = sg_alloc_table_from_pages(sg, ubuf->pages, ubuf->pagecount, > + 0, ubuf->pagecount << PAGE_SHIFT, > + GFP_KERNEL); > + if (ret < 0) > + goto err; > if (!dma_map_sg(at->dev, sg->sgl, sg->nents, direction)) > - goto err3; > - > + goto err; > return sg; > > -err3: > +err: > sg_free_table(sg); > -err2: > kfree(sg); > -err1: > - return ERR_PTR(-ENOMEM); > + return ERR_PTR(ret); > } > > static void unmap_udmabuf(struct dma_buf_attachment *at, -- Regards, Laurent Pinchart