From: David Howells <dhowells@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] KEYS: Propagate error code instead of returning -EINVAL
Date: Fri, 04 Jun 2010 10:08:06 +0000 [thread overview]
Message-ID: <23225.1275646086@redhat.com> (raw)
In-Reply-To: <20100603190911.GX5483@bicker>
Dan Carpenter <error27@gmail.com> wrote:
> This is from a Smatch check I'm writing.
>
> strncpy_from_user() returns -EFAULT on error so the first change just
> silences a warning but doesn't change how the code works.
>
> The other change is a bug fix because install_thread_keyring_to_cred()
> can return a variety of errors such as -EINVAL, -EEXIST, -ENOMEM or
> -EKEYREVOKED.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2010-06-04 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 19:09 [patch] KEYS: Propagate error code instead of returning -EINVAL Dan Carpenter
2010-06-04 10:08 ` David Howells [this message]
2010-06-06 23:23 ` [patch] KEYS: Propagate error code instead of returning James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23225.1275646086@redhat.com \
--to=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.