From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v12 0/18] Add Analogix Core Display Port Driver Date: Wed, 13 Jan 2016 15:59:51 +0100 Message-ID: <2322926.s1viZ6tSS3@phil> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Rob Herring , Andy Yan , Thierry Reding , Gustavo Padovan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgWWFraXIsCgpBbSBNaXR0d29jaCwgMjMuIERlemVtYmVyIDIwMTUsIDIwOjI1OjM4IHNjaHJp ZWIgWWFraXIgWWFuZzoKPiAgICBUaGUgU2Ftc3VuZyBFeHlub3MgZURQIGNvbnRyb2xsZXIgYW5k IFJvY2tjaGlwIFJLMzI4OCBlRFAgY29udHJvbGxlcgo+IHNoYXJlIHRoZSBzYW1lIElQLCBzbyBh IGxvdCBvZiBwYXJ0cyBjYW4gYmUgcmUtdXNlZC4gSSBzcGxpdCB0aGUgY29tbW9uCj4gY29kZSBp bnRvIGJyaWRnZSBkaXJlY3RvcnksIHRoZW4gcmszMjg4IGFuZCBleHlub3Mgb25seSBuZWVkIHRv IGtlZXAKPiBzb21lIHBsYXRmb3JtIGNvZGUuIENhdXNlIEkgY2FuJ3QgZmluZCB0aGUgZXhhY3Qg SVAgbmFtZSBvZiBleHlub3MgZHAKPiBjb250cm9sbGVyLCBzbyBJIGRlY2lkZSB0byBuYW1lIGRw IGNvcmUgZHJpdmVyIHdpdGggImFuYWxvZ2l4IiB3aGljaCBJCj4gZmluZCBpbiByazMyODggZURQ IFRSTQoKY291bGQgeW91IHJlYmFzZSB5b3VyIHBhdGNoZXMgb24gdG9wIG9mIERhdmUncyBkcm0t bmV4dCBicmFuY2ggWzBdIHBsZWFzZT8KVGhlIGV4eW5vcyBwYXJ0IGdvdCBzb21lIGNvbnN0IGF0 dHJpYnV0ZXMgZm9yIHRoZSAqX2Z1bmNfb3BzIHN0cnVjdHMgYW5kIApkcm1fZW5jb2Rlcl9pbml0 IGdvdCBhbiBhZGRpdGlvbmFsIHBhcmFtZXRlci4KSSdtIHN0aWxsIGhvcGluZyB0aGF0IHdlIGNh biBnZXQgdGhpcyBmaW5hbGx5IGNvbW1pdHRlZCBvbmNlIDQuNS1yYzEgaXMgCnJlbGVhc2VkIGlu IDEuNSB3ZWVrcyA6LSkgLgoKSSBkaWQgdHJ5IHRvIG1lcmdlIHRoaW5ncyB0b2dldGhlciBbMV0s IHRoZSBzeXN0ZW0gYXQgbGVhc3QgY29tZXMgdXAgYW5kIApkZXRlY3RzIHRoZSBwYW5lbCAoRURJ RCBpcyByZWFkIGNvcnJlY3RseSBhbmQgaXQgdHVybnMgdGhlIGJhY2tsaWdodCBvbikgYnV0IApJ IGRvbid0IHNlZSBhbnkgb3V0cHV0IG9uIHRoZSBkaXNwbGF5IC0gaGRtaSB3b3JrcyBmaW5lIHRo b3VnaCBhbmQgWDExIGlzIApjbGFpbWluZyBldmVyeXRoaW5nIHRvIGJlIGZpbmUgaW4gYm90aCBj YXNlcy4KClNvIEkgZG9uJ3Qga25vdyB5ZXQgaWYgSSBtYWRlIGEgbWlzdGFrZSB3aGVuIHB1dHRp bmcgdGhpcyB0b2dldGhlciBvciB0aGVyZSAKaXMgYW4gaXNzdWUgb24gdGhlIGRyaXZlci1zaWRl LgoKClRoYW5rcwpIZWlrbwoKClswXSBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvfmFpcmxp ZWQvbGludXgvbG9nLz9oPWRybS1uZXh0ClsxXSBodHRwczovL2dpdGh1Yi5jb20vbW1pbmQvbGlu dXgtcm9ja2NoaXAvdHJlZS90bXAvYW5hbG9naXhkcF92MTItdmV5cm9uCkkgbGVmdCBvdXQgcGF0 Y2gxNiwgcGVyIHlvdXIgdGFsayB3aXRoIEppbmdvbyBhbmQgbWUgbm90IHNlZWluZyBhbnkgQVVY IENIIAplcnJvcnMgd2l0aG91dCBpdC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 13 Jan 2016 15:59:51 +0100 Subject: [PATCH v12 0/18] Add Analogix Core Display Port Driver In-Reply-To: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> Message-ID: <2322926.s1viZ6tSS3@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Yakir, Am Mittwoch, 23. Dezember 2015, 20:25:38 schrieb Yakir Yang: > The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some platform code. Cause I can't find the exact IP name of exynos dp > controller, so I decide to name dp core driver with "analogix" which I > find in rk3288 eDP TRM could you rebase your patches on top of Dave's drm-next branch [0] please? The exynos part got some const attributes for the *_func_ops structs and drm_encoder_init got an additional parameter. I'm still hoping that we can get this finally committed once 4.5-rc1 is released in 1.5 weeks :-) . I did try to merge things together [1], the system at least comes up and detects the panel (EDID is read correctly and it turns the backlight on) but I don't see any output on the display - hdmi works fine though and X11 is claiming everything to be fine in both cases. So I don't know yet if I made a mistake when putting this together or there is an issue on the driver-side. Thanks Heiko [0] http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next [1] https://github.com/mmind/linux-rockchip/tree/tmp/analogixdp_v12-veyron I left out patch16, per your talk with Jingoo and me not seeing any AUX CH errors without it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbcAMPgQ (ORCPT ); Wed, 13 Jan 2016 10:36:16 -0500 Received: from gloria.sntech.de ([95.129.55.99]:41290 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcAMPgO (ORCPT ); Wed, 13 Jan 2016 10:36:14 -0500 From: Heiko Stuebner To: Yakir Yang Cc: Inki Dae , Mark Yao , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v12 0/18] Add Analogix Core Display Port Driver Date: Wed, 13 Jan 2016 15:59:51 +0100 Message-ID: <2322926.s1viZ6tSS3@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yakir, Am Mittwoch, 23. Dezember 2015, 20:25:38 schrieb Yakir Yang: > The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some platform code. Cause I can't find the exact IP name of exynos dp > controller, so I decide to name dp core driver with "analogix" which I > find in rk3288 eDP TRM could you rebase your patches on top of Dave's drm-next branch [0] please? The exynos part got some const attributes for the *_func_ops structs and drm_encoder_init got an additional parameter. I'm still hoping that we can get this finally committed once 4.5-rc1 is released in 1.5 weeks :-) . I did try to merge things together [1], the system at least comes up and detects the panel (EDID is read correctly and it turns the backlight on) but I don't see any output on the display - hdmi works fine though and X11 is claiming everything to be fine in both cases. So I don't know yet if I made a mistake when putting this together or there is an issue on the driver-side. Thanks Heiko [0] http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next [1] https://github.com/mmind/linux-rockchip/tree/tmp/analogixdp_v12-veyron I left out patch16, per your talk with Jingoo and me not seeing any AUX CH errors without it.