All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel González Cabanelas" <dgcbueu@gmail.com>
To: davem@davemloft.net
Cc: kuba@kernel.org, f.fainelli@gmail.com,
	gregkh@linuxfoundation.org, netdev@vger.kernel.org,
	noltari@gmail.com
Subject: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment
Date: Wed, 24 Feb 2021 16:44:18 +0100	[thread overview]
Message-ID: <2323124.5UR7tLNZLG@tool> (raw)

The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a
result of this it works in polling mode.

Fix it using the phy_device structure to assign the platform IRQ.

Tested under a BCM6348 board. Kernel dmesg before the patch:
   Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
              BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=POLL)

After the patch:
   Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
              BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=17)

Pluging and uplugging the ethernet cable now generates interrupts and the
PHY goes up and down as expected.

Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
changes in V2: 
  - snippet moved after the mdiobus registration
  - added missing brackets

 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index fd876721316..dd218722560 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1818,10 +1818,19 @@ static int bcm_enet_probe(struct platform_device *pdev)
 		 * if a slave is not present on hw */
 		bus->phy_mask = ~(1 << priv->phy_id);
 
-		if (priv->has_phy_interrupt)
+		ret = mdiobus_register(bus);
+
+		if (priv->has_phy_interrupt) {
+			phydev = mdiobus_get_phy(bus, priv->phy_id);
+			if (!phydev) {
+				dev_err(&dev->dev, "no PHY found\n");
+				goto out_unregister_mdio;
+			}
+
 			bus->irq[priv->phy_id] = priv->phy_interrupt;
+			phydev->irq = priv->phy_interrupt;
+		}
 
-		ret = mdiobus_register(bus);
 		if (ret) {
 			dev_err(&pdev->dev, "unable to register mdio bus\n");
 			goto out_free_mdio;
-- 
2.30.1





             reply	other threads:[~2021-02-24 16:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 15:44 Daniel González Cabanelas [this message]
2021-02-24 21:44 ` [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment Heiner Kallweit
2021-02-24 22:01   ` Florian Fainelli
2021-02-24 23:54     ` Daniel González Cabanelas
2021-02-25  7:22       ` Heiner Kallweit
2021-02-25 16:36         ` Daniel González Cabanelas
2021-02-25 20:05           ` Heiner Kallweit
2021-02-25 22:28             ` Daniel González Cabanelas
2021-02-25 22:56               ` Heiner Kallweit
2021-02-26  4:12                 ` Florian Fainelli
2021-02-26  7:13               ` Heiner Kallweit
2021-02-26  9:10                 ` Daniel González Cabanelas
2021-02-26  9:32                   ` Heiner Kallweit
2021-02-26  9:38                     ` Heiner Kallweit
2021-02-26  9:49                     ` Daniel González Cabanelas
2021-02-26 10:08                       ` Heiner Kallweit
2021-02-26 10:19                         ` Daniel González Cabanelas
2021-02-26 14:16                           ` Andrew Lunn
2021-02-26 14:28                             ` Heiner Kallweit
2021-02-26 16:14                               ` Daniel González Cabanelas
2021-02-26 16:55                                 ` Florian Fainelli
2021-02-25 13:53 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2323124.5UR7tLNZLG@tool \
    --to=dgcbueu@gmail.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noltari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.