From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jason Wang <jasowang@redhat.com>
Cc: dev@dpdk.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com,
mst@redhat.com
Subject: Re: [PATCH 1/2] net/virtio: support modern device id
Date: Fri, 02 Sep 2016 14:57:30 +0200 [thread overview]
Message-ID: <2323448.KHrCRZ2JeF@xps13> (raw)
In-Reply-To: <1472798220-7121-1-git-send-email-jasowang@redhat.com>
2016-09-02 14:36, Jason Wang:
> Spec said "The PCI Device ID is calculated by adding 0x1040 to the
> Virtio Device ID". So this patch makes pmd can recognize modern virtio
> net id.
Please could you describe what is a modern virtio-net?
> #define VIRTIO_PCI_DEVICEID_MIN 0x1000
> #define VIRTIO_PCI_DEVICEID_MAX 0x103F
> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041
It doesn't match the sentence above: 1000 + 1040 = 2040
By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code.
next prev parent reply other threads:[~2016-09-02 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 6:36 [PATCH 1/2] net/virtio: support modern device id Jason Wang
2016-09-02 6:37 ` [PATCH 2/2] virtio: support IOMMU platform Jason Wang
2016-09-02 13:04 ` Thomas Monjalon
2016-09-02 17:26 ` Michael S. Tsirkin
2016-09-04 8:08 ` Alejandro Lucero
2016-09-05 6:31 ` Jason Wang
2016-09-05 5:15 ` Jason Wang
2016-09-05 6:25 ` Jason Wang
[not found] ` <20160905071626.GM30752@yliu-dev.sh.intel.com>
2016-09-06 7:46 ` Yuanhan Liu
2016-09-07 4:53 ` Jason Wang
2016-09-02 12:57 ` Thomas Monjalon [this message]
2016-09-05 6:36 ` [PATCH 1/2] net/virtio: support modern device id Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2323448.KHrCRZ2JeF@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.