Re: rcar-du DRM driver failed to build

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Shawn,

On Friday, 18 May 2018 04:21:48 EEST Shawn Lin wrote:
> Hi,
> 
> linux-next-20180517 fail to build for arm64 defconfig due to this
> drivers.

This is a known issue due to two bugs, fixed by commits 315852b42297 ("drm: 
rcar-du: Fix build failure") and dd856d924b24 ("drm: rcar-du: Fix 
rcar_du_of_init() stub") in the DRM tree. They should both make it to the next 
linux-next.

The first bug was caused by the merge of two patch series in the DRM tree that 
conflicted at build time but not at merge time, and went unnoticed on my side 
due to a git tree move I wasn't aware of and on Dave's side due to a mistake 
in his arm64 build environment.

The second bug I should have caught before sending the pull request if I had 
tested building the driver as =m instead of =y. I'm sorry for that mistake.

>    CC [M]  drivers/gpu/drm/rcar-du/rcar_du_drv.o
>    CC [M]  drivers/gpu/drm/rcar-du/rcar_du_vsp.o
>    CC [M]  drivers/gpu/drm/rcar-du/rcar_du_of.o
> drivers/gpu/drm/rcar-du/rcar_du_of.c:320:13: error: redefinition of
> ‘rcar_du_of_init’
>   void __init rcar_du_of_init(const struct of_device_id *of_ids)
>               ^~~~~~~~~~~~~~~
> In file included from drivers/gpu/drm/rcar-du/rcar_du_of.c:21:0:
> drivers/gpu/drm/rcar-du/rcar_du_of.h:17:20: note: previous definition of
> ‘rcar_du_of_init’ was here
>   static inline void rcar_du_of_init(const struct of_device_id *of_ids) { }
>                      ^~~~~~~~~~~~~~~
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c: In function
> ‘rcar_du_vsp_plane_atomic_duplicate_state’:
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c:325:6: error: ‘struct
> rcar_du_vsp_plane_state’ has no member named ‘alpha’
>    copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
>        ^~
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c:325:53: error: ‘struct
> rcar_du_vsp_plane_state’ has no member named ‘alpha’
>    copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
>                                                       ^~
> make[4]: *** [drivers/gpu/drm/rcar-du/rcar_du_of.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[4]: *** [drivers/gpu/drm/rcar-du/rcar_du_vsp.o] Error 1
> make[3]: *** [drivers/gpu/drm/rcar-du] Error 2

-- 
Regards,

Laurent Pinchart