From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Fri, 07 Aug 2015 14:30:08 +0000 Subject: Re: [PATCH] drm: rcar-du: Fix plane state free in plane reset handler Message-Id: <2325494.jkNV16dCnQ@avalon> List-Id: References: <1438820580-14301-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20150807125321.GE25792@ulmo> In-Reply-To: <20150807125321.GE25792@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org Hi Thierry, On Friday 07 August 2015 14:53:22 Thierry Reding wrote: > On Thu, Aug 06, 2015 at 03:23:00AM +0300, Laurent Pinchart wrote: > > The plane reset handler frees the plane state and allocates a new > > default state, but when doing so attempt to free the plane state using > > the base plane state pointer instead of casting it to the > > driver-specific state object that has been allocated. Fix it by using > > the rcar_du_plane_atomic_destroy_state() function to destroy the plane > > state instead of duplicating the code. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 45 ++++++++++++++-------------- > > 1 file changed, 22 insertions(+), 23 deletions(-) > > > > Should the DRM core free the atomic state before calling the reset > > operation ? That would simplify drivers. > > The core can't do that because drivers might have subclassed the state. But the core can call the .atomic_destroy_state() operation, can't it ? > Reviewed-by: Thierry Reding -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Fix plane state free in plane reset handler Date: Fri, 07 Aug 2015 17:30:08 +0300 Message-ID: <2325494.jkNV16dCnQ@avalon> References: <1438820580-14301-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20150807125321.GE25792@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20150807125321.GE25792@ulmo> Sender: linux-sh-owner@vger.kernel.org To: Thierry Reding Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Thierry, On Friday 07 August 2015 14:53:22 Thierry Reding wrote: > On Thu, Aug 06, 2015 at 03:23:00AM +0300, Laurent Pinchart wrote: > > The plane reset handler frees the plane state and allocates a new > > default state, but when doing so attempt to free the plane state using > > the base plane state pointer instead of casting it to the > > driver-specific state object that has been allocated. Fix it by using > > the rcar_du_plane_atomic_destroy_state() function to destroy the plane > > state instead of duplicating the code. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 45 ++++++++++++++-------------- > > 1 file changed, 22 insertions(+), 23 deletions(-) > > > > Should the DRM core free the atomic state before calling the reset > > operation ? That would simplify drivers. > > The core can't do that because drivers might have subclassed the state. But the core can call the .atomic_destroy_state() operation, can't it ? > Reviewed-by: Thierry Reding -- Regards, Laurent Pinchart