From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "David Marchand" <david.marchand@redhat.com>,
stable@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
"Narcisa Ana Maria Vasile" <navasile@linux.microsoft.com>,
"Dmitry Malloy" <dmitrym@microsoft.com>,
"Pallavi Kadam" <pallavi.kadam@intel.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v2] eal/unix: allow creating thread with real-time priority
Date: Wed, 25 Oct 2023 18:46:29 +0200 [thread overview]
Message-ID: <23265462.6Emhk5qWAg@thomas> (raw)
In-Reply-To: <20231025083700.4e3e274c@hermes.local>
25/10/2023 17:37, Stephen Hemminger:
> On Wed, 25 Oct 2023 17:13:14 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL:
> > + /*
> > + * WARNING: Real-time busy loop takes priority on kernel threads,
> > + * making the system unstable.
> > + * There is also a known issue when using rte_ring.
> > + */
>
> I was thinking something like:
>
> static bool warned;
> if (!warned) {
> RTE_LOG(NOTICE, EAL, "Real time priority is unstable when thread is polling without sleep\n");
> warned = true;
> }
I'm not sure about bothering users.
They can fear something is wrong even if the developer took care of it.
I think doc warnings for developers are more appropriate.
I've added notes in the API.
next prev parent reply other threads:[~2023-10-25 16:46 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 12:54 [PATCH] eal/unix: allow creating thread with real-time priority Thomas Monjalon
2023-10-24 13:55 ` Morten Brørup
2023-10-24 16:04 ` Stephen Hemminger
2023-10-25 13:15 ` Thomas Monjalon
2023-10-25 13:34 ` Bruce Richardson
2023-10-25 13:44 ` Thomas Monjalon
2023-10-25 15:08 ` Stephen Hemminger
2023-10-25 15:14 ` Bruce Richardson
2023-10-25 15:18 ` Thomas Monjalon
2023-10-25 15:32 ` Thomas Monjalon
2023-10-25 15:13 ` [PATCH v2] " Thomas Monjalon
2023-10-25 15:37 ` Stephen Hemminger
2023-10-25 16:46 ` Thomas Monjalon [this message]
2023-10-25 17:54 ` Morten Brørup
2023-10-25 21:33 ` Stephen Hemminger
2023-10-26 7:33 ` Morten Brørup
2023-10-26 16:32 ` Stephen Hemminger
2023-10-26 17:07 ` Morten Brørup
2023-10-26 0:00 ` Stephen Hemminger
2023-10-25 16:31 ` [PATCH v3 0/2] " Thomas Monjalon
2023-10-25 16:31 ` [PATCH v3 1/2] eal: add thread yield functions Thomas Monjalon
2023-10-25 16:40 ` Bruce Richardson
2023-10-25 17:06 ` Thomas Monjalon
2023-10-25 18:07 ` Morten Brørup
2023-10-25 16:31 ` [PATCH v3 2/2] eal/unix: allow creating thread with real-time priority Thomas Monjalon
2023-10-26 13:36 ` [PATCH v3 0/2] " Thomas Monjalon
2023-10-26 13:44 ` Morten Brørup
2023-10-26 13:57 ` Morten Brørup
2023-10-26 14:04 ` Thomas Monjalon
2023-10-26 14:08 ` Morten Brørup
2023-10-26 14:30 ` Thomas Monjalon
2023-10-26 14:50 ` Morten Brørup
2023-10-26 14:59 ` Morten Brørup
2023-10-26 15:54 ` Bruce Richardson
2023-10-26 16:07 ` Thomas Monjalon
2023-10-26 16:50 ` Morten Brørup
2023-10-26 19:51 ` Thomas Monjalon
2023-10-27 7:19 ` Morten Brørup
2023-10-26 16:28 ` Stephen Hemminger
2023-10-26 19:55 ` Thomas Monjalon
2023-10-26 21:10 ` Stephen Hemminger
2023-10-26 14:10 ` David Marchand
2023-10-26 13:37 ` [PATCH v4 " Thomas Monjalon
2023-10-26 13:37 ` [PATCH v4 1/2] eal: add thread yield functions Thomas Monjalon
2023-10-26 13:37 ` [PATCH v4 2/2] eal/unix: allow creating thread with real-time priority Thomas Monjalon
2023-10-26 14:19 ` [PATCH v5 0/2] " Thomas Monjalon
2023-10-26 14:19 ` [PATCH v5 1/2] eal: add thread yield functions Thomas Monjalon
2023-10-26 14:19 ` [PATCH v5 2/2] eal/unix: allow creating thread with real-time priority Thomas Monjalon
2023-10-26 20:00 ` [PATCH v5 0/2] " Thomas Monjalon
2023-10-26 23:35 ` Tyler Retzlaff
2023-10-27 8:08 ` [PATCH v6 1/1] eal/unix: " Thomas Monjalon
2023-10-27 8:45 ` Morten Brørup
2023-10-27 9:11 ` Thomas Monjalon
2023-10-27 18:15 ` Stephen Hemminger
2024-10-07 19:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23265462.6Emhk5qWAg@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.