From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: tcpdump - parse TVLV containers
Date: Thu, 26 Jun 2014 14:50:31 +0800 [thread overview]
Message-ID: <2328265.CU9CXaCXv8@diderot> (raw)
In-Reply-To: <53ABBBE8.8070202@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Thursday 26 June 2014 08:21:28 Antonio Quartulli wrote:
> On 26/06/14 07:59, Marek Lindner wrote:
> > On Thursday 26 June 2014 02:24:00 Antonio Quartulli wrote:
> >> Moreover, the parts of code that have been touched by this
> >> patch have also been re-arranged a bit from the style point
> >> of view.
> >
> > Can you please split the new features from the style changes ?
>
> Oky, I can, but most of the style changes are done on lines that I am
> already changing (in the worst case they are happening at the line above
> or below - like for the introduction of the BIT macros).
>
> Shall I keep those ? Or I should just make no style change in the patch?
No mix of style patches and feature patches please.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-06-26 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 0:24 [B.A.T.M.A.N.] [PATCH] batctl: tcpdump - parse TVLV containers Antonio Quartulli
2014-06-26 5:59 ` Marek Lindner
2014-06-26 6:21 ` Antonio Quartulli
2014-06-26 6:50 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2328265.CU9CXaCXv8@diderot \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.