From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/5] mem: add --single-file to create single mem-backed file Date: Tue, 08 Mar 2016 11:30:33 +0100 Message-ID: <2329500.UVQ1bbgajc@xps13> References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <56DE921A.4060203@redhat.com> <20160308090445.GN14300@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: nakajima.yoshihiro@lab.ntt.co.jp, mst@redhat.com, p.fedin@samsung.com, ann.zhuangyanying@huawei.com To: dev@dpdk.org Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 580CE2965 for ; Tue, 8 Mar 2016 11:32:11 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n186so124642652wmn.1 for ; Tue, 08 Mar 2016 02:32:11 -0800 (PST) In-Reply-To: <20160308090445.GN14300@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-08 17:04, Yuanhan Liu: > On Tue, Mar 08, 2016 at 10:49:30AM +0200, Panu Matilainen wrote: > > On 03/07/2016 03:13 PM, Yuanhan Liu wrote: > > >To me, maybe you could base the SINGLE_FILE_SEGMENTS option, and add > > >another option, say --no-sort (I confess this name sucks, but you get > > >my point). With that, we could make sure to create as least huge page > > >files as possible, to fit your case. > > > > Note that SINGLE_FILE_SEGMENTS is a nasty hack that only the IVSHMEM config > > uses, getting rid of it (by replacing with a runtime switch) would be great. > > Can't agree more. +1 > BTW, FYI, Jianfeng and I had a private talk, and we came to agree that > it might be better to handle it outside the normal huge page init stage, > just like this patch does, but adding the support of multiple huge page > sizes. Let's not add more messy code there. > > --yliu > > > OTOH IVSHMEM itself seems to have fallen out of the fashion since the memnic > > driver is unmaintained and broken since dpdk 2.0... CC'ing the IVSHMEM > > maintainer in case he has thoughts on this. The ivshmem config was not used for memnic which was using ivshmem only for data path. CONFIG_RTE_LIBRTE_IVSHMEM and CONFIG_RTE_EAL_SINGLE_FILE_SEGMENTS are more about full memory sharing. I have the feeling it could be dropped. It there are some users, I'd like to see a justification and a rework to remove these build options.