From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EE7DC4828D for ; Tue, 6 Feb 2024 11:17:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.676807.1053089 (Exim 4.92) (envelope-from ) id 1rXJSJ-00032O-Bf; Tue, 06 Feb 2024 11:17:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 676807.1053089; Tue, 06 Feb 2024 11:17:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rXJSJ-00032H-8G; Tue, 06 Feb 2024 11:17:35 +0000 Received: by outflank-mailman (input) for mailman id 676807; Tue, 06 Feb 2024 11:17:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rXJSH-00032B-H0 for xen-devel@lists.xenproject.org; Tue, 06 Feb 2024 11:17:33 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51c23eee-c4e1-11ee-98f5-efadbce2ee36; Tue, 06 Feb 2024 12:17:31 +0100 (CET) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40ff2838851so490985e9.1 for ; Tue, 06 Feb 2024 03:17:31 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id l6-20020a5d5266000000b0033b04f7585dsm1858668wrc.3.2024.02.06.03.17.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 03:17:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51c23eee-c4e1-11ee-98f5-efadbce2ee36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707218251; x=1707823051; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jTlDZCF5STgE7bqWsxYU6ACHRM/5epAF+J6uP5ItGAM=; b=VWV5xwnVT0AUGlqINTDnBXoETeRORyV3w03tJAchIao3yGlawrOfs0XZ2KkwKtuUKd I+omcQy27tU/880700M/6sb2jZFQGP3iZHTKyqLXutNmW5bGmjL0xmsbpCIDQVVb2U/Y 6Z9R70kkefYo+a7BGC0KX5pql1F9AFYQFZfuUxRQ01swHM1mvzjzHvUbRs8ksiLe7NKR 3SWwSH0o9WibIsU98TFrPKxkha+PovuM6FHg/CbpRTncr9cNKzcqFt55k/Da/jHMuLTn dVetLaM826oC2AIBfq1w25orRysO6wNNB7TRxaLQKoMcrJ8Z27keQJ7v/qsoS71a5VZq keng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707218251; x=1707823051; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jTlDZCF5STgE7bqWsxYU6ACHRM/5epAF+J6uP5ItGAM=; b=gWzf27G2S6W/es8wSXuIiH/L/ChOj87a915dDsTYfz7dCnAOn/L+HrJcAIVesT1tfC +w5cmsSlDV9KBGxnuqeByToZjbmMkVUhKyUDCMtxAPijrI+XCTm/cs/kpnseulT7pXx6 3l/dloAAYAj7p/0zkecTwyCc0aAq1RdhNPFlxpapKu7Je9PQ+UCO7KUflka78LuWhV1Y jwsI7uY2S3G8PZ+j6rohZvm1xnOlpSkM5xSd+/liqayX4fLClGmqp/GcW7mgA/OV9kfe lXLiOWgRtflQ5nbNwTl3MSEKwueGBYAnWRlH6Ot8An0Nzf1BU7/PALfVQzT0IRvb7Ykz Nc5A== X-Gm-Message-State: AOJu0YwXkI10b8qz2CtlDpr54d7/1fogHmQLql4Eubno6CtWYEiULhio X5ofCjPqAfhe5Pnmm3MwmLfIrSmN5g6msnbxJLwNfNPA3+nHC9Z6rM23QAEVyQ== X-Google-Smtp-Source: AGHT+IEOcEzkFCGNqeeONaQK3q2Lc4xS5yI1gSmBmhUmfaoBhl1Vg7v1CVt46dKiGzIJ3dEvyOd0aA== X-Received: by 2002:a05:600c:3147:b0:40f:af68:3ab with SMTP id h7-20020a05600c314700b0040faf6803abmr1425313wmo.5.1707218250866; Tue, 06 Feb 2024 03:17:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVbob1Gbdym7yT8cB9HR0nks/P8VgAsH0cGnGgwaw/E5DU6q+s173LJANGedFTZufirTGHck5bozyayq9R/aJUY6lQZzdKCdCcM4hpEPeaAN0cQ1iWildsN9Xluw0Hquoxq2MXGxgatqg== Message-ID: <232baaae-5fe0-4a94-8469-d1dac520c1af@suse.com> Date: Tue, 6 Feb 2024 12:17:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] iommu/x86: introduce a generic IVMD/RMRR range validity helper Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20240201170159.66330-1-roger.pau@citrix.com> <20240201170159.66330-3-roger.pau@citrix.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240201170159.66330-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01.02.2024 18:01, Roger Pau Monne wrote: > IVMD and RMRR ranges are functionally equivalent, and as so could use the same > validity checker. May I suggest s/equivalent/similar/? > Move the IVMD to x86 common IOMMU code and adjust the function to take a pair > of [start, end) mfn parameters. [start,end) ranges generally come with the problem of not allowing to represent the full address space. While that isn't specifically a problem here, seeing that both VT-d and V-i present inclusive ranges, how about making the common function match that? Jan