From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set Date: Mon, 23 Apr 2018 13:10:31 +0300 Message-ID: <2334482.mQhE6fZxKp@avalon> References: <20180125155504.8611-1-philippe.cornu@st.com> <7ec671c2-a777-5dcd-dcc9-e026fff89900@st.com> <1802436.kt7XbhHcH5@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1802436.kt7XbhHcH5@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: "linux-arm-kernel@lists.infradead.org" , Alexandre TORGUE , David Airlie , "daniel.vetter@ffwll.ch" , Brian Norris , Philippe CORNU , "linux-kernel@vger.kernel.org" , Yannick FERTRE , "linux-rockchip@lists.infradead.org" , Ludovic BARRE , Maxime Coquelin , Mickael REULIER , Vincent ABRIOU , Bhumika Goyal List-Id: linux-rockchip.vger.kernel.org SGkgUGhpbGlwcGUsCgpPbiBUaHVyc2RheSwgOCBGZWJydWFyeSAyMDE4IDE1OjE1OjQwIEVFU1Qg TGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiBPbiBTYXR1cmRheSwgMyBGZWJydWFyeSAyMDE4IDAw OjQxOjI2IEVFVCBQaGlsaXBwZSBDT1JOVSB3cm90ZToKPiA+IE9uIDAxLzI5LzIwMTggMTE6NDAg QU0sIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiA+IE9uIE1vbmRheSwgMjkgSmFudWFyeSAy MDE4IDEyOjE3OjM3IEVFVCBQaGlsaXBwZSBDT1JOVSB3cm90ZToKPiA+ID4+IE9uIDAxLzI5LzIw MTggMTA6NDYgQU0sIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiA+Pj4gT24gVGh1cnNkYXks IDI1IEphbnVhcnkgMjAxOCAxNzo1NTowNCBFRVQgUGhpbGlwcGUgQ29ybnUgd3JvdGU6Cj4gPiA+ Pj4+IFRoZSAiYWRqdXN0ZWRfbW9kZSIgY2xvY2sgdmFsdWUgKGllIHRoZSByZWFsIHBpeGVsIGNs b2NrKSBpcyBtb3JlCj4gPiA+Pj4+IGFjY3VyYXRlIHRoYW4gIm1vZGUiIGNsb2NrIHZhbHVlIChp ZSB0aGUgcGFuZWwvYnJpZGdlIHJlcXVlc3RlZAo+ID4gPj4+PiBjbG9jayB2YWx1ZSkuIEl0IG9m ZmVycyBhIGJldHRlciBwcmVjaXNlbmVzcyBmb3IgdGltaW5nCj4gPiA+Pj4+IGNvbXB1dGF0aW9u cyBhbmQgYWxsb3dzIHRvIHJlZHVjZSB0aGUgZXh0cmEgZHNpIGJhbmR3aWR0aCBpbgo+ID4gPj4+ PiBidXJzdCBtb2RlIChmcm9tIH4yMCUgdG8gfjEwLTEyJSwgaHcgcGxhdGZvcm0gZGVwZW5kYW50 KS4KPiA+ID4+Pj4gCj4gPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIENvcm51IDxwaGls aXBwZS5jb3JudUBzdC5jb20+Cj4gPiA+Pj4gCj4gPiA+Pj4gVGhlIGFkanVzdGVkIG1vZGUgaXMg ZG9jdW1lbnRlZCBhcwo+ID4gPj4+IAo+ID4gPj4+ICAgLyoqCj4gPiA+Pj4gICAKPiA+ID4+PiAg ICAqIEBhZGp1c3RlZF9tb2RlOgo+ID4gPj4+ICAgICoKPiA+ID4+PiAgICAqIEludGVybmFsIGRp c3BsYXkgdGltaW5ncyB3aGljaCBjYW4gYmUgdXNlZCBieSB0aGUgZHJpdmVyIHRvCj4gPiA+Pj4g ICAgaGFuZGxlCj4gPiA+Pj4gICAgKiBkaWZmZXJlbmNlcyBiZXR3ZWVuIHRoZSBtb2RlIHJlcXVl c3RlZCBieSB1c2Vyc3BhY2UgaW4gQG1vZGUgYW5kCj4gPiA+Pj4gICAgd2hhdAo+ID4gPj4+ICAg ICogaXMgYWN0dWFsbHkgcHJvZ3JhbW1lZCBpbnRvIHRoZSBoYXJkd2FyZS4gSXQgaXMgcHVyZWx5 IGRyaXZlcgo+ID4gPj4+ICAgICogaW1wbGVtZW50YXRpb24gZGVmaW5lZCB3aGF0IGV4YWN0bHkg dGhpcyBhZGp1c3RlZCBtb2RlIG1lYW5zLgo+ID4gPj4+ICAgIFVzdWFsbHkKPiA+ID4+PiAgICAq IGl0IGlzIHVzZWQgdG8gc3RvcmUgdGhlIGhhcmR3YXJlIGRpc3BsYXkgdGltaW5ncyB1c2VkIGJl dHdlZW4gdGhlCj4gPiA+Pj4gICAgKiBDUlRDIGFuZCBlbmNvZGVyIGJsb2Nrcy4KPiA+ID4+PiAg ICAqLwo+ID4gPj4+IAo+ID4gPj4+IFRoaXMgaXMgZWFzeSB0byBoYW5kbGUgd2hlbiB0aGUgQ1JU QyBhbmQgZW5jb2RlciBhcmUgY29udHJvbGxlZCBieSB0aGUKPiA+ID4+PiBzYW1lIGRyaXZlciwg YXMgdGhlIGZpZWxkIGlzICJpbXBsZW1lbnRhdGlvbiBkZWZpbmVkIiBieSBhIHNpbmdsZQo+ID4g Pj4+IGRyaXZlci4gSG93ZXZlciwgd2hlbiB1c2luZyBicmlkZ2VzLCB0aGVyZSBhcmUgdHdvIGRy aXZlcnMgaW52b2x2ZWQsCj4gPiA+Pj4gYW5kCj4gPiA+Pj4gdGhleSBtdXN0IGJvdGggYWdyZWUg dG8gbWVhbmluZ2Z1bGx5IHVzZSB0aGUgYWRqdXN0ZWQgbW9kZS4gSSBjYW4ndAo+ID4gPj4+IHNl ZQo+ID4gPj4+IGhvdyB0byBkbyBzbyB3aXRob3V0IHN0YW5kYXJkaXppbmcgdGhlIG1lYW5pbmcg b2YgdGhlIGFkanVzdGVkIG1vZGUKPiA+ID4+PiBmaWVsZC4KPiA+ID4+IAo+ID4gPj4gVGhpcyBp cyBleGFjdGx5IHRoZSByZWFzb24gd2h5IG15IGZpcnN0IGltcGxlbWVudGF0aW9uIHVzZWQgdGhl IGRzaQo+ID4gPj4gYnJpZGdlICJvcHRpb25hbCBwaXhlbCBjbG9jayIgaW5zdGVhZCBvZiB0aGUg YWRqdXN0ZWRfbW9kZSAoc2VlIFsxXSkKPiA+ID4+IAo+ID4gPj4gQnV0IGFmdGVyIGRpZ2dpbmcg bW9yZSBpbnRvIHRoZSBkcm0gc291cmNlIGNvZGUsIEkgdGhpbmsgdXNpbmcKPiA+ID4+IGFkanVz dGVkX21vZGUgaW5zdGVhZCBvZiB0aGUgcGl4ZWwgY2xvY2sgaGVyZSBicmluZ3MgbW9yZSBhZHZh bnRhZ2VzCj4gPiA+PiBiZWNhdXNlOgo+ID4gPj4gKiBhZGp1c3RlZF9tb2RlIGlzIGFuIGFyZ3Vt ZW50IG9mIGJyaWRnZSBtb2RlX3NldCgpIHByb2JhYmx5IGZvciBiZWluZwo+ID4gPj4gdXNlZCBp biBhbnkgbWFubmVyLCBtYXliZSBsaWtlIHRoaXMgOikKPiA+ID4+ICogaWYgdGhlIGJyaWRnZSAi dXNlciIgKGNydGMgb3IgYSBtYXN0ZXIgYnJpZGdlIGRyaXZlcnMpIGRvZXMgbm90IG5lZWQKPiA+ ID4+IHRvIG1vZGlmeSBpdHMgYWRqdXN0ZWRfbW9kZSB0aGVuIG1vZGUgJiBhZGp1c3RlZF9tb2Rl IG1vZGVfc2V0KCkKPiA+ID4+IGFyZ3VtZW50cyB3aWxsIGhhdmUgdGhlIHNhbWUgdmFsdWVzIHNv ICJubyBjb25zZXF1ZW5jZSIgZm9yIHRoZSBicmlkZ2UuCj4gPiA+PiAqIGlmIHRoZSBicmlkZ2Ug InVzZXIiIChjcnRjIG9yIG1hc3RlciBicmlkZ2UgZHJpdmVycykgbmVlZHMgdG8gYWRqdXN0Cj4g PiA+PiBhbnkgdmFsdWUgb2YgdGhlIG1vZGUgdGhlbiB0aGlzIGFkanVzdG1lbnQgaXMgYXZhaWxh YmxlIGZvciB0aGUgYnJpZGdlLgo+ID4gPiAKPiA+ID4gUmVtZW1iZXIgdGhhdCB0aGVyZSBjYW4g YmUgbXVsdGlwbGUgY2hhaW5lZCBicmlkZ2VzLCBhbmQgYSBzaW5nbGUKPiA+ID4gYWRqdXN0ZWQg bW9kZSBmaWVsZC4KPiA+ID4gCj4gPiA+PiAqIHJvY2tjaGlwIGNydGMgdXBkYXRlcyBhIHBhcnQg b2YgdGhlIG1vZGUgKHRoZSBjbG9jayksIHN0bSBpcyBkb2luZwo+ID4gPj4gdGhlCj4gPiA+PiBz YW1lIChzZWUgWzJdKSBidXQgYW55IGZ1dHVyZSAidXNlciIgb2YgdGhlIGR3X21pcGlfZHNpIGJy aWRnZSBjYW4KPiA+ID4+IGFkanVzdCBzb21ldGhpbmcgZWxzZSAoYmxhbmtpbmdzLi4uKSBhbmQg dGhlIGR3X21pcGlfZHNpIGJyaWRnZSB3aWxsIGJlCj4gPiA+PiB0aGVuIGF3YXJlIG9mLi4uCj4g PiA+PiAKPiA+ID4+IEJ1dCBtYXliZSBpdCBpcyBhIHdyb25nIHVzYWdlIG9mIHRoZSAiYWRqdXN0 ZWRfbW9kZSBvZmZlciIuLi4KPiA+ID4gCj4gPiA+IEkgZG9uJ3QgZGlzYWdyZWUgdGhhdCB0aGVy ZSdzIGEgbmVlZCBmb3IgdXNpbmcgYWRqdXN0ZWQgdmFsdWVzLCBidXQgSQo+ID4gPiBiZWxpZXZl IHdlIG5lZWQgdG8gY3JlYXRlIGEgY2xlYXIgQVBJIHRvIGRvIHNvLiBVc2luZyB0aGUgYWRqdXN0 X21vZGUKPiA+ID4gZmllbGQgYXMtaXMgd2hlbiBpdCdzIGNsZWFybHkgZG9jdW1lbnRlZCBhcyBi ZWluZyBpbXBsZW1lbnRhdGlvbi1kZWZpbmVkCj4gPiA+IGlzIGFza2luZyBmb3IgdHJvdWJsZS4K PiA+IAo+ID4gTGF1cmVudCwgZG8geW91IHRoaW5rIHdlIGNhbiB1c2UgImFkanVzdGVkIG1vZGUi IGhlcmUgaW4gdGhpcyBzbWFsbAo+ID4gcGF0Y2ggYXMgdGhlIGFjdHVhbCAyICJ1c2VycyIgb2Yg dGhpcyBicmlkZ2UgKHJvY2tjaGlwICYgc3RtKSB1c2UgYm90aAo+ID4gImFkanVzdGVkIG1vZGUi IGluIHRoZWlyIGNydGM/Cj4gCj4gVGhlIFN5bm9wc3lzIERTSSBkcml2ZXIgbWlnaHQgb25seSBi ZSB1c2VkIGJ5IHR3byBkaXNwbGF5IGNvbnRyb2xsZXIgZHJpdmVycwo+IHRvZGF5LCBpdCBpcyBu b25ldGhlbGVzcyBhIHN0YW5kYXJkIGJyaWRnZSBkcml2ZXIgdGhhdCBzaG91bGQgbm90IG1ha2Ug YW55Cj4gYXNzdW1wdGlvbiBvZiBhIHBhcnRpY3VsYXIgdXNlIG9mIHRoZSBhZGp1c3RlZF9tb2Rl IGluIHBhcnRpY3VsYXIgZGlzcGxheQo+IGNvbnRyb2xsZXIgZHJpdmVycy4gVG8gdXNlIHRoZSBh ZGp1c3RlZF9tb2RlIHZhbHVlIGluIGJyaWRnZSBkcml2ZXJzIHdlCj4gbmVlZCB0byBzdGFuZGFy ZGl6ZSBpdHMgdXNhZ2UsIG90aGVyd2lzZSB3ZSdsbCBlbmQgdXAgd2l0aAo+IGluY29tcGF0aWJp bGl0aWVzIGJldHdlZW4gYnJpZGdlIGRyaXZlcnMgYW5kIGRpc3BsYXkgY29udHJvbGxlciBkcml2 ZXJzLgoKTm93IHRoYXQgdGhlIGRvY3VtZW50YXRpb24gaGFzIGJlZW4gY2xhcmlmaWVkIEkgaGF2 ZSBubyBvYmplY3Rpb24gYWdhaW5zdCB0aGlzIApwYXRjaCBhbnltb3JlLgoKPiA+ID4+IFsxXSBo dHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMjAwMjQwLwo+ID4gPj4gWzJd IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8yMDA3MjAvCj4gPiA+PiAK PiA+ID4+PiBEYW5pZWwsIHdoYXQncyB5b3VyIG9waW5pb24gb24gdGhpcyA/Cj4gPiAKPiA+IERh bmllbCwgYW55IG9waW5pb24gb24gdGhlIGFkanVzdGVkX21vZGUgdXNhZ2U/Cj4gPiAKPiA+ID4+ Pj4gLS0tCj4gPiA+Pj4+IE5vdGU6IFRoaXMgcGF0Y2ggcmVwbGFjZXMgImRybS9icmlkZ2Uvc3lu b3BzeXM6IGRzaTogYWRkIG9wdGlvbmFsCj4gPiA+Pj4+IHBpeGVsIGNsb2NrIgo+ID4gPj4+PiAK PiA+ID4+Pj4gZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jIHwg MTIgKysrKysrLS0tLS0tCj4gPiA+Pj4+IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyks IDYgZGVsZXRpb25zKC0pCj4gPiA+Pj4+IAo+ID4gPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jCj4gPiA+Pj4+IGIvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jIGluZGV4Cj4gPiA+Pj4+IGVkOGFm MzJmOGU1Mi4uYjkyNmI2MmU5ZTMzIDEwMDY0NAo+ID4gPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3N5bm9wc3lzL2R3LW1pcGktZHNpLmMKPiA+ID4+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jCj4gPiA+Pj4+IEBAIC03MDcsMjAg KzcwNywyMCBAQCBzdGF0aWMgdm9pZCBkd19taXBpX2RzaV9icmlkZ2VfbW9kZV9zZXQoc3RydWN0 Cj4gPiA+Pj4+IGRybV9icmlkZ2UgKmJyaWRnZSwKPiA+ID4+Pj4gCj4gPiA+Pj4+ICAgIAljbGtf cHJlcGFyZV9lbmFibGUoZHNpLT5wY2xrKTsKPiA+ID4+Pj4gCj4gPiA+Pj4+IC0JcmV0ID0gcGh5 X29wcy0+Z2V0X2xhbmVfbWJwcyhwcml2X2RhdGEsIG1vZGUsIGRzaS0+bW9kZV9mbGFncywKPiA+ ID4+Pj4gKwlyZXQgPSBwaHlfb3BzLT5nZXRfbGFuZV9tYnBzKHByaXZfZGF0YSwgYWRqdXN0ZWRf bW9kZSwKPiA+ID4+Pj4gZHNpLT5tb2RlX2ZsYWdzLAo+ID4gPj4+PiAKPiA+ID4+Pj4gICAgCQkJ CSAgICAgZHNpLT5sYW5lcywgZHNpLT5mb3JtYXQsICZkc2ktPmxhbmVfbWJwcyk7Cj4gPiA+Pj4+ ICAgIAo+ID4gPj4+PiAgICBpZiAocmV0KQo+ID4gPj4+PiAgICAKPiA+ID4+Pj4gICAgCURSTV9E RUJVR19EUklWRVIoIlBoeSBnZXRfbGFuZV9tYnBzKCkgZmFpbGVkXG4iKTsKPiA+ID4+Pj4gICAg Cj4gPiA+Pj4+ICAgIHBtX3J1bnRpbWVfZ2V0X3N5bmMoZHNpLT5kZXYpOwo+ID4gPj4+PiAgICBk d19taXBpX2RzaV9pbml0KGRzaSk7Cj4gPiA+Pj4+IAo+ID4gPj4+PiAtCWR3X21pcGlfZHNpX2Rw aV9jb25maWcoZHNpLCBtb2RlKTsKPiA+ID4+Pj4gKwlkd19taXBpX2RzaV9kcGlfY29uZmlnKGRz aSwgYWRqdXN0ZWRfbW9kZSk7Cj4gPiA+Pj4+IAo+ID4gPj4+PiAgICBkd19taXBpX2RzaV9wYWNr ZXRfaGFuZGxlcl9jb25maWcoZHNpKTsKPiA+ID4+Pj4gICAgZHdfbWlwaV9kc2lfdmlkZW9fbW9k ZV9jb25maWcoZHNpKTsKPiA+ID4+Pj4gCj4gPiA+Pj4+IC0JZHdfbWlwaV9kc2lfdmlkZW9fcGFj a2V0X2NvbmZpZyhkc2ksIG1vZGUpOwo+ID4gPj4+PiArCWR3X21pcGlfZHNpX3ZpZGVvX3BhY2tl dF9jb25maWcoZHNpLCBhZGp1c3RlZF9tb2RlKTsKPiA+ID4+Pj4gCj4gPiA+Pj4+ICAgIGR3X21p cGlfZHNpX2NvbW1hbmRfbW9kZV9jb25maWcoZHNpKTsKPiA+ID4+Pj4gCj4gPiA+Pj4+IC0JZHdf bWlwaV9kc2lfbGluZV90aW1lcl9jb25maWcoZHNpLCBtb2RlKTsKPiA+ID4+Pj4gLQlkd19taXBp X2RzaV92ZXJ0aWNhbF90aW1pbmdfY29uZmlnKGRzaSwgbW9kZSk7Cj4gPiA+Pj4+ICsJZHdfbWlw aV9kc2lfbGluZV90aW1lcl9jb25maWcoZHNpLCBhZGp1c3RlZF9tb2RlKTsKPiA+ID4+Pj4gKwlk d19taXBpX2RzaV92ZXJ0aWNhbF90aW1pbmdfY29uZmlnKGRzaSwgYWRqdXN0ZWRfbW9kZSk7Cj4g PiA+Pj4+IAo+ID4gPj4+PiAgICBkd19taXBpX2RzaV9kcGh5X2luaXQoZHNpKTsKPiA+ID4+Pj4g ICAgZHdfbWlwaV9kc2lfZHBoeV90aW1pbmdfY29uZmlnKGRzaSk7Cj4gPiA+Pj4+IAo+ID4gPj4+ PiBAQCAtNzM0LDcgKzczNCw3IEBAIHN0YXRpYyB2b2lkIGR3X21pcGlfZHNpX2JyaWRnZV9tb2Rl X3NldChzdHJ1Y3QKPiA+ID4+Pj4gZHJtX2JyaWRnZSAqYnJpZGdlLAo+ID4gPj4+PiAKPiA+ID4+ Pj4gICAgZHdfbWlwaV9kc2lfZHBoeV9lbmFibGUoZHNpKTsKPiA+ID4+Pj4gCj4gPiA+Pj4+IC0J ZHdfbWlwaV9kc2lfd2FpdF9mb3JfdHdvX2ZyYW1lcyhtb2RlKTsKPiA+ID4+Pj4gKwlkd19taXBp X2RzaV93YWl0X2Zvcl90d29fZnJhbWVzKGFkanVzdGVkX21vZGUpOwo+ID4gPj4+PiAKPiA+ID4+ Pj4gICAgLyogU3dpdGNoIHRvIGNtZCBtb2RlIGZvciBwYW5lbC1icmlkZ2UgcHJlX2VuYWJsZSAm IHBhbmVsIHByZXBhcmUKPiA+ID4+Pj4gICAgKi8KPiA+ID4+Pj4gICAgZHdfbWlwaV9kc2lfc2V0 X21vZGUoZHNpLCAwKTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 23 Apr 2018 13:10:31 +0300 Subject: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set In-Reply-To: <1802436.kt7XbhHcH5@avalon> References: <20180125155504.8611-1-philippe.cornu@st.com> <7ec671c2-a777-5dcd-dcc9-e026fff89900@st.com> <1802436.kt7XbhHcH5@avalon> Message-ID: <2334482.mQhE6fZxKp@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Philippe, On Thursday, 8 February 2018 15:15:40 EEST Laurent Pinchart wrote: > On Saturday, 3 February 2018 00:41:26 EET Philippe CORNU wrote: > > On 01/29/2018 11:40 AM, Laurent Pinchart wrote: > > > On Monday, 29 January 2018 12:17:37 EET Philippe CORNU wrote: > > >> On 01/29/2018 10:46 AM, Laurent Pinchart wrote: > > >>> On Thursday, 25 January 2018 17:55:04 EET Philippe Cornu wrote: > > >>>> The "adjusted_mode" clock value (ie the real pixel clock) is more > > >>>> accurate than "mode" clock value (ie the panel/bridge requested > > >>>> clock value). It offers a better preciseness for timing > > >>>> computations and allows to reduce the extra dsi bandwidth in > > >>>> burst mode (from ~20% to ~10-12%, hw platform dependant). > > >>>> > > >>>> Signed-off-by: Philippe Cornu > > >>> > > >>> The adjusted mode is documented as > > >>> > > >>> /** > > >>> > > >>> * @adjusted_mode: > > >>> * > > >>> * Internal display timings which can be used by the driver to > > >>> handle > > >>> * differences between the mode requested by userspace in @mode and > > >>> what > > >>> * is actually programmed into the hardware. It is purely driver > > >>> * implementation defined what exactly this adjusted mode means. > > >>> Usually > > >>> * it is used to store the hardware display timings used between the > > >>> * CRTC and encoder blocks. > > >>> */ > > >>> > > >>> This is easy to handle when the CRTC and encoder are controlled by the > > >>> same driver, as the field is "implementation defined" by a single > > >>> driver. However, when using bridges, there are two drivers involved, > > >>> and > > >>> they must both agree to meaningfully use the adjusted mode. I can't > > >>> see > > >>> how to do so without standardizing the meaning of the adjusted mode > > >>> field. > > >> > > >> This is exactly the reason why my first implementation used the dsi > > >> bridge "optional pixel clock" instead of the adjusted_mode (see [1]) > > >> > > >> But after digging more into the drm source code, I think using > > >> adjusted_mode instead of the pixel clock here brings more advantages > > >> because: > > >> * adjusted_mode is an argument of bridge mode_set() probably for being > > >> used in any manner, maybe like this :) > > >> * if the bridge "user" (crtc or a master bridge drivers) does not need > > >> to modify its adjusted_mode then mode & adjusted_mode mode_set() > > >> arguments will have the same values so "no consequence" for the bridge. > > >> * if the bridge "user" (crtc or master bridge drivers) needs to adjust > > >> any value of the mode then this adjustment is available for the bridge. > > > > > > Remember that there can be multiple chained bridges, and a single > > > adjusted mode field. > > > > > >> * rockchip crtc updates a part of the mode (the clock), stm is doing > > >> the > > >> same (see [2]) but any future "user" of the dw_mipi_dsi bridge can > > >> adjust something else (blankings...) and the dw_mipi_dsi bridge will be > > >> then aware of... > > >> > > >> But maybe it is a wrong usage of the "adjusted_mode offer"... > > > > > > I don't disagree that there's a need for using adjusted values, but I > > > believe we need to create a clear API to do so. Using the adjust_mode > > > field as-is when it's clearly documented as being implementation-defined > > > is asking for trouble. > > > > Laurent, do you think we can use "adjusted mode" here in this small > > patch as the actual 2 "users" of this bridge (rockchip & stm) use both > > "adjusted mode" in their crtc? > > The Synopsys DSI driver might only be used by two display controller drivers > today, it is nonetheless a standard bridge driver that should not make any > assumption of a particular use of the adjusted_mode in particular display > controller drivers. To use the adjusted_mode value in bridge drivers we > need to standardize its usage, otherwise we'll end up with > incompatibilities between bridge drivers and display controller drivers. Now that the documentation has been clarified I have no objection against this patch anymore. > > >> [1] https://patchwork.freedesktop.org/patch/200240/ > > >> [2] https://patchwork.freedesktop.org/patch/200720/ > > >> > > >>> Daniel, what's your opinion on this ? > > > > Daniel, any opinion on the adjusted_mode usage? > > > > >>>> --- > > >>>> Note: This patch replaces "drm/bridge/synopsys: dsi: add optional > > >>>> pixel clock" > > >>>> > > >>>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 12 ++++++------ > > >>>> 1 file changed, 6 insertions(+), 6 deletions(-) > > >>>> > > >>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index > > >>>> ed8af32f8e52..b926b62e9e33 100644 > > >>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> @@ -707,20 +707,20 @@ static void dw_mipi_dsi_bridge_mode_set(struct > > >>>> drm_bridge *bridge, > > >>>> > > >>>> clk_prepare_enable(dsi->pclk); > > >>>> > > >>>> - ret = phy_ops->get_lane_mbps(priv_data, mode, dsi->mode_flags, > > >>>> + ret = phy_ops->get_lane_mbps(priv_data, adjusted_mode, > > >>>> dsi->mode_flags, > > >>>> > > >>>> dsi->lanes, dsi->format, &dsi->lane_mbps); > > >>>> > > >>>> if (ret) > > >>>> > > >>>> DRM_DEBUG_DRIVER("Phy get_lane_mbps() failed\n"); > > >>>> > > >>>> pm_runtime_get_sync(dsi->dev); > > >>>> dw_mipi_dsi_init(dsi); > > >>>> > > >>>> - dw_mipi_dsi_dpi_config(dsi, mode); > > >>>> + dw_mipi_dsi_dpi_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_packet_handler_config(dsi); > > >>>> dw_mipi_dsi_video_mode_config(dsi); > > >>>> > > >>>> - dw_mipi_dsi_video_packet_config(dsi, mode); > > >>>> + dw_mipi_dsi_video_packet_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_command_mode_config(dsi); > > >>>> > > >>>> - dw_mipi_dsi_line_timer_config(dsi, mode); > > >>>> - dw_mipi_dsi_vertical_timing_config(dsi, mode); > > >>>> + dw_mipi_dsi_line_timer_config(dsi, adjusted_mode); > > >>>> + dw_mipi_dsi_vertical_timing_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_dphy_init(dsi); > > >>>> dw_mipi_dsi_dphy_timing_config(dsi); > > >>>> > > >>>> @@ -734,7 +734,7 @@ static void dw_mipi_dsi_bridge_mode_set(struct > > >>>> drm_bridge *bridge, > > >>>> > > >>>> dw_mipi_dsi_dphy_enable(dsi); > > >>>> > > >>>> - dw_mipi_dsi_wait_for_two_frames(mode); > > >>>> + dw_mipi_dsi_wait_for_two_frames(adjusted_mode); > > >>>> > > >>>> /* Switch to cmd mode for panel-bridge pre_enable & panel prepare > > >>>> */ > > >>>> dw_mipi_dsi_set_mode(dsi, 0); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbeDWKKX (ORCPT ); Mon, 23 Apr 2018 06:10:23 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:50836 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754446AbeDWKKT (ORCPT ); Mon, 23 Apr 2018 06:10:19 -0400 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Philippe CORNU , Bhumika Goyal , Alexandre TORGUE , David Airlie , "daniel.vetter@ffwll.ch" , Brian Norris , "linux-kernel@vger.kernel.org" , Yannick FERTRE , "linux-rockchip@lists.infradead.org" , Ludovic BARRE , Maxime Coquelin , Mickael REULIER , Vincent ABRIOU , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set Date: Mon, 23 Apr 2018 13:10:31 +0300 Message-ID: <2334482.mQhE6fZxKp@avalon> Organization: Ideas on Board Oy In-Reply-To: <1802436.kt7XbhHcH5@avalon> References: <20180125155504.8611-1-philippe.cornu@st.com> <7ec671c2-a777-5dcd-dcc9-e026fff89900@st.com> <1802436.kt7XbhHcH5@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Thursday, 8 February 2018 15:15:40 EEST Laurent Pinchart wrote: > On Saturday, 3 February 2018 00:41:26 EET Philippe CORNU wrote: > > On 01/29/2018 11:40 AM, Laurent Pinchart wrote: > > > On Monday, 29 January 2018 12:17:37 EET Philippe CORNU wrote: > > >> On 01/29/2018 10:46 AM, Laurent Pinchart wrote: > > >>> On Thursday, 25 January 2018 17:55:04 EET Philippe Cornu wrote: > > >>>> The "adjusted_mode" clock value (ie the real pixel clock) is more > > >>>> accurate than "mode" clock value (ie the panel/bridge requested > > >>>> clock value). It offers a better preciseness for timing > > >>>> computations and allows to reduce the extra dsi bandwidth in > > >>>> burst mode (from ~20% to ~10-12%, hw platform dependant). > > >>>> > > >>>> Signed-off-by: Philippe Cornu > > >>> > > >>> The adjusted mode is documented as > > >>> > > >>> /** > > >>> > > >>> * @adjusted_mode: > > >>> * > > >>> * Internal display timings which can be used by the driver to > > >>> handle > > >>> * differences between the mode requested by userspace in @mode and > > >>> what > > >>> * is actually programmed into the hardware. It is purely driver > > >>> * implementation defined what exactly this adjusted mode means. > > >>> Usually > > >>> * it is used to store the hardware display timings used between the > > >>> * CRTC and encoder blocks. > > >>> */ > > >>> > > >>> This is easy to handle when the CRTC and encoder are controlled by the > > >>> same driver, as the field is "implementation defined" by a single > > >>> driver. However, when using bridges, there are two drivers involved, > > >>> and > > >>> they must both agree to meaningfully use the adjusted mode. I can't > > >>> see > > >>> how to do so without standardizing the meaning of the adjusted mode > > >>> field. > > >> > > >> This is exactly the reason why my first implementation used the dsi > > >> bridge "optional pixel clock" instead of the adjusted_mode (see [1]) > > >> > > >> But after digging more into the drm source code, I think using > > >> adjusted_mode instead of the pixel clock here brings more advantages > > >> because: > > >> * adjusted_mode is an argument of bridge mode_set() probably for being > > >> used in any manner, maybe like this :) > > >> * if the bridge "user" (crtc or a master bridge drivers) does not need > > >> to modify its adjusted_mode then mode & adjusted_mode mode_set() > > >> arguments will have the same values so "no consequence" for the bridge. > > >> * if the bridge "user" (crtc or master bridge drivers) needs to adjust > > >> any value of the mode then this adjustment is available for the bridge. > > > > > > Remember that there can be multiple chained bridges, and a single > > > adjusted mode field. > > > > > >> * rockchip crtc updates a part of the mode (the clock), stm is doing > > >> the > > >> same (see [2]) but any future "user" of the dw_mipi_dsi bridge can > > >> adjust something else (blankings...) and the dw_mipi_dsi bridge will be > > >> then aware of... > > >> > > >> But maybe it is a wrong usage of the "adjusted_mode offer"... > > > > > > I don't disagree that there's a need for using adjusted values, but I > > > believe we need to create a clear API to do so. Using the adjust_mode > > > field as-is when it's clearly documented as being implementation-defined > > > is asking for trouble. > > > > Laurent, do you think we can use "adjusted mode" here in this small > > patch as the actual 2 "users" of this bridge (rockchip & stm) use both > > "adjusted mode" in their crtc? > > The Synopsys DSI driver might only be used by two display controller drivers > today, it is nonetheless a standard bridge driver that should not make any > assumption of a particular use of the adjusted_mode in particular display > controller drivers. To use the adjusted_mode value in bridge drivers we > need to standardize its usage, otherwise we'll end up with > incompatibilities between bridge drivers and display controller drivers. Now that the documentation has been clarified I have no objection against this patch anymore. > > >> [1] https://patchwork.freedesktop.org/patch/200240/ > > >> [2] https://patchwork.freedesktop.org/patch/200720/ > > >> > > >>> Daniel, what's your opinion on this ? > > > > Daniel, any opinion on the adjusted_mode usage? > > > > >>>> --- > > >>>> Note: This patch replaces "drm/bridge/synopsys: dsi: add optional > > >>>> pixel clock" > > >>>> > > >>>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 12 ++++++------ > > >>>> 1 file changed, 6 insertions(+), 6 deletions(-) > > >>>> > > >>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index > > >>>> ed8af32f8e52..b926b62e9e33 100644 > > >>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > > >>>> @@ -707,20 +707,20 @@ static void dw_mipi_dsi_bridge_mode_set(struct > > >>>> drm_bridge *bridge, > > >>>> > > >>>> clk_prepare_enable(dsi->pclk); > > >>>> > > >>>> - ret = phy_ops->get_lane_mbps(priv_data, mode, dsi->mode_flags, > > >>>> + ret = phy_ops->get_lane_mbps(priv_data, adjusted_mode, > > >>>> dsi->mode_flags, > > >>>> > > >>>> dsi->lanes, dsi->format, &dsi->lane_mbps); > > >>>> > > >>>> if (ret) > > >>>> > > >>>> DRM_DEBUG_DRIVER("Phy get_lane_mbps() failed\n"); > > >>>> > > >>>> pm_runtime_get_sync(dsi->dev); > > >>>> dw_mipi_dsi_init(dsi); > > >>>> > > >>>> - dw_mipi_dsi_dpi_config(dsi, mode); > > >>>> + dw_mipi_dsi_dpi_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_packet_handler_config(dsi); > > >>>> dw_mipi_dsi_video_mode_config(dsi); > > >>>> > > >>>> - dw_mipi_dsi_video_packet_config(dsi, mode); > > >>>> + dw_mipi_dsi_video_packet_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_command_mode_config(dsi); > > >>>> > > >>>> - dw_mipi_dsi_line_timer_config(dsi, mode); > > >>>> - dw_mipi_dsi_vertical_timing_config(dsi, mode); > > >>>> + dw_mipi_dsi_line_timer_config(dsi, adjusted_mode); > > >>>> + dw_mipi_dsi_vertical_timing_config(dsi, adjusted_mode); > > >>>> > > >>>> dw_mipi_dsi_dphy_init(dsi); > > >>>> dw_mipi_dsi_dphy_timing_config(dsi); > > >>>> > > >>>> @@ -734,7 +734,7 @@ static void dw_mipi_dsi_bridge_mode_set(struct > > >>>> drm_bridge *bridge, > > >>>> > > >>>> dw_mipi_dsi_dphy_enable(dsi); > > >>>> > > >>>> - dw_mipi_dsi_wait_for_two_frames(mode); > > >>>> + dw_mipi_dsi_wait_for_two_frames(adjusted_mode); > > >>>> > > >>>> /* Switch to cmd mode for panel-bridge pre_enable & panel prepare > > >>>> */ > > >>>> dw_mipi_dsi_set_mode(dsi, 0); -- Regards, Laurent Pinchart