From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] pmdinfogen: allow using stdin and stdout
Date: Mon, 29 Jan 2018 20:49:39 +0100 [thread overview]
Message-ID: <2334903.1Cxcry8nHy@xps> (raw)
In-Reply-To: <20180125213040.GB12245@neilslaptop.think-freely.org>
25/01/2018 22:30, Neil Horman:
> On Thu, Jan 25, 2018 at 11:12:25AM +0000, Bruce Richardson wrote:
> > Rather than having to work off files all the time, allow stdin and stdout
> > to be used as the source and destination for pmdinfogen. This will allow
> > other possible usages from scripts, e.g. taking files from ar archive and
> > building a single .pmd.c file from all the .o files in it.
> >
> > for f in `ar t librte_pmd_xyz.a` ; do
> > ar p librte_pmd_xyz.a $f | pmdinfogen - - >> xyz_info.c
> > done
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> I think this is a great idea. FWIW, I think the ELF header at the front of the
> file should have something that tells you the overall disk file size in it. The
> ELF header is pretty easy to parse and do some basic evaluation on, so you could
> accelerate that read a bit, by breaking it down into a read of the size of the
> header, followed by a parsing of it and a subsequent read of the overall size,
> but that probably just nice to have
>
> Either way, this is a worthwhile feature to have
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks
prev parent reply other threads:[~2018-01-29 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 11:12 [PATCH] pmdinfogen: allow using stdin and stdout Bruce Richardson
2018-01-25 21:30 ` Neil Horman
2018-01-26 9:19 ` Bruce Richardson
2018-01-29 19:49 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2334903.1Cxcry8nHy@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.