From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, kraxel@redhat.com
Subject: Re: [PATCH] hw/usb: Convert to qdev_realize()
Date: Tue, 19 Jan 2021 15:00:36 +0100 [thread overview]
Message-ID: <2335ea3d-3409-fa80-a1fe-9cb796bee095@redhat.com> (raw)
In-Reply-To: <20210119120151.53757-1-armbru@redhat.com>
On 1/19/21 1:01 PM, Markus Armbruster wrote:
> Device code shouldn't mess with QOM property "realized" since we have
> proper interfaces (merge commit 6675a653). Commit 8ddab8dd3d
> "usb/hcd-xhci: Split pci wrapper for xhci base model" and commit
> f00ff136ee "usb: hcd-xhci-sysbus: Attach xhci to sysbus device"
> reintroduced two instances. Clean them up. Note that s->xhci is
> a (bus-less) TYPE_XHCI device.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/usb/hcd-xhci-pci.c | 4 +---
> hw/usb/hcd-xhci-sysbus.c | 5 +----
> 2 files changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-01-19 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 12:01 [PATCH] hw/usb: Convert to qdev_realize() Markus Armbruster
2021-01-19 14:00 ` Philippe Mathieu-Daudé [this message]
2021-01-19 16:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2335ea3d-3409-fa80-a1fe-9cb796bee095@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.