From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Zhang Yi <zhangyi@everest-semi.com>,
broonie@kernel.org, tiwai@suse.com, linux-sound@vger.kernel.org
Cc: peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com
Subject: Re: [PATCH v4 4/6] ASoC: es9356-sdca: Add ES9356 SDCA driver
Date: Tue, 31 Mar 2026 16:46:34 +0200 [thread overview]
Message-ID: <2336199e-5fa0-4990-b3df-495e3c3e893a@linux.dev> (raw)
In-Reply-To: <20260327095954.3465-5-zhangyi@everest-semi.com>
> +#define SDW_SDCA_CTL_MBQ(fun, ent, ctl, ch) (SDW_SDCA_CTL(fun, ent, ctl, ch) | MBQ)
> +#define SDW_SDCA_HCTL(fun, ent, ctl, ch) (SDW_SDCA_CTL(fun, ent, ctl, ch) | 0x80000)
> +#define SDW_SDCA_REG_MBQ(reg) (reg | MBQ)
these macros should really be part of a common header.
Alternatively use regmap_mbq() and hide those access details...
next prev parent reply other threads:[~2026-03-31 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 9:59 [PATCH v4 0/6] Add es9356 focused SoundWire CODEC Zhang Yi
2026-03-27 9:59 ` [PATCH v4 1/6] ASoC: sdw_utils: Add ES9356 support functions Zhang Yi
2026-03-31 12:28 ` Pierre-Louis Bossart
2026-03-27 9:59 ` [PATCH v4 2/6] ASoC: sdw_utils: add ES9356 in codec_info_list Zhang Yi
2026-03-31 12:27 ` Pierre-Louis Bossart
2026-03-27 9:59 ` [PATCH v4 3/6] ASoC: sdw_utils: add soc_sdw_es9356 Zhang Yi
2026-03-31 14:42 ` Pierre-Louis Bossart
2026-03-27 9:59 ` [PATCH v4 4/6] ASoC: es9356-sdca: Add ES9356 SDCA driver Zhang Yi
2026-03-27 13:24 ` Charles Keepax
2026-03-31 14:46 ` Pierre-Louis Bossart [this message]
2026-03-27 9:59 ` [PATCH v4 5/6] ASoC: Intel: soc-acpi: arl: Add es9356 support Zhang Yi
2026-03-31 14:48 ` Pierre-Louis Bossart
2026-03-27 9:59 ` [PATCH v4 6/6] ASoC: Intel: sof_sdw: add " Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2336199e-5fa0-4990-b3df-495e3c3e893a@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.