All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Sunil Kumar Kori <skori@marvell.com>, Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key
Date: Tue, 17 Oct 2023 14:08:05 +0200	[thread overview]
Message-ID: <2339972.BjyWNHgNrj@thomas> (raw)
In-Reply-To: <20231009163610.1096092-1-skori@marvell.com>

Adding the script author, Robin.

09/10/2023 18:36, skori@marvell.com:
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> This patch adds RSS key for CNXK platforms. CNXK platform uses
> 48 bytes long key for hash calculations.
> 
> For the same patch also updates help mesaages to provide range
> information for supporting NICs/platforms.
> 
> Also CNXK uses reta size as 64 so to get correct offset to retrieve
> queue index, user must pass reta_size option as 64 i.e. -t 64.

Can it be something automatic instead of asking the user to pass -t 64?

> +# rss_key_default, see drivers/net/cnxk/cnxk_flow.c

I don't see rss_key_default in drivers/net/cnxk/cnxk_flow.c

> +# Marvell's cnxk NICs take 48 bytes keys
> +RSS_KEY_CNXK = bytes(
> +    (
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +        0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,
> +    )
> +)




  parent reply	other threads:[~2023-10-17 12:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 16:30 [PATCH] usertools/rss: add CNXK RSS key skori
2023-10-09 16:36 ` [PATCH v2 1/1] " skori
2023-10-10  5:47   ` Jerin Jacob
2023-10-17 12:08   ` Thomas Monjalon [this message]
2023-10-17 12:17   ` Robin Jarry
2023-10-18  7:26     ` [EXT] " Sunil Kumar Kori
2023-10-18  9:14       ` Thomas Monjalon
2023-10-18  9:18         ` Robin Jarry
2023-10-18 10:01           ` Sunil Kumar Kori
2023-10-25 12:47             ` Robin Jarry
2023-10-18  7:29   ` [PATCH v3 " skori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2339972.BjyWNHgNrj@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=rjarry@redhat.com \
    --cc=skori@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.