From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F376517D88C; Tue, 11 Jun 2024 14:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718115168; cv=none; b=Mu811sgH5Y3bzmPtVWiVA4AmgFxOaZE8d/mamR4RH/eB0QxdNlOsk0X4saybmvvwKgBZO1rCSlyaGZgdSJcRh3Zo9JvqGvfg/7A9k0lwSSlb50KXV6dQBKAbJRTOwidOp8/Xqgt//HBcXbCBftdHgpAVvq0GVcPC37skEPluCc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718115168; c=relaxed/simple; bh=uwcdBzLuAxEDrNoXrhjSgpM2Fga3hryzixwO3pPxk/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hL+9ei2/c+ju5pMt60e95cGCxpt5VEDEFhYpSL2aU57wfKnAjdXC9Sa8/DBGfRGSyaKT6SXycwWUrKRjgLsr5No0kwuuDYhIC1zFD0/hjVyveoDLgb9rD7b0rdALFnTJvYCpWsTiWSx6UaIYuPFYn0mWDQUzbkDGhPxVNzLRV+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=focMhIO2; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="focMhIO2" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2eabd22d441so91054971fa.2; Tue, 11 Jun 2024 07:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718115165; x=1718719965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RGZsWMQxIR/8a9H8paH0XFiZvIlanvQPzCmlVbwusdU=; b=focMhIO23gjgssmwHEVF36RM3pNmCQ56oJkQPiezfRVIj22rUDggYATELGrvql/TO7 8QwVj9g63tULkNfT3WGsOZwmY5xpElCqinacNMNVVd8MY8T2THh7iWWhyY/8/aXfgBBu f+D2x8IUMqgtTFjQDxchwccN/UI2M3SiMMCFiDV4SsjLIfuzuZXojtuSG2O97JGWfkWJ xQOddafsWeNXypYEAej1xo5L3DZUMRoqjUin5nahe1MI2rV/JovdNCCRYqo2KRkPtlFi WPuq3uXELcliLnkB5Bk3hEa0mkybgOTQz6ax55xjtbsyjHD2hvbrtk54hGlcTROV4ZQf dxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718115165; x=1718719965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RGZsWMQxIR/8a9H8paH0XFiZvIlanvQPzCmlVbwusdU=; b=R4G78RK+ZAuLyQMXThwcP6mBIFFC7reFlujkDTWfK0GYHkPt/5yOnE2mw/QHbda3Wx x0c88rCvcWimbYeAQaeuYlomyhJT87Qbq/LarS7lYZG/bxxGhUyX1rNklXuHK8mHFjAy toEkbtUn+2O5M/XGInTtbfC8MgyhMGE9hNq4VzR7CbsWmnYisF1LRSIc6kVNrxja1SLd sej+eUNxTJ7sXcB/Gbm+R3UhSBLxaiubdqV/WGuwIzMhWpeqdtN2OUQFOKGrq2PhqYlW WHxqV/xiU5qKnpdeD5/0S4uM/o2iCuCeAPHzFun5SezFIibd6ClF7+zHoYotzO2eXLu6 sJpA== X-Forwarded-Encrypted: i=1; AJvYcCWZ7/6/lP+21zoLs4Fyin+KRNAV22X7a7pDOFcgXxz/jDfzVmcaV/P45h9HaUvJXRM8jwCVTZvhOQBhYUYE46aE6jAO0v+/GFzgAlGVvNdkgEeqoz9c97z20vFfo7OeLJyMqqarCQLP1A== X-Gm-Message-State: AOJu0YzvPFt0uRNOvHrC7km199wU6z8/bL1r+X/fwhgxFc8s3IX8Hfn8 bOl6jFUm4AZAIPz4QxXSJUPMMbdRRwWT5cWZ5TGSVz9ib+vX9TT0 X-Google-Smtp-Source: AGHT+IGuq4XXKdcSy2MRECTQb8OvnrexiaWWjJespHlYnvTZ0wLoCtN53WXIbcE0kkCOgg4nKbvssA== X-Received: by 2002:a2e:3612:0:b0:2eb:17fe:a144 with SMTP id 38308e7fff4ca-2eb17fea1c5mr62244931fa.34.1718115164779; Tue, 11 Jun 2024 07:12:44 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:89c3:827b:2198:62f2? (2a02-8389-41cf-e200-89c3-827b-2198-62f2.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:89c3:827b:2198:62f2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6effb9cd7asm457716466b.208.2024.06.11.07.12.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 07:12:44 -0700 (PDT) Message-ID: <233d56de-8d5d-4bad-a380-45321a2d86ac@gmail.com> Date: Tue, 11 Jun 2024 16:12:42 +0200 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: mt6360: fix memory leak in mt6360_init_isnk_properties() To: Markus Elfring , linux-leds@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Angelo Gioacchino Del Regno , Lee Jones , Matthias Brugger , Pavel Machek Cc: stable@vger.kernel.org, LKML , Jonathan Cameron References: <20240611-leds-mt6360-memleak-v1-1-93642eb5011e@gmail.com> <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/06/2024 16:01, Markus Elfring wrote: > … >> Add the missing calls to fwnode_handle_put(child) to avoid memory leaks >> in the error paths. > > I suggest to apply a goto chain for a while. > https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources > > Will the application of scope-based resource management become feasible with another delay? > https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L8 > > Regards, > Markus I considered that option too, but there is still no _scoped() variant of the loop. The scoped version of the _available_ variant is being discussed, though. Maybe that one could be used here if there is no need to iterate over unavailable nodes. We could not back port that solution anyway, so I would suggest this solution (or the one with a goto), and then a separate patch to used a scoped macro if preferred. Best regards, Javier Carrasco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C496C27C5E for ; Tue, 11 Jun 2024 14:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LBcqwIofHPakTTFkxfMMTOyUXh3Mf3lbjZxcE3+S2TQ=; b=B7f/YGNGTy/okZ cDj3MGEdiTkcSJZ+CQ22OivXO4CPtT84Ees4bBGhU1O/gjnaOrR+/mFC6gfTVbGlhgB3oJxeIsPou iudUH0/18LI0qtVW9R/Mo6XvWzATefPsvmQcST28W/BafW41yYG9qeJWESjRrAjur220yalmxnlWa yX5+pd3tKF6taiDiu6+V2YRfsryQaVr6MBqg8JmVZP8Qdujz4AD/vC54GKlHFHLmhb7BAyQFTzNaU ii3lVSXkEr0QREz9I2DzeQ4tIicRrLoGAPlKVv31wUBJplC9C4i0Hl2NFwvBbiRuE9uWUcKSVxN5Y TDWPNYQtJ1t/v3vBkvHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH2F1-0000000970V-1tbM; Tue, 11 Jun 2024 14:12:51 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH2Ex-000000096zP-2Bk1; Tue, 11 Jun 2024 14:12:49 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2eaae2a6dc1so112571071fa.0; Tue, 11 Jun 2024 07:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718115165; x=1718719965; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RGZsWMQxIR/8a9H8paH0XFiZvIlanvQPzCmlVbwusdU=; b=XcmSrb5cem020o+EvztDW/7pX0CwXTQe+AM/JnOw9AMJToR2+WWvV5LvmA1P1Cx1HA v6ymh+8rQqTv8zIM/UCdbCpNlFTMlNF0oVusAKDPQ0/XzTH75mvjFp7JLO7iB7KoDEDS vPh0OKBY9UXm/9IqfIM9XfQz1qNmQlDapFQiT4XkYH4thROyh3/T6mCDGVDXJbcWm5aJ +eg2TjCiycVL+918oTolITiEBgFv6VL93kHAirJKB96qMePfVNg35ZvQsGbfdLGFgsGp g+XPqKyowWT4mGFyzBXm6ygFNdJ3Xx4xd1QLtMbKh7kcFFfSquRgCn2s1h14Dv2LVmpT OJrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718115165; x=1718719965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RGZsWMQxIR/8a9H8paH0XFiZvIlanvQPzCmlVbwusdU=; b=j1iZvUYz8nD4suPhqy102k550Zw31HlGJhEuVJwPIUfH1yhdjR8sQsIHnRRIDBj23y mVHaaPpx8fkEbQkWkFrpBGJZ+OMz3IhBzpiySaQflGzUIJZdlS3l5GBvLa9FnCpucLQU o1lbUpYtuq6kB625FfoBjtCl9LVbFXrcAWzJsd8v8jXI7DsRsdcUqbHYdbhSFcQ9JPBT iPsCPOQHBjpBA9fHQAWxXcY4YzCJS6mNPgVJ9bLHCqmqE8y7EIj/NUH7uDezQVXItCMv Xk12uo3o2PkKRYA6528q5asHFEarVFgN6o+/o8K3OvGViExTaMBOjgDcAaaOmbZEe7af WsPg== X-Forwarded-Encrypted: i=1; AJvYcCWr6ppgni5hu5JYZlMKZFJQucuCEc4LpT/4zGBBNoMHMhBoHoCB5PrRF6sCTsZAQ7f9N9+owR8Sqb9SUCwsgif3kOB2dSv6/9o2zTdXXeSmOM6XdEvejivostUo2viuL5EevnQOxerulcUDnxg0Raiie9cYPeZSE0I= X-Gm-Message-State: AOJu0YxUQx2bDN3WNioBJddvlhonlvSOiu4I+dd5DvJiOsKlaZbW/ya/ R+rfs6g7s/nIVF8wLAuJA9jpDEwUDx/ZSqSU+11qwXG+N3aeDnPO X-Google-Smtp-Source: AGHT+IGuq4XXKdcSy2MRECTQb8OvnrexiaWWjJespHlYnvTZ0wLoCtN53WXIbcE0kkCOgg4nKbvssA== X-Received: by 2002:a2e:3612:0:b0:2eb:17fe:a144 with SMTP id 38308e7fff4ca-2eb17fea1c5mr62244931fa.34.1718115164779; Tue, 11 Jun 2024 07:12:44 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:89c3:827b:2198:62f2? (2a02-8389-41cf-e200-89c3-827b-2198-62f2.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:89c3:827b:2198:62f2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6effb9cd7asm457716466b.208.2024.06.11.07.12.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 07:12:44 -0700 (PDT) Message-ID: <233d56de-8d5d-4bad-a380-45321a2d86ac@gmail.com> Date: Tue, 11 Jun 2024 16:12:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: mt6360: fix memory leak in mt6360_init_isnk_properties() To: Markus Elfring , linux-leds@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Angelo Gioacchino Del Regno , Lee Jones , Matthias Brugger , Pavel Machek Cc: stable@vger.kernel.org, LKML , Jonathan Cameron References: <20240611-leds-mt6360-memleak-v1-1-93642eb5011e@gmail.com> <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_071247_583354_CE83FAC5 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMDYvMjAyNCAxNjowMSwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4g4oCmCj4+IEFkZCB0 aGUgbWlzc2luZyBjYWxscyB0byBmd25vZGVfaGFuZGxlX3B1dChjaGlsZCkgdG8gYXZvaWQgbWVt b3J5IGxlYWtzCj4+IGluIHRoZSBlcnJvciBwYXRocy4KPiAKPiBJIHN1Z2dlc3QgdG8gYXBwbHkg YSBnb3RvIGNoYWluIGZvciBhIHdoaWxlLgo+IGh0dHBzOi8vd2lraS5zZWkuY211LmVkdS9jb25m bHVlbmNlL2Rpc3BsYXkvYy9NRU0xMi1DLitDb25zaWRlcit1c2luZythK2dvdG8rY2hhaW4rd2hl bitsZWF2aW5nK2ErZnVuY3Rpb24rb24rZXJyb3Ird2hlbit1c2luZythbmQrcmVsZWFzaW5nK3Jl c291cmNlcwo+IAo+IFdpbGwgdGhlIGFwcGxpY2F0aW9uIG9mIHNjb3BlLWJhc2VkIHJlc291cmNl IG1hbmFnZW1lbnQgYmVjb21lIGZlYXNpYmxlIHdpdGggYW5vdGhlciBkZWxheT8KPiBodHRwczov L2VsaXhpci5ib290bGluLmNvbS9saW51eC92Ni4xMC1yYzMvc291cmNlL2luY2x1ZGUvbGludXgv Y2xlYW51cC5oI0w4Cj4gCj4gUmVnYXJkcywKPiBNYXJrdXMKCkkgY29uc2lkZXJlZCB0aGF0IG9w dGlvbiB0b28sIGJ1dCB0aGVyZSBpcyBzdGlsbCBubyBfc2NvcGVkKCkgdmFyaWFudCBvZgp0aGUg bG9vcC4gVGhlIHNjb3BlZCB2ZXJzaW9uIG9mIHRoZSBfYXZhaWxhYmxlXyB2YXJpYW50IGlzIGJl aW5nCmRpc2N1c3NlZCwgdGhvdWdoLiBNYXliZSB0aGF0IG9uZSBjb3VsZCBiZSB1c2VkIGhlcmUg aWYgdGhlcmUgaXMgbm8gbmVlZAp0byBpdGVyYXRlIG92ZXIgdW5hdmFpbGFibGUgbm9kZXMuCgpX ZSBjb3VsZCBub3QgYmFjayBwb3J0IHRoYXQgc29sdXRpb24gYW55d2F5LCBzbyBJIHdvdWxkIHN1 Z2dlc3QgdGhpcwpzb2x1dGlvbiAob3IgdGhlIG9uZSB3aXRoIGEgZ290byksIGFuZCB0aGVuIGEg c2VwYXJhdGUgcGF0Y2ggdG8gdXNlZCBhCnNjb3BlZCBtYWNybyBpZiBwcmVmZXJyZWQuCgpCZXN0 IHJlZ2FyZHMsCkphdmllciBDYXJyYXNjbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==