From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-spi-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 32044C433EF
	for <linux-spi@archiver.kernel.org>; Wed,  9 Feb 2022 17:30:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232618AbiBIR37 (ORCPT <rfc822;linux-spi@archiver.kernel.org>);
        Wed, 9 Feb 2022 12:29:59 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58202 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238325AbiBIR36 (ORCPT
        <rfc822;linux-spi@vger.kernel.org>); Wed, 9 Feb 2022 12:29:58 -0500
Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA067C05CB88;
        Wed,  9 Feb 2022 09:30:00 -0800 (PST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
        (Authenticated sender: tonyk)
        with ESMTPSA id 65C3D1F45BE1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
        s=mail; t=1644427799;
        bh=xT2tt+7x9ScJ7oQzrsb0MCXuuYZ/niEK3g8yTn+Jz+M=;
        h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
        b=nLwqLFxXloHDF8MraubLj+wClqNUb89qfvjTf+h86iRzGEikTT+f/y1ZQu48AxN4m
         aSwrNBn8zpkTNshytzA97vrvTD8TpwejCK8WrjZHo8yNcbxVowZqMN+dX5bkF04mVC
         h0PXVbv93bE6Weklsh95tfDt3IwSnIRMrPvS80WYuSRKJAWIMtZP7Khq9mUMPjcJO8
         4r8uRaenUPgpFCwnGWaNP6KYBK2gaXeFrf7SvhuAsS7IqlGVoT1GaQcwhr6n0mVUC7
         +M0jhKfIyx8LJgyy+03pgO4LliqDcC6ALhgUT8o8UnE0EsKnKakQ5YlZmldICE1yR6
         FvrMAWNvgu2fw==
Message-ID: <233fa514-0cce-094d-183b-601aaa46df0d@collabora.com>
Date:   Wed, 9 Feb 2022 14:29:53 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH 3/3] spi: amd: Add support for version AMDI0062
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     Sanjay R Mehta <sanju.mehta@amd.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>
References: <20220209165733.43134-1-andrealmeid@collabora.com>
 <20220209165733.43134-4-andrealmeid@collabora.com>
 <YgP2fIbASQym9sUP@sirena.org.uk>
 <2126f6c0-fd6e-1f8e-b450-837270d03d31@collabora.com>
 <YgP5o0pBL/DuZsn4@sirena.org.uk>
From:   =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@collabora.com>
In-Reply-To: <YgP5o0pBL/DuZsn4@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-spi.vger.kernel.org>
X-Mailing-List: linux-spi@vger.kernel.org

Às 14:28 de 09/02/22, Mark Brown escreveu:
> On Wed, Feb 09, 2022 at 02:18:59PM -0300, André Almeida wrote:
>> Às 14:14 de 09/02/22, Mark Brown escreveu:
> 
>>>> +
>>>> +	if (amd_spi->version == AMD_SPI_V2)
>>>> +		amd_spi_clear_chip(amd_spi, message->spi->chip_select);
>>>>  	spi_finalize_current_message(master);
>>>>  
>>>>  	return 0;
> 
>>> Why is this one not a switch statement - what happens with v3?
> 
>> A switch statement should work as well, but currently v1 does nothing
>> and there's no v3 for now. I think we can change for a switch if v3
>> requires to do something here as well.
> 
> Please write it in an extensible fashion now so people aren't tempted to
> add an if/else tree.

Got it, I will fix it for the next patch version, thanks!