From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: fix testpmd exit using ctrl+d
Date: Tue, 24 Jul 2018 15:39:33 +0200
Message-ID: <2340431.Cz5R7fPtqY@xps>
References: <20180723104425.10090-1-jasvinder.singh@intel.com>
 <1925999.Zqez9Xlb98@xps>
 <8CEF83825BEC744B83065625E567D7C260CCEE52@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>,
 "motih@mellanox.com" <motih@mellanox.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Dumitrescu,
 Cristian" <cristian.dumitrescu@intel.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CB84D235
 for <dev@dpdk.org>; Tue, 24 Jul 2018 15:39:39 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCEE52@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

24/07/2018 14:41, Iremonger, Bernard:
> Hi Thomas,
> 
> +John
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 
> > Important note:
> > 	testpmd is currently really broken.
> > 	We cannot have a RC2 until it is fixed.
> > 
> > 
> > 24/07/2018 13:25, Thomas Monjalon:
> > > 23/07/2018 12:44, Jasvinder Singh:
> > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission
> > > > character (EOT) on the empty command line.
> > >
> > > Please describe what is the issue and what is the cause.
> > >
> > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> > > >
> > > > Reported-by: Mordechay Haimovsky <motih@mellanox.com>
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > ---
> > > >  app/test-pmd/cmdline.c       | 10 ++++++----
> > > >  lib/librte_cmdline/cmdline.c |  2 +-
> > >
> > > It is very suspicious to change the cmdline library.
> > > If there is a bug in this library, it deserves a separate fix.
> > 
> > 
> 
> Do you know what commit has broken testpmd?

I think the "Fixes" line above is right:
	0ad778b398c6 ("app/testpmd: rework softnic forward mode")