From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/failsafe: fix blank line parsing
Date: Thu, 03 Aug 2017 22:34:59 +0200
Message-ID: <2340494.aB5PmPcCMt@xps>
References: <bcca8c2455bcc7d91a5720bbc50cfba3e11511fa.1501771894.git.gaetan.rivet@6wind.com>
 <e9354faa7de5fcf5e8fc9606b62c2e64029fecf1.1501772768.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5FEC62C16
 for <dev@dpdk.org>; Thu,  3 Aug 2017 22:35:02 +0200 (CEST)
In-Reply-To: <e9354faa7de5fcf5e8fc9606b62c2e64029fecf1.1501772768.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/08/2017 17:08, Gaetan Rivet:
> When the output of an exec() slave definition is only a single newline
> character, the fail-safe currently fails to parse the device with the
> value returned by the rte_devargs library.
> 
> This behavior is incorrect, because the fail-safe should make a
> difference between the absence of a device, and an erroneous device
> declaration.
> 
> Fix the output sanitization in the case where no newline was at its end
> and detect the special case of an absent device. The correct error code
> is then returned.
> 
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks