From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources Date: Mon, 20 May 2013 22:01:27 +0200 Message-ID: <2346119.JROXYaUvrv@flatron> References: <1368630584-30147-1-git-send-email-t.figa@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-ea0-f174.google.com ([209.85.215.174]:33926 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756835Ab3ETUBb (ORCPT ); Mon, 20 May 2013 16:01:31 -0400 Received: by mail-ea0-f174.google.com with SMTP id z7so4020322eaf.5 for ; Mon, 20 May 2013 13:01:30 -0700 (PDT) In-Reply-To: <1368630584-30147-1-git-send-email-t.figa@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: kgene.kim@samsung.com Cc: Tomasz Figa , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, olof@lixom.net, Kyungmin Park Hi Kukjin, On Wednesday 15 of May 2013 17:09:44 Tomasz Figa wrote: > Since commit 1977e6d8 (drm/exynos: change the method for getting the > interrupt) the Exynos DRM FIMD driver requires IRQ resources to be > named. This patch fixes probe failure in non-DT cases by adding > appropriate resource names to fimd0 platform device. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > arch/arm/plat-samsung/devs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > index 30c2fe2..0f9c3f4 100644 > --- a/arch/arm/plat-samsung/devs.c > +++ b/arch/arm/plat-samsung/devs.c > @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = { > #ifdef CONFIG_S5P_DEV_FIMD0 > static struct resource s5p_fimd0_resource[] = { > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"), > }; > > struct platform_device s5p_device_fimd0 = { This is a fix of a regression introduced to 3.10-rc1. Could you apply this patch to your fixes branch, please? Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Mon, 20 May 2013 22:01:27 +0200 Subject: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources In-Reply-To: <1368630584-30147-1-git-send-email-t.figa@samsung.com> References: <1368630584-30147-1-git-send-email-t.figa@samsung.com> Message-ID: <2346119.JROXYaUvrv@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kukjin, On Wednesday 15 of May 2013 17:09:44 Tomasz Figa wrote: > Since commit 1977e6d8 (drm/exynos: change the method for getting the > interrupt) the Exynos DRM FIMD driver requires IRQ resources to be > named. This patch fixes probe failure in non-DT cases by adding > appropriate resource names to fimd0 platform device. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > arch/arm/plat-samsung/devs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > index 30c2fe2..0f9c3f4 100644 > --- a/arch/arm/plat-samsung/devs.c > +++ b/arch/arm/plat-samsung/devs.c > @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = { > #ifdef CONFIG_S5P_DEV_FIMD0 > static struct resource s5p_fimd0_resource[] = { > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"), > }; > > struct platform_device s5p_device_fimd0 = { This is a fix of a regression introduced to 3.10-rc1. Could you apply this patch to your fixes branch, please? Best regards, Tomasz