From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kbingham@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH 1/4] videodevice: Fix minor spacing
Date: Mon, 18 Dec 2017 13:23:21 +0200 [thread overview]
Message-ID: <2350156.ygCqAgIcf0@avalon> (raw)
In-Reply-To: <494504a89241ba23024e8e125e8d6950fb70a18d.1513206331.git-series.kieran.bingham@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Thursday, 14 December 2017 01:10:09 EET Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Provide a space between the return type and the function definition
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> kms++util/src/videodevice.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kms++util/src/videodevice.cpp b/kms++util/src/videodevice.cpp
> index e21916bcd06b..efe1678d031e 100644
> --- a/kms++util/src/videodevice.cpp
> +++ b/kms++util/src/videodevice.cpp
> @@ -436,7 +436,7 @@ void VideoStreamer::queue(DumbFramebuffer* fb)
> v4l2_queue_dmabuf(m_fd, idx, fb, get_buf_type(m_type));
> }
>
> -DumbFramebuffer*VideoStreamer::dequeue()
> +DumbFramebuffer* VideoStreamer::dequeue()
> {
> uint32_t idx = v4l2_dequeue(m_fd, get_buf_type(m_type));
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-12-18 11:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 23:10 [PATCH 0/4] kms++util: Provide validation helpers Kieran Bingham
2017-12-13 23:10 ` [PATCH 1/4] videodevice: Fix minor spacing Kieran Bingham
2017-12-18 11:23 ` Laurent Pinchart [this message]
2017-12-13 23:10 ` [PATCH 2/4] py: pyvid: Provide stream_off binding Kieran Bingham
2017-12-18 11:29 ` Laurent Pinchart
2017-12-13 23:10 ` [PATCH 3/4] kms++util: Add verification module Kieran Bingham
2017-12-15 13:43 ` Tomi Valkeinen
2017-12-16 16:13 ` Kieran Bingham
2017-12-18 11:36 ` Laurent Pinchart
2017-12-18 11:46 ` Tomi Valkeinen
2017-12-18 11:50 ` Laurent Pinchart
2017-12-18 12:04 ` Tomi Valkeinen
2017-12-18 15:41 ` Laurent Pinchart
2017-12-18 15:48 ` Tomi Valkeinen
2017-12-18 12:06 ` Geert Uytterhoeven
2017-12-18 11:49 ` Tomi Valkeinen
2017-12-13 23:10 ` [PATCH 4/4] kms++util: Add frame compare functionality Kieran Bingham
2017-12-14 8:52 ` Geert Uytterhoeven
2017-12-14 10:28 ` Kieran Bingham
2017-12-15 14:09 ` Tomi Valkeinen
2017-12-16 16:41 ` Kieran Bingham
2017-12-18 11:47 ` Laurent Pinchart
2017-12-13 23:17 ` [PATCH 0/4] kms++util: Provide validation helpers Kieran Bingham
2017-12-15 14:10 ` Tomi Valkeinen
2017-12-16 16:46 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2350156.ygCqAgIcf0@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kbingham@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.