From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Brandt <chris.brandt@renesas.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm: dts: r7s72100: Add peripherals nodes
Date: Tue, 10 Jan 2017 21:58:19 +0200 [thread overview]
Message-ID: <2351875.0S8UmoVGa8@avalon> (raw)
In-Reply-To: <CAMuHMdVWVsHqdOTxeiD6zXaVJqdHPLvry9EjjPc9XvF8QsXkDw@mail.gmail.com>
Hi Geert,
On Tuesday 10 Jan 2017 16:07:01 Geert Uytterhoeven wrote:
> On Mon, Jan 9, 2017 at 8:31 PM, Jacopo Mondi wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > This is a squash of several commits, adding peripherals groups
> > configuration to r7s72100 device tree, and enabling some of them on
> > Genmai evaluation board
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Thanks for the rework!
>
> > arch/arm/boot/dts/r7s72100-genmai.dts | 51 ++++++++++++
> > arch/arm/boot/dts/r7s72100.dtsi | 151 +++++++++++++++++++++++++++++
>
> This path should be split in multiple parts:
> - Add the pfc node to r7s72100.dtsi,
> - Add the gpio nodes to r7s72100.dtsi,
> - 4 patches for r7s72100-genmai.dts, adding support for LEDs, SCIF,
> Ethernet, and SPI.
I can agree about the .dtsi/.dts split, but isn't this going a bit overboard ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-01-10 19:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 19:31 [PATCH 0/3] Renesas RZ PFC and GPIO driver Jacopo Mondi
2017-01-09 19:31 ` [PATCH 1/3] pinctrl: sh-pfc: Add r7s72100 PFC driver Jacopo Mondi
2017-01-10 14:59 ` Geert Uytterhoeven
2017-01-09 19:31 ` [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series Jacopo Mondi
2017-01-11 14:55 ` Linus Walleij
2017-01-12 10:50 ` jacopo mondi
2017-01-12 14:39 ` Chris Brandt
2017-01-12 19:13 ` jacopo mondi
2017-01-12 19:45 ` Chris Brandt
2017-01-09 19:31 ` [PATCH 3/3] arm: dts: r7s72100: Add peripherals nodes Jacopo Mondi
2017-01-10 15:07 ` Geert Uytterhoeven
2017-01-10 19:58 ` Laurent Pinchart [this message]
2017-01-10 21:13 ` Geert Uytterhoeven
2017-01-11 10:33 ` Simon Horman
2017-01-11 10:55 ` Laurent Pinchart
2017-01-11 10:59 ` Simon Horman
2017-01-11 9:17 ` jacopo mondi
2017-01-11 10:56 ` Laurent Pinchart
2017-01-09 19:51 ` [PATCH 0/3] Renesas RZ PFC and GPIO driver Laurent Pinchart
2017-01-09 21:08 ` Chris Brandt
2017-01-09 22:49 ` Laurent Pinchart
2017-01-09 23:53 ` Chris Brandt
2017-01-10 1:28 ` Laurent Pinchart
2017-01-10 3:12 ` Chris Brandt
2017-01-10 22:32 ` jacopo mondi
2017-01-11 0:46 ` Chris Brandt
2017-01-11 10:35 ` Simon Horman
2017-01-11 11:22 ` Laurent Pinchart
2017-01-11 15:15 ` jacopo mondi
2017-01-11 16:31 ` Laurent Pinchart
2017-01-11 17:51 ` jacopo mondi
2017-01-11 20:17 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2351875.0S8UmoVGa8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.