From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Yong Wang <yongwang@vmware.com>,
dev@dpdk.org
Subject: Re: [PATCH] drivers/net: do not redefine bool
Date: Tue, 25 Sep 2018 11:04:17 +0200 [thread overview]
Message-ID: <2353010.843Iz9OGFG@xps> (raw)
In-Reply-To: <840d806c-d75c-f990-5883-1315ea37f95b@intel.com>
25/09/2018 10:03, Ferruh Yigit:
> On 9/24/2018 5:59 PM, Thomas Monjalon wrote:
> >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> >>> struct ixgbe_rx_entry *next_rxe = NULL;
> >>> struct rte_mbuf *first_seg;
> >>> struct rte_mbuf *rxm;
> >>> - struct rte_mbuf *nmb;
> >>> + struct rte_mbuf *nmb = NULL;
> >>
> >> This change is unrelated. Can we separate this one?
> >
> > Yes it looks unrelated but it becomes necessary when including stdbool.h.
> > I don't know the root cause, but yes, it may deserve a separate commit.
> > Maybe an ixgbe maintainer can take care of it?
>
> Why becomes necessary? Does it give a build warning etc?
> My concern is this is in data path, one extra assignment, it would be better to
> confirm it is really needed.
Yes I had a compilation error.
If you cannot reproduce it, I will try to re-run my compilation tests.
next prev parent reply other threads:[~2018-09-25 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 0:18 [PATCH] drivers/net: do not redefine bool Thomas Monjalon
2018-09-20 17:48 ` Shaikh, Shahed
2018-09-21 13:47 ` Ferruh Yigit
2018-09-21 14:49 ` Thomas Monjalon
2018-09-24 14:43 ` Ferruh Yigit
2018-09-24 15:06 ` Ferruh Yigit
2018-09-24 16:59 ` Thomas Monjalon
2018-09-25 8:03 ` Ferruh Yigit
2018-09-25 9:04 ` Thomas Monjalon [this message]
2018-10-03 14:11 ` Ferruh Yigit
2018-10-03 19:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2353010.843Iz9OGFG@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@cavium.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=shahed.shaikh@cavium.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.