From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Markus Niebel" <Markus.Niebel@ew.tq-group.com>,
"Shawn Guo" <shawnguo2@yeah.net>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax
Date: Wed, 19 Jun 2024 13:54:30 +0200 [thread overview]
Message-ID: <2353498.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <Zm1QUUAIB9CuGu9n@dragon>
Hi Shawn,
Am Samstag, 15. Juni 2024, 10:26:57 CEST schrieb Shawn Guo:
> On Mon, May 20, 2024 at 08:02:22AM +0200, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > Use cleaner (and non-deprecated) bindings syntax. See commit
> > bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> > details.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Markus, Alexander
>
> Are you guys good with this change?
Thanks for bringing this up. The MAINTAINERS file still has not been updated
since the arm dts directory split..
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 12 ++++++++----
> > arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 12 ++++++++----
> > 2 files changed, 16 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > index 238f3af42822..807f3c95e3ce 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> > @@ -22,12 +22,16 @@ m24c64_57: eeprom@57 {
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> > - #address-cells = <1>;
> > - #size-cells = <1>;
> > vcc-supply = <®_mba6_3p3v>;
> >
> > - mba_mac_address: mac-address@20 {
> > - reg = <0x20 0x6>;
> > + nvmem-layout {
> > + compatible = "fixed-layout";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> > };
> > };
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > index a587bc88f76f..789733a45b95 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> > @@ -32,12 +32,16 @@ m24c64_57: eeprom@57 {
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> > - #address-cells = <1>;
> > - #size-cells = <1>;
> > vcc-supply = <®_mba6_3p3v>;
> >
> > - mba_mac_address: mac-address@20 {
> > - reg = <0x20 0x6>;
> > + nvmem-layout {
> > + compatible = "fixed-layout";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> > };
> > };
> >
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2024-06-19 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 6:02 [PATCH] ARM: dts: nxp: imx6: convert NVMEM content to layout syntax Rafał Miłecki
2024-05-20 6:02 ` Rafał Miłecki
2024-06-15 8:26 ` Shawn Guo
2024-06-19 11:54 ` Alexander Stein [this message]
2024-06-27 6:11 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2353498.ElGaqSPkdT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo2@yeah.net \
--cc=shawnguo@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.