From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se
Subject: Re: [PATCH v2 7/9] omap3isp: Use a local media device pointer instead
Date: Fri, 09 Dec 2016 17:20:52 +0200 [thread overview]
Message-ID: <23538411.soEARKePUB@avalon> (raw)
In-Reply-To: <1481295222-14743-8-git-send-email-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Friday 09 Dec 2016 16:53:40 Sakari Ailus wrote:
> The function has a local variable that points to the media device; use
> that instead of finding the media device under the entity.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/omap3isp/ispvideo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3isp/ispvideo.c
> b/drivers/media/platform/omap3isp/ispvideo.c index 5b0d16e..25a8210 100644
> --- a/drivers/media/platform/omap3isp/ispvideo.c
> +++ b/drivers/media/platform/omap3isp/ispvideo.c
> @@ -232,7 +232,7 @@ static int isp_video_get_graph_data(struct isp_video
> *video, int ret;
>
> mutex_lock(&mdev->graph_mutex);
> - ret = media_graph_walk_init(&graph, entity->graph_obj.mdev);
> + ret = media_graph_walk_init(&graph, mdev);
> if (ret) {
> mutex_unlock(&mdev->graph_mutex);
> return ret;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-12-09 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 14:53 [PATCH v2] Media pipeline and graph walk cleanups and fixes Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 1/9] media: entity: Fix stream count check Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 2/9] media: entity: Be vocal about failing sanity checks Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 3/9] media: Rename graph and pipeline structs and functions Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 4/9] media: entity: Split graph walk iteration into two functions Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 5/9] media: Use single quotes to quote entity names Sakari Ailus
2016-12-09 15:19 ` Laurent Pinchart
2016-12-09 14:53 ` [PATCH v2 6/9] media: entity: Add debug information to graph walk Sakari Ailus
2016-12-09 14:53 ` [PATCH v2 7/9] omap3isp: Use a local media device pointer instead Sakari Ailus
2016-12-09 15:20 ` Laurent Pinchart [this message]
2016-12-09 14:53 ` [PATCH v2 8/9] xilinx: " Sakari Ailus
2016-12-09 15:21 ` Laurent Pinchart
2016-12-09 14:53 ` [PATCH v2 9/9] davinci: " Sakari Ailus
2016-12-09 15:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23538411.soEARKePUB@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.