From: Thomas Monjalon <thomas@monjalon.net>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
dev@dpdk.org,
"Jack Bond-Preston" <jack.bond-preston@foss.arm.com>,
"Mattias Rönnblom" <hofors@lysator.liu.se>,
stable@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] bitops: improve power of 2 alignment function documentation
Date: Thu, 23 Oct 2025 19:25:58 +0200 [thread overview]
Message-ID: <2357650.d7IHhHJzqS@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FDBF@smartserver.smartshare.dk>
> > > In the documentation, make clear
> > > rte_align(32|64)prevpow2(<n>) -> <n>, provided <n> is a power of 2.
> > >
> > > The original documentation stated the "previous" power of 2 would be
> > > returned, potentially leaving the user to erroneously conclude that,
> > > for example, rte_align32prevpow2(32) -> 16.
> > >
> > > The rte_align(32|64)pow2(<n>) documentation, suffering from a similar
> > > issue, is reworded in the same manner.
> > >
> > > Fixes: 08f683174e94 ("eal: add functions for previous power of 2
> > alignment")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > > ---
> > Much clearer, thanks.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks.
prev parent reply other threads:[~2025-10-23 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:53 [PATCH] bitops: improve power of 2 alignment function documentation Mattias Rönnblom
2025-07-22 8:40 ` Bruce Richardson
2025-07-22 10:29 ` Morten Brørup
2025-10-23 17:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2357650.d7IHhHJzqS@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=jack.bond-preston@foss.arm.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.