From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: rcar-dmac: convert to SPDX identifiers From: Laurent Pinchart Message-Id: <2357768.TA8FcFTrJo@avalon> Date: Tue, 03 Jul 2018 09:25:52 +0300 To: Vinod Cc: Kuninori Morimoto , Geert Uytterhoeven , Dan Williams , Magnus Damm , Linux-Renesas , Kieran Bingham , Geert Uytterhoeven , dmaengine@vger.kernel.org, Hiroki Negishi List-ID: SGkgVmlub2QsCgpPbiBUdWVzZGF5LCAzIEp1bHkgMjAxOCAwOToyMDowOCBFRVNUIFZpbm9kIHdy b3RlOgo+IE9uIDAzLTA3LTE4LCAwODo0OSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEhp IE1vcmltb3RvLXNhbiwKPiA+IAo+ID4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4gPiAKPiA+ IE9uIFR1ZXNkYXksIDMgSnVseSAyMDE4IDAzOjI5OjU5IEVFU1QgS3VuaW5vcmkgTW9yaW1vdG8g d3JvdGU6Cj4gPiA+IEZyb206IEt1bmlub3JpIE1vcmltb3RvIDxrdW5pbm9yaS5tb3JpbW90by5n eEByZW5lc2FzLmNvbT4KPiA+IAo+ID4gQSBjb21taXQgbWVzc2FnZSB3b3VsZCBiZSBuaWNlIDot KQo+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEt1bmlub3JpIE1vcmltb3RvIDxrdW5pbm9yaS5t b3JpbW90by5neEByZW5lc2FzLmNvbT4KPiA+ID4gLS0tCj4gPiA+IAo+ID4gPiAgZHJpdmVycy9k bWEvc2gvcmNhci1kbWFjLmMgfCAxOCArKysrKysrLS0tLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZG1hL3NoL3JjYXItZG1hYy5jIGIvZHJpdmVycy9kbWEvc2gvcmNh ci1kbWFjLmMKPiA+ID4gaW5kZXggNzlkMTRhZi4uMzIyZTU3YiAxMDA2NDQKPiA+ID4gLS0tIGEv ZHJpdmVycy9kbWEvc2gvcmNhci1kbWFjLmMKPiA+ID4gKysrIGIvZHJpdmVycy9kbWEvc2gvcmNh ci1kbWFjLmMKPiA+ID4gQEAgLTEsMTQgKzEsMTAgQEAKPiA+ID4gLS8qCj4gPiA+IC0gKiBSZW5l c2FzIFItQ2FyIEdlbjIgRE1BIENvbnRyb2xsZXIgRHJpdmVyCj4gPiA+IC0gKgo+ID4gPiAtICog Q29weXJpZ2h0IChDKSAyMDE0IFJlbmVzYXMgRWxlY3Ryb25pY3MgSW5jLgo+ID4gPiAtICoKPiA+ ID4gLSAqIEF1dGhvcjogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29u Ym9hcmQuY29tPgo+ID4gPiAtICoKPiA+ID4gLSAqIFRoaXMgaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQo+ID4gPiAtICogaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHZlcnNpb24gMiBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMK PiA+ID4gLSAqIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLgo+ID4g PiAtICovCj4gPiA+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ID4gPiAr Ly8KPiA+ID4gKy8vIFJlbmVzYXMgUi1DYXIgR2VuMiBETUEgQ29udHJvbGxlciBEcml2ZXIKPiA+ ID4gKy8vCj4gPiA+ICsvLyBDb3B5cmlnaHQgKEMpIDIwMTQgUmVuZXNhcyBFbGVjdHJvbmljcyBJ bmMuCj4gPiA+ICsvLwo+ID4gPiArLy8gQXV0aG9yOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+IEkgdGhpbmsgdGhlIHByZWZlcnJl ZCBjb21tZW50IHN0eWxlLCBhY2NvcmRpbmdseSB0byB3aGF0IG90aGVyIGRyaXZlcnMgZG8sCj4g PiBpcwo+ID4gCj4gPiAvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ID4gLyoK PiA+IAo+ID4gICogUmVuZXNhcyBSLUNhciBHZW4yIERNQSBDb250cm9sbGVyIERyaXZlcgo+ID4g ICoKPiA+ICAqIENvcHlyaWdodCAoQykgMjAxNCBSZW5lc2FzIEVsZWN0cm9uaWNzIEluYy4KPiA+ ICAqCj4gPiAgKiBBdXRob3I6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRl YXNvbmJvYXJkLmNvbT4KPiA+ICAqLwo+IAo+IEFuZCBMaW51cyBzYWlkIHRoaXMgaHR0cHM6Ly9s a21sLm9yZy9sa21sLzIwMTcvMTEvMjUvMTMzCj4gCj4gU28gbGV0cyBrZWVwIEM5OSBzdHlsZSBh cyBNb3JpbW90by1TYW4gcHJvcG9zZWQuCj4gCj4gQW5kIGhpZ2ggdGltZSwgdGhpcyBzaG91bGQg YmUgZG9jdW1lbnRlZCA6KQoKQXMgbWVudGlvbmVkIGJlZm9yZSwgd2hpbGUgSSBjZXJ0YWlubHkg cHJlZmVyIHRoZSB0cmFkaXRpb25hbCBDLXN0eWxlIApjb21tZW50cywgSSB1bHRpbWF0ZWx5IGxl dCBkcml2ZXIgYXV0aG9ycyBkZWNpZGUuIFdoYXQgbWF0dGVycyBtb3N0IGluIG15IApvcGluaW9u IGlzIGNvbnNpc3RlbmN5LCBtaXhpbmcgc3R5bGVzIGluIHRoZSBzYW1lIGRyaXZlciBqdXN0IG1h a2VzIHRoZSBjb2RlIApoYXJkZXIgdG8gcmVhZC4KCldoYXQgbWF0dGVycyBpbiB0aGUgZW5kIGlz IGhvdyBlYXN5IHJlYWRpbmcgdGhlIGNvZGUgd2lsbCBiZSwgYW5kIHVudGlsIHRoZSAKbWFqb3Jp dHkgb2Yga2VybmVsIGRldmVsb3BlcnMgZ2V0IHVzZWQgdG8gdGhlIEMrKyBjb21tZW50IHN0eWxl LCBubyBtYXR0ZXIgCndoYXQgTGludXMnIHBlcnNvbmFsIHByZWZlcmVuY2UgaXMsIC8vIHdpbGwg YmUgYW4gYW5ub3lhbmNlLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44552 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932944AbeGCGZY (ORCPT ); Tue, 3 Jul 2018 02:25:24 -0400 From: Laurent Pinchart To: Vinod Cc: Kuninori Morimoto , Geert Uytterhoeven , Dan Williams , Magnus Damm , Linux-Renesas , Kieran Bingham , Geert Uytterhoeven , dmaengine@vger.kernel.org, Hiroki Negishi Subject: Re: [PATCH] dmaengine: rcar-dmac: convert to SPDX identifiers Date: Tue, 03 Jul 2018 09:25:52 +0300 Message-ID: <2357768.TA8FcFTrJo@avalon> In-Reply-To: <20180703062008.GM22377@vkoul-mobl> References: <87601xrwrk.wl-kuninori.morimoto.gx@renesas.com> <1941522.TqLtPnU1Jj@avalon> <20180703062008.GM22377@vkoul-mobl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Vinod, On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote: > On 03-07-18, 08:49, Laurent Pinchart wrote: > > Hi Morimoto-san, > > > > Thank you for the patch. > > > > On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > A commit message would be nice :-) > > > > > Signed-off-by: Kuninori Morimoto > > > --- > > > > > > drivers/dma/sh/rcar-dmac.c | 18 +++++++----------- > > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > > > index 79d14af..322e57b 100644 > > > --- a/drivers/dma/sh/rcar-dmac.c > > > +++ b/drivers/dma/sh/rcar-dmac.c > > > @@ -1,14 +1,10 @@ > > > -/* > > > - * Renesas R-Car Gen2 DMA Controller Driver > > > - * > > > - * Copyright (C) 2014 Renesas Electronics Inc. > > > - * > > > - * Author: Laurent Pinchart > > > - * > > > - * This is free software; you can redistribute it and/or modify > > > - * it under the terms of version 2 of the GNU General Public License as > > > - * published by the Free Software Foundation. > > > - */ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +// > > > +// Renesas R-Car Gen2 DMA Controller Driver > > > +// > > > +// Copyright (C) 2014 Renesas Electronics Inc. > > > +// > > > +// Author: Laurent Pinchart > > > > I think the preferred comment style, accordingly to what other drivers do, > > is > > > > // SPDX-License-Identifier: GPL-2.0 > > /* > > > > * Renesas R-Car Gen2 DMA Controller Driver > > * > > * Copyright (C) 2014 Renesas Electronics Inc. > > * > > * Author: Laurent Pinchart > > */ > > And Linus said this https://lkml.org/lkml/2017/11/25/133 > > So lets keep C99 style as Morimoto-San proposed. > > And high time, this should be documented :) As mentioned before, while I certainly prefer the traditional C-style comments, I ultimately let driver authors decide. What matters most in my opinion is consistency, mixing styles in the same driver just makes the code harder to read. What matters in the end is how easy reading the code will be, and until the majority of kernel developers get used to the C++ comment style, no matter what Linus' personal preference is, // will be an annoyance. -- Regards, Laurent Pinchart