From: Phillip Wood <phillip.wood123@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2024, #01; Tue, 3)
Date: Wed, 4 Sep 2024 14:38:58 +0100 [thread overview]
Message-ID: <23586012-f3d7-43ba-bec3-9e67808fcbd9@gmail.com> (raw)
In-Reply-To: <ZtgBKbEnL8xJBGpE@pks.im>
On 04/09/2024 07:41, Patrick Steinhardt wrote:
> On Tue, Sep 03, 2024 at 04:01:31PM -0700, Junio C Hamano wrote:
>> * ps/clar-unit-test (2024-09-03) 14 commits
>> - clar: add CMake support
>> - t/unit-tests: convert ctype tests to use clar
>> - t/unit-tests: convert strvec tests to use clar
>> - t/unit-tests: implement test driver
>> - Makefile: wire up the clar unit testing framework
>> - Makefile: do not use sparse on third-party sources
>> - Makefile: make hdr-check depend on generated headers
>> - Makefile: fix sparse dependency on GENERATED_H
>> - clar: stop including `shellapi.h` unnecessarily
>> - clar(win32): avoid compile error due to unused `fs_copy()`
>> - clar: avoid compile error with mingw-w64
>> - t/clar: fix compatibility with NonStop
>> - t: import the clar unit testing framework
>> - t: do not pass GIT_TEST_OPTS to unit tests with prove
>>
>> Import clar unit tests framework libgit2 folks invented for our
>> use.
>>
>> Ready?
>> source: <cover.1725349234.git.ps@pks.im>
>
> I'd like to wait for a (hopefully) final review from Phillip before this
> is merged down.
I've just posted a review - it all looks fine apart from the
implementation of "--immediate" flag which we could drop until we have a
better solution (c.f. <e435e05a-376c-4928-9852-6925df855399@gmail.com>).
Best Wishes
Phillip
> Patrick
prev parent reply other threads:[~2024-09-04 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 23:01 What's cooking in git.git (Sep 2024, #01; Tue, 3) Junio C Hamano
2024-09-04 6:41 ` Patrick Steinhardt
2024-09-04 13:38 ` Phillip Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23586012-f3d7-43ba-bec3-9e67808fcbd9@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.