From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, hhaim@cisco.com, matvejchikov@gmail.com,
konstantin.ananyev@intel.com, stable@dpdk.org
Subject: Re: [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt
Date: Fri, 19 Jan 2018 00:23:40 +0100 [thread overview]
Message-ID: <2358946.9nMsedO5u3@xps> (raw)
In-Reply-To: <20171208154651.16546-1-olivier.matz@6wind.com>
08/12/2017 16:46, Olivier Matz:
> When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference
> counter uses an atomic operation. This is not necessary and impacts
> the performance (seen with TRex traffic generator).
>
> We cannot replace rte_atomic16_add_return() by rte_mbuf_refcnt_update()
> because it would add an additional check.
>
> Solves this by introducing __rte_mbuf_refcnt_update(), which
> updates the reference counter without doing anything else.
>
> Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> Suggested-by: Hanoch Haim <hhaim@cisco.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2018-01-18 23:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 9:14 [PATCH v3] mbuf: cleanup rte_pktmbuf_lastseg(), fix atomic usage Hanoh Haim
2017-11-15 11:13 ` Ilya Matveychikov
2017-11-15 12:46 ` Hanoch Haim (hhaim)
2017-11-15 17:30 ` Olivier MATZ
2017-11-16 7:16 ` Hanoch Haim (hhaim)
2017-11-16 8:07 ` Ilya Matveychikov
2017-11-16 8:42 ` Olivier MATZ
2017-11-16 9:06 ` Hanoch Haim (hhaim)
2017-11-16 9:32 ` Ilya Matveychikov
2017-11-16 9:37 ` Olivier MATZ
2017-11-16 9:44 ` Ilya Matveychikov
2017-11-16 10:54 ` Ananyev, Konstantin
2017-12-08 15:46 ` [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt Olivier Matz
2017-12-08 16:04 ` Ilya Matveychikov
2017-12-08 16:19 ` Olivier MATZ
2017-12-08 16:37 ` Stephen Hemminger
2017-12-10 8:37 ` Hanoch Haim (hhaim)
2017-12-11 10:28 ` Olivier MATZ
2018-01-18 23:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2358946.9nMsedO5u3@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hhaim@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=matvejchikov@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.