diff for duplicates of <2359157.SFB7x6fWGY@flatron> diff --git a/a/1.txt b/N1/1.txt index c424545..4210789 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,8 +13,8 @@ On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: > > +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi > > > > +/ { -> > + pinctrl@11400000 { -> > + gpa0: pin-bank@0 { +> > + pinctrl at 11400000 { +> > + gpa0: pin-bank at 0 { > > If you're going to put a unit address ("@0")into the DT node name, the > node should have a reg property containing the same value, and the @@ -22,7 +22,7 @@ On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: > > However, I believe you can actually get unique node names without using > a unit address; instead name the nodes after the object they represent, -> so e.g. s/pin-bank@0/gpa0/ above. +> so e.g. s/pin-bank at 0/gpa0/ above. Good point. I wasn't aware of the relation between unit address and reg property. I thought it was just for readability. @@ -92,7 +92,7 @@ distinguish banks with interrupts from banks without interrupts. Further patches will allow to use it properly (and will add #interrupt- cells property too). -> > + gpd0: pin-bank@5 { +> > + gpd0: pin-bank at 5 { > > + gpio-controller; > > + samsung,pctl-offset = <0x0A0>; > @@ -103,7 +103,7 @@ I have seen both variants, with upper-case being more popular across Samsung's dts files and so I have chosen to use it. (Personally I prefer lower-case, though, if it does matter.) -> > + gpy5: pin-bank@19{ +> > + gpy5: pin-bank at 19{ > > Missing a space before the { there. diff --git a/a/content_digest b/N1/content_digest index ef3d57b..38d1fec 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,10 @@ "ref\01348131197-25506-1-git-send-email-t.figa@samsung.com\0" "ref\01348131197-25506-7-git-send-email-t.figa@samsung.com\0" "ref\0505CB869.5030307@wwwdotorg.org\0" - "From\0Tomasz Figa <tomasz.figa@gmail.com>\0" - "Subject\0Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers\0" + "From\0tomasz.figa@gmail.com (Tomasz Figa)\0" + "Subject\0[RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers\0" "Date\0Fri, 21 Sep 2012 21:54:43 +0200\0" - "To\0Stephen Warren <swarren@wwwdotorg.org>\0" - "Cc\0Tomasz Figa <t.figa@samsung.com>" - linux-arm-kernel@lists.infradead.org - kgene.kim@samsung.com - devicetree-discuss@lists.ozlabs.org - kyungmin.park@samsung.com - linux-samsung-soc@vger.kernel.org - thomas.abraham@linaro.org - linus.walleij@linaro.org - " m.szyprowski@samsung.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Stephen,\n" @@ -31,8 +22,8 @@ "> > +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi\n" "> > \n" "> > +/ {\n" - "> > +\tpinctrl@11400000 {\n" - "> > +\t\tgpa0: pin-bank@0 {\n" + "> > +\tpinctrl at 11400000 {\n" + "> > +\t\tgpa0: pin-bank at 0 {\n" "> \n" "> If you're going to put a unit address (\"@0\")into the DT node name, the\n" "> node should have a reg property containing the same value, and the\n" @@ -40,7 +31,7 @@ "> \n" "> However, I believe you can actually get unique node names without using\n" "> a unit address; instead name the nodes after the object they represent,\n" - "> so e.g. s/pin-bank@0/gpa0/ above.\n" + "> so e.g. s/pin-bank at 0/gpa0/ above.\n" "\n" "Good point. I wasn't aware of the relation between unit address and reg \n" "property. I thought it was just for readability.\n" @@ -110,7 +101,7 @@ "Further patches will allow to use it properly (and will add #interrupt-\n" "cells property too).\n" "\n" - "> > +\t\tgpd0: pin-bank@5 {\n" + "> > +\t\tgpd0: pin-bank at 5 {\n" "> > +\t\t\tgpio-controller;\n" "> > +\t\t\tsamsung,pctl-offset = <0x0A0>;\n" "> \n" @@ -121,7 +112,7 @@ "Samsung's dts files and so I have chosen to use it. (Personally I prefer \n" "lower-case, though, if it does matter.)\n" "\n" - "> > +\t\tgpy5: pin-bank@19{\n" + "> > +\t\tgpy5: pin-bank at 19{\n" "> \n" "> Missing a space before the { there.\n" "\n" @@ -170,4 +161,4 @@ "Best regards,\n" Tomasz Figa -01879ec4e32b90dd0ec58c5e9fc6dd591cec4078dc5e9985089cfb62931682b5 +a2c71eb721adcea558a102398301cb137a0910f647c903a8d9755547a6cf2552
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.