From: David Ahern <dsahern@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>, David Ahern <dsahern@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm
Date: Thu, 16 May 2019 11:53:55 -0600 [thread overview]
Message-ID: <235d1405-dddd-8fac-64d9-dadec78e4570@gmail.com> (raw)
In-Reply-To: <20190516195140.158e602f@redhat.com>
On 5/16/19 11:51 AM, Stefano Brivio wrote:
> On Thu, 16 May 2019 10:41:31 -0700
> David Ahern <dsahern@kernel.org> wrote:
>
>> From: David Ahern <dsahern@gmail.com>
>>
>> The first command in setup_xfrm is failing resulting in the test getting
>> skipped:
>>
>> + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
>> + out=RTNETLINK answers: Function not implemented
>
> Thanks for fixing this, I ran into this issue right today and I was
> about to send a patch too. For the record, the quotes went all the way
> into xfrm_alg_name_match():
>
> name: 'rfc4106(gcm(aes))'
> entry->name: rfc4106(gcm(aes))
>
> My solution was to remove the single quotes around 'rfc4106(gcm(aes))',
> but I just checked yours and it also works on bash and dash, so I don't
> really have a preference.
>
None of the other commands have the "" with run_cmd. Not sure why I did
not remove the quotes from the xfrm commands.
next prev parent reply other threads:[~2019-05-16 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 17:41 [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup_xfrm David Ahern
2019-05-16 17:51 ` Stefano Brivio
2019-05-16 17:53 ` David Ahern [this message]
2019-05-16 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235d1405-dddd-8fac-64d9-dadec78e4570@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.