From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 1/2] eal: rename IPC sync request to
	pending request
Date: Wed, 28 Mar 2018 12:08:29 +0200
Message-ID: <2360089.qufSKTD6lu@xps>
References: <338e432277f98a206df87e7808ec799de28535ce.1521895541.git.anatoly.burakov@intel.com>
 <2165690.q5cnMgZWhB@xps> <2dc81fb9-5926-f595-27fc-1eee07d6e21b@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jianfeng.tan@intel.com, konstantin.ananyev@intel.com
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id DF4B02A62
 for <dev@dpdk.org>; Wed, 28 Mar 2018 12:08:49 +0200 (CEST)
In-Reply-To: <2dc81fb9-5926-f595-27fc-1eee07d6e21b@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/03/2018 11:15, Burakov, Anatoly:
> On 27-Mar-18 5:27 PM, Thomas Monjalon wrote:
> > 27/03/2018 15:59, Anatoly Burakov:
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> Suggested-by: Jianfeng Tan <jianfeng.tan@intel.com>
> >> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
> > 
> > You probably have a good explanation for this change.
> > Please explain in the commit message.
> > 
> > Generally speaking, every commits should have an explanation,
> > it is a basic quality rule.
> > Thanks
> > 
> 
> This is just to reduce noise in the following patch.

No Anatoly, you should explain why a rename is needed.