From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F715606A32E for ; Sun, 1 Nov 2026 20:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OoS7HKXX; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=20rNYJKo DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=xEsAInC8FhPuwnF/AOASc54OazYNTUCxmlMSjiSDEh8=; b=OoS7HKXXRX4WqH3GDiQB5brEKR ZQjuJhf9wPnCr80aYMR9unGhr2LzF2kDrQsp8mZsYNozFPqPeWvCY3J+N1DxVr8GYwFMDsELBaSvs baQSRillL0Qg9FicylEt9K5cMozC/Zu5Ar3jgRADJGUKhfFU6WXlqtiRAkUkWyp42QkF2v1rF5rlK IPrxKWAp1eG3hWInA7OhJLEqMEGDwmcOwFta5hGiAoZP3z0GIeM7O+QnD/hQjJDGHUBhHNV8UfbSE WRTSirGkX0MJPDoPJGkqjbpSFS7yNaxghRaOL3eo5ZhaohCYIGcoih+RdIQU0A3lu2mpbsAYQSPEX bmXX115A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNc1o-0000000Es7f-3tug; Sun, 01 Nov 2026 20:19:44 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNc1m-0000000Es7C-2iNP; Sun, 01 Nov 2026 20:19:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=nbWzpEen76KfcL+CtXPbSjVeFwZsdAxBkZAu3PHXVRY=; b=20rNYJKowS8QgUWQ4jODdI+Rso vpy8xoxE5/YhQST3EwqyZxQNmAV03Y5o751usgC31Yc/McSk1TOqOl3zTIEtG/Tj6ZNluFes8ihJp +X13l9D3X4pnJOeyY2ekAMmWEDtrZSMUZ8LP3lJzUj7Lu1F6xYTU5pAYBiiJK0jUrI9hRxttmqeV0 Upd10k0OsFPkI6kQGZjcz3bMChwkDKqtnvkeXN0sYn6goMIBQDkrUfV9dFr7bcLRDR225P4brDNnU UZhNWMWPmvq/HDXj1olPKXAI2ZcmO3wnp6wRkxfXQpLJhBxOxhPTB95rlPaSeerNlr2/rBXJMkQDh +jFRBS9Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Coia Prant Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Lin , David Heidelberg , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 1/3] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes Date: Sun, 01 Nov 2026 21:19:33 +0100 Message-ID: <23607754.hxa6pUQ8Du@diego> In-Reply-To: References: <20261023053548.1595033-1-coiaprant@gmail.com> <2977688.AiC22s8V5E@phil> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261101_121942_769607_7441D1EF X-CRM114-Status: GOOD ( 30.83 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gU29ubnRhZywgMS4gTm92ZW1iZXIgMjAyNiwgMjE6MTE6NTYgTWl0dGVsZXVyb3DDpGlzY2hl IE5vcm1hbHplaXQgc2NocmllYiBDb2lhIFByYW50Ogo+IEhlaWtvIFN0dWVibmVyIDxoZWlrb0Bz bnRlY2guZGU+IOS6jjIwMjblubQxMeaciDHml6Xlkajml6UgMjI6MDblhpnpgZPvvJoKPiA+Cj4g PiBIaSwKPiA+Cj4gPiBBbSBGcmVpdGFnLCAyMy4gT2t0b2JlciAyMDI2LCAwNzozNTo0NiBNaXR0 ZWxldXJvcMOkaXNjaGUgTm9ybWFsemVpdCBzY2hyaWViIENvaWEgUHJhbnQ6Cj4gPiA+IFRoZSBS SzM1NjggU29DIGludGVncmF0ZXMgYSBTeW5vcHN5cyBEZXNpZ25XYXJlIFhQQ1MgdGhhdCBwcm92 aWRlcwo+ID4gPiB0aGUgUGh5c2ljYWwgQ29kaW5nIFN1YmxheWVyIGZvciAxMDAwQkFTRS1YLCBT R01JSSwgYW5kIFFTR01JSQo+ID4gPiBpbnRlcmZhY2VzIHZpYSBpdHMgZm91ciBNSUkgcG9ydHMu ICBBZGQgdGhlIFhQQ1MgZGV2aWNlIG5vZGUgdG8gdGhlCj4gPiA+IFNvQyBkZXZpY2UgdHJlZS4K PiA+ID4KPiA+ID4gVGhlIFhQQ1MgZGV2aWNlIGlzIGFjY2Vzc2VkIHZpYSB0aGUgQVBCMyBidXMg YXQgMHhmZGEwMDAwMCBhbmQKPiA+ID4gcmVxdWlyZXMgdGhlIENTUiBjbG9jayAoUENMS19YUENT KSBmb3IgcmVnaXN0ZXIgYWNjZXNzIGFuZCB0aGUgRUVFCj4gPiA+IGNsb2NrIChDTEtfWFBDU19F RUUpIGZvciBFbmVyZ3kgRWZmaWNpZW50IEV0aGVybmV0IG9wZXJhdGlvbi4gIFRoZQo+ID4gPiBQ RF9QSVBFIHBvd2VyIGRvbWFpbiBtdXN0IGJlIGVuYWJsZWQgYmVmb3JlIGFueSByZWdpc3RlciBh Y2Nlc3MuCj4gPiA+Cj4gPiA+IEFsc28gYWRkIHR3byBmaXhlZC1jbG9jayBub2RlcyAoY2xvY2st eHBjcy1nbWFjMCBhbmQgY2xvY2steHBjcy1nbWFjMSwKPiA+ID4gbGFiZWxsZWQgY2xrX2dtYWMw X3hwY3NfbWlpIGFuZCBjbGtfZ21hYzFfeHBjc19taWkpIHByb3ZpZGluZyB0aGUKPiA+ID4gMTI1 IE1IeiByZWZlcmVuY2UgY2xvY2sgZm9yIHRoZSBHTUFDcyB3aGVuIG9wZXJhdGluZyB3aXRoIFhQ Q1MuICBUaGVpcgo+ID4gPiBjbG9jay1vdXRwdXQtbmFtZXMgbWF0Y2ggdGhlIENSVSBtdXggcGFy ZW50IG5hbWVzIGluIGNsay1yazM1NjguYywgc28KPiA+ID4gYm9hcmRzIGNhbiByZXBhcmVudCBT Q0xLX0dNQUMwX1JYX1RYIC8gU0NMS19HTUFDMV9SWF9UWCB0aHJvdWdoCj4gPiA+IGFzc2lnbmVk LWNsb2NrLXBhcmVudHMuCj4gPiA+Cj4gPiA+IFRoZSBYUENTIG5vZGUgaXMgZGlzYWJsZWQgYnkg ZGVmYXVsdCBhbmQgbXVzdCBiZSBlbmFibGVkIGF0IHRoZSBib2FyZAo+ID4gPiBsZXZlbCB3aGVu IDEwMDBCQVNFLVgvU0dNSUkvUVNHTUlJIGlzIGluIHVzZS4gIFRoZSBmaXhlZC1jbG9jayBub2Rl cwo+ID4gPiBhcmUgYWx3YXlzIHByZXNlbnQgYW5kIGRvIG5vdCBoYXZlIGEgc3RhdHVzIHByb3Bl cnR5LCBhcyB0aGV5IGFyZQo+ID4gPiBzdGF0aWMgY2xvY2sgc291cmNlcy4KPiA+ID4KPiA+ID4g VGhlIFhQQ1Mgbm9kZSByZXF1aXJlcyBhIHJlZmVyZW5jZSB0byB0aGUgYXBwcm9wcmlhdGUgTmFu ZW5nIENvbWJvIFBIWQo+ID4gPiB2aWEgdGhlIHBoeXMgcHJvcGVydHkuICBkdGJzX2NoZWNrIG9u bHkgdmFsaWRhdGVzIHJlcXVpcmVkIHByb3BlcnRpZXMKPiA+ID4gZm9yIGVuYWJsZWQgbm9kZXMs IHNvIHRoZSBTb0MgZHRzaSBkb2VzIG5vdCBwcm92aWRlIHBoeXM6IGJvYXJkcyB0aGF0Cj4gPiA+ IGVuYWJsZSB0aGUgWFBDUyBtdXN0IHN1cHBseSBpdCwgc2luY2UgdGhlIFNlckRlcyBsaW5rIGlz IGEgYm9hcmQtbGV2ZWwKPiA+ID4gZGVzaWduIGNob2ljZSAoY29tYnBoeTEgb24gc29tZSBib2Fy ZHMsIGNvbWJwaHkyIG9uIG90aGVycykuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IENvaWEg UHJhbnQgPGNvaWFwcmFudEBnbWFpbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9hcm02NC9i b290L2R0cy9yb2NrY2hpcC9yazM1NjguZHRzaSB8IDIzICsrKysrKysrKysrKysrKysrKysrKysr Cj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKQo+ID4gPgo+ID4gPiBkaWZm IC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjguZHRzaSBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LmR0c2kKPiA+ID4gaW5kZXggM2JjNjUzZjAy N2YxZi4uMjBhNzI3ODVhZGJjMiAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9yazM1NjguZHRzaQo+ID4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzU2OC5kdHNpCj4gPiA+IEBAIC04LDYgKzgsMjAgQEAKPiA+ID4gIC8gewo+ID4g PiAgICAgICBjb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzU2OCI7Cj4gPiA+Cj4gPiA+ICsgICAg IGNsa19nbWFjMF94cGNzX21paTogY2xvY2steHBjcy1nbWFjMCB7Cj4gPiA+ICsgICAgICAgICAg ICAgY29tcGF0aWJsZSA9ICJmaXhlZC1jbG9jayI7Cj4gPiA+ICsgICAgICAgICAgICAgY2xvY2st ZnJlcXVlbmN5ID0gPDEyNTAwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgY2xvY2stb3V0cHV0 LW5hbWVzID0gImNsa19nbWFjMF94cGNzX21paSI7Cj4gPiA+ICsgICAgICAgICAgICAgI2Nsb2Nr LWNlbGxzID0gPDA+Owo+ID4gPiArICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgIGNsa19nbWFj MV94cGNzX21paTogY2xvY2steHBjcy1nbWFjMSB7Cj4gPiA+ICsgICAgICAgICAgICAgY29tcGF0 aWJsZSA9ICJmaXhlZC1jbG9jayI7Cj4gPiA+ICsgICAgICAgICAgICAgY2xvY2stZnJlcXVlbmN5 ID0gPDEyNTAwMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgY2xvY2stb3V0cHV0LW5hbWVzID0g ImNsa19nbWFjMV94cGNzX21paSI7Cj4gPiA+ICsgICAgICAgICAgICAgI2Nsb2NrLWNlbGxzID0g PDA+Owo+ID4gPiArICAgICB9Owo+ID4gPiArCj4gPgo+ID4gdGhlc2UgY2xvY2tzIGRvbid0IGJl bG9uZyBoZXJlLgo+ID4KPiA+IFdoZW4geW91IHBsYWNlIHRoZXNlIG5vZGVzIGluIHRoZSBtYWlu LCB0aGV5IHNlZW0gdG8gY29tZSBvdXQgb2YKPiA+IHRoaW4gYWlyLCB3aGlsZSB0aGF0IG1pZ2h0 IGJlIHRydWUgZm9yIHNvbWUgYm9hcmRzLCB0aGF0IHRoZXkKPiA+IGhhdmUgZGVkaWNhdGVkIG9z Y2lsbGF0b3JzIGZvciB0aGF0LCB0aGlzIHdpbGwgbGlrZWx5IG5vdCBiZSB0cnVlCj4gPiBmb3Ig YWxsLgo+ID4KPiA+IFNvIHRoZXNlIHNob3VsZCBiZSBkZWZpbmVkIGluIHRoZSBib2FyZCBkdHMs IHRvIG1hdGNoIHRoZSBhY3R1YWwKPiA+IGhhcmR3YXJlLgo+ID4KPiA+Cj4gPiBIZWlrbwo+ID4K PiAKPiBIaSBIZWlrbywKPiAKPiBPa2F5LCB0aGVzZSBhcmUgYm9hcmQtbGV2ZWwgY2xvY2sgc291 cmNlcywgbm90IHNvbWV0aGluZyB0aGUgU29DCj4gcHJvdmlkZXMuIE1vdmluZyBib3RoIGZpeGVk LWNsb2NrIG5vZGVzIHRvIHRoZSBQaG90b25pY2F0IERUUyBhbmQKPiBsZWF2aW5nIG9ubHkgdGhl IHhwY3Mgbm9kZSBpbiByazM1NjguZHRzaS4KPiAKPiBJJ2xsIHJlc3Bpbi4KCnBsZWFzZSBhbHNv IGF0IGxlYXN0IGRlc2NyaWJlIGluIHRoZSBjb21taXQgbWVzc2FnZSwgd2hlcmUgdGhlCmJvYXJk IGdlbmVyYXRlcyB0aGVzZSBjbG9ja3MuCgpUaGFua3MKSGVpa28KCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBs aXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AFA606A32F for ; Sun, 1 Nov 2026 20:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ynh22KaY; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=20rNYJKo DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=nbWzpEen76KfcL+CtXPbSjVeFwZsdAxBkZAu3PHXVRY=; b=Ynh22KaYrVwSx+fU4/Wgy/7r0E WLs62WexBOAiP5kIP5xCuImerqb0voR5rRtDoX7PrijJod/U+ZnKxGEqcMCA/FYR8q8wFg/qiD3ww Cy6tqFQq1r1GT8Rz31PA0FWyfCutdI+MwRkCL1574SnZVOHlWfcINsWh8KliO2ND50xqcfSoymgZZ Vt3gQUngCs/EWkGHev0ihbS0yV8k9+CbNcyQZNkn1+tpJsLLm5xjKCaEulH3VeTO9KfQ/rOYS4hfu zBPtpaa9/cJXLRi3PyfVqiO66DkYK4rW+L8H9LG99nMAkgepzJs6XkS14TjN/ukqQWbBCrE9vdVY2 zN40mvLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNc1o-0000000Es7b-3W1T; Sun, 01 Nov 2026 20:19:44 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNc1m-0000000Es7C-2iNP; Sun, 01 Nov 2026 20:19:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=nbWzpEen76KfcL+CtXPbSjVeFwZsdAxBkZAu3PHXVRY=; b=20rNYJKowS8QgUWQ4jODdI+Rso vpy8xoxE5/YhQST3EwqyZxQNmAV03Y5o751usgC31Yc/McSk1TOqOl3zTIEtG/Tj6ZNluFes8ihJp +X13l9D3X4pnJOeyY2ekAMmWEDtrZSMUZ8LP3lJzUj7Lu1F6xYTU5pAYBiiJK0jUrI9hRxttmqeV0 Upd10k0OsFPkI6kQGZjcz3bMChwkDKqtnvkeXN0sYn6goMIBQDkrUfV9dFr7bcLRDR225P4brDNnU UZhNWMWPmvq/HDXj1olPKXAI2ZcmO3wnp6wRkxfXQpLJhBxOxhPTB95rlPaSeerNlr2/rBXJMkQDh +jFRBS9Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Coia Prant Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Lin , David Heidelberg , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 1/3] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes Date: Sun, 01 Nov 2026 21:19:33 +0100 Message-ID: <23607754.hxa6pUQ8Du@diego> In-Reply-To: References: <20261023053548.1595033-1-coiaprant@gmail.com> <2977688.AiC22s8V5E@phil> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261101_121942_769607_7441D1EF X-CRM114-Status: GOOD ( 30.83 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Am Sonntag, 1. November 2026, 21:11:56 Mitteleurop=C3=A4ische Normalzeit sc= hrieb Coia Prant: > Heiko Stuebner =E4=BA=8E2026=E5=B9=B411=E6=9C=881=E6=97= =A5=E5=91=A8=E6=97=A5 22:06=E5=86=99=E9=81=93=EF=BC=9A > > > > Hi, > > > > Am Freitag, 23. Oktober 2026, 07:35:46 Mitteleurop=C3=A4ische Normalzei= t schrieb Coia Prant: > > > The RK3568 SoC integrates a Synopsys DesignWare XPCS that provides > > > the Physical Coding Sublayer for 1000BASE-X, SGMII, and QSGMII > > > interfaces via its four MII ports. Add the XPCS device node to the > > > SoC device tree. > > > > > > The XPCS device is accessed via the APB3 bus at 0xfda00000 and > > > requires the CSR clock (PCLK_XPCS) for register access and the EEE > > > clock (CLK_XPCS_EEE) for Energy Efficient Ethernet operation. The > > > PD_PIPE power domain must be enabled before any register access. > > > > > > Also add two fixed-clock nodes (clock-xpcs-gmac0 and clock-xpcs-gmac1, > > > labelled clk_gmac0_xpcs_mii and clk_gmac1_xpcs_mii) providing the > > > 125 MHz reference clock for the GMACs when operating with XPCS. Their > > > clock-output-names match the CRU mux parent names in clk-rk3568.c, so > > > boards can reparent SCLK_GMAC0_RX_TX / SCLK_GMAC1_RX_TX through > > > assigned-clock-parents. > > > > > > The XPCS node is disabled by default and must be enabled at the board > > > level when 1000BASE-X/SGMII/QSGMII is in use. The fixed-clock nodes > > > are always present and do not have a status property, as they are > > > static clock sources. > > > > > > The XPCS node requires a reference to the appropriate Naneng Combo PHY > > > via the phys property. dtbs_check only validates required properties > > > for enabled nodes, so the SoC dtsi does not provide phys: boards that > > > enable the XPCS must supply it, since the SerDes link is a board-level > > > design choice (combphy1 on some boards, combphy2 on others). > > > > > > Signed-off-by: Coia Prant > > > --- > > > arch/arm64/boot/dts/rockchip/rk3568.dtsi | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/bo= ot/dts/rockchip/rk3568.dtsi > > > index 3bc653f027f1f..20a72785adbc2 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > > > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > > > @@ -8,6 +8,20 @@ > > > / { > > > compatible =3D "rockchip,rk3568"; > > > > > > + clk_gmac0_xpcs_mii: clock-xpcs-gmac0 { > > > + compatible =3D "fixed-clock"; > > > + clock-frequency =3D <125000000>; > > > + clock-output-names =3D "clk_gmac0_xpcs_mii"; > > > + #clock-cells =3D <0>; > > > + }; > > > + > > > + clk_gmac1_xpcs_mii: clock-xpcs-gmac1 { > > > + compatible =3D "fixed-clock"; > > > + clock-frequency =3D <125000000>; > > > + clock-output-names =3D "clk_gmac1_xpcs_mii"; > > > + #clock-cells =3D <0>; > > > + }; > > > + > > > > these clocks don't belong here. > > > > When you place these nodes in the main, they seem to come out of > > thin air, while that might be true for some boards, that they > > have dedicated oscillators for that, this will likely not be true > > for all. > > > > So these should be defined in the board dts, to match the actual > > hardware. > > > > > > Heiko > > >=20 > Hi Heiko, >=20 > Okay, these are board-level clock sources, not something the SoC > provides. Moving both fixed-clock nodes to the Photonicat DTS and > leaving only the xpcs node in rk3568.dtsi. >=20 > I'll respin. please also at least describe in the commit message, where the board generates these clocks. Thanks Heiko