From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fix menu size calculation in presence of selected item pixmap
Date: Tue, 09 Apr 2013 13:08:16 +0400 [thread overview]
Message-ID: <2360845.vp9XZQrH5p@icedphoenix> (raw)
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
>I don't see the logic behind this. item_top in draw_menu doesn't
>increase more on selected item than on any other one.
Current function does not take into account pixmap style of the selected item.
This pixmap style needs for additional space to be drawn.
Overall height of the selected item is:
sel_top_pad + sel_bottom_pad + item_height - 1
So the number of shown items is miscalculated.
And in some cases we will have the bottom item not fully drawn. I can sent a screenshot.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
[-- Attachment #2: Type: text/html, Size: 3665 bytes --]
next reply other threads:[~2013-04-09 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:08 Vladimir Testov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-21 17:36 [PATCH] fix menu size calculation in presence of selected item pixmap Andrey Borzenkov
2013-04-08 18:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-09 15:54 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2360845.vp9XZQrH5p@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.