From: Thomas Monjalon <thomas@monjalon.net>
To: talshn@mellanox.com, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, david.marchand@redhat.com,
grive@u256.net, ranjit.menon@intel.com,
navasile@linux.microsoft.com, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers
Date: Sun, 10 May 2020 11:52:05 +0200 [thread overview]
Message-ID: <2362361.TLnPLrj5Ze@thomas> (raw)
In-Reply-To: <20200508015004.2510c9e7@Sovereign>
08/05/2020 00:50, Dmitry Kozlyuk:
> On 2020-05-07 15:16 GMT+0300 talshn@mellanox.com wrote:
> > +static
> > +int get_device_pci_address(HDEVINFO hDevInfo,
> > + PSP_DEVINFO_DATA pDeviceInfoData, struct rte_pci_addr *addr)
>
> Result type should be on a separate line (that is, "static int <line break>").
>
> This is also the first from numerous violations of DPDK naming conventions.
> IMO, Windows EAL should strictly follow them to become "a first-class citizen"
> in DPDK and to attract existing developers. Even if not, style should be at
> least consistent across each file (now we have snake_case, Hungarian
> notation, camelCase, and PascalCase mixed).
I agree, snake_case must be used for all variables.
prev parent reply other threads:[~2020-05-10 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 12:16 [dpdk-dev] [PATCH v3 0/7] Windows bus/pci support talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 1/7] eal: move OS common functions to single file talshn
2020-05-07 23:26 ` Dmitry Kozlyuk
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 2/7] pci: use OS generic memory mapping functions talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 3/7] pci: build on Windows talshn
2020-05-07 23:27 ` Dmitry Kozlyuk
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 5/7] drivers: fix incorrect meson import folder " talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 6/7] bus/pci: introduce Windows support with stubs talshn
2020-05-07 12:16 ` [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-05-07 22:50 ` Dmitry Kozlyuk
2020-05-07 23:06 ` Dmitry Kozlyuk
2020-05-10 9:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2362361.TLnPLrj5Ze@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=grive@u256.net \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.