From: Auke Kok <sofar@foo-projects.org>
To: Amit K Arora <aarora@in.ibm.com>
Cc: netdev@vger.kernel.org, auke-jan.h.kok@intel.com, sofar@foo-projects.org
Subject: Re: DPRINTKs in e1000 code (2.6.x kernels)
Date: Wed, 31 May 2006 23:30:23 +0000 [thread overview]
Message-ID: <23630a870399173fdc21603d9300d905@localhost> (raw)
In-Reply-To: <447D5B51.7030100@in.ibm.com>
On Wed, 31 May 2006 14:31:05 +0530, Amit K Arora <aarora@in.ibm.com> wrote:
> Hello,
>
> I am wondering why this patch "e1000: Remove PM warning DPRINTKs
> breaking 2.4.x kernels"
> (http://www.mail-archive.com/netdev@vger.kernel.org/msg10803.html) was
> meant only for 2.4 kernels, and _not_ for 2.6 kernels.
this code was removed from our generic driver first which is available for 2.4 kernels as well. we try to keep the in-kernel 2.4 and 2.6-driver as close to the general module because we spend a lot of time testing that particular driver.
The removal from the 2.6 kernel has two motivations:
- sync with the standalone tarball driver on e1000.sf.net
- pci subsystem smartness should take care of warning on those operations
> These DPRINTKs in e1000_suspend() are currently resulting in following
> messages while rebooting a system (2.6 kernel) which has e1000 adapter:
>
> Shutting down MD Raid
> done
> Stopping udevd:
> done
> proc umounted
> The system will be halted immediately.
> md: stopping all md devices.
> e1000: eth3: e1000_suspend: Error enabling D3 wake <<==
> e1000: eth3: e1000_suspend: Error enabling D3 cold wake <<==
> Power down.
>
>
> Should these DPRINTKs be removed from the 2.6.x e1000 code as well ?
they already are. the patch was merged in 7.0.38-k2 or so which is over a month ago.
Also, if you are getting these errors there are several fixes in 7.0.38+ in the kernel that might be related. especially the WoL fix that re-enables the shutdown handler correctly might fix this issue for you. Please give this kernel/module a try (see http://www.mail-archive.com/netdev@vger.kernel.org/msg12689.html).
Cheers,
Auke
next prev parent reply other threads:[~2006-05-31 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 9:01 DPRINTKs in e1000 code (2.6.x kernels) Amit K Arora
2006-05-31 23:30 ` Auke Kok [this message]
2006-06-01 21:57 ` Amit Arora
2006-06-01 22:08 ` Auke Kok
2006-06-01 22:22 ` Auke Kok
2006-06-01 10:04 ` Amit K Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23630a870399173fdc21603d9300d905@localhost \
--to=sofar@foo-projects.org \
--cc=aarora@in.ibm.com \
--cc=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.