Re: [Outreachy kernel] [PATCH] staging: wlan-ng: correct formatting in cfg80211.c

["Fabio M. De Francesco" <fmdefrancesco@gmail.com>]

On Monday, April 5, 2021 2:10:50 PM CEST Julia Lawall wrote:
> 
> On Mon, 5 Apr 2021, Fabio M. De Francesco wrote:
> 
> > According to checkpatch message "CHECK: Lines should not end with a
> > '('", fix formatting in cfg80211.c
> 
> I'm not sure it's worth exceeding 80 characters in this way.
> 
> julia

Thanks, Julia. Now I understand that exceeding 80 characters is only allowed where it is strictly necessary (and those lines are not).

Fabio

> 
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/cfg80211.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> > index 759e475e303c..eda5b5a4e089 100644
> > --- a/drivers/staging/wlan-ng/cfg80211.c
> > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > @@ -324,8 +324,7 @@ static int prism2_scan(struct wiphy *wiphy,
> >  		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
> >  		i++)
> >  		msg1.channellist.data.data[i] =
> > -			ieee80211_frequency_to_channel(
> > -				request->channels[i]->center_freq);
> > +			ieee80211_frequency_to_channel(request->channels[i]->center_freq);
> >  	msg1.channellist.data.len = request->n_channels;
> >
> >  	msg1.maxchanneltime.data = 250;
> > @@ -478,8 +477,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
> >  				goto exit;
> >
> >  			/* send key to driver */
> > -			did = didmib_dot11smt_wepdefaultkeystable_key(
> > -					sme->key_idx + 1);
> > +			did = didmib_dot11smt_wepdefaultkeystable_key(sme->key_idx + 1);
> >  			result = prism2_domibset_pstr32(wlandev,
> >  							did, sme->key_len,
> >  							(u8 *)sme->key);
> > --
> > 2.30.2
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210405120349.12338-1-fmdefrancesco%40gmail.com.
> >
>