From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 1/6] Staging: rtl8192u: Remove TRUE and FALSE macros
Date: Tue, 24 Feb 2015 20:03:45 +0100 [thread overview]
Message-ID: <23670050.lCeLkYodT8@wuerfel> (raw)
In-Reply-To: <f286a0fed29701378cab40c60e1b2d72d5dae827.1424798953.git.ksenija.stanojevic@gmail.com>
On Tuesday 24 February 2015 18:30:30 Ksenija Stanojevic wrote:
> Remove TRUE and FALSE boolean macros, since Linux kernel has already a
> boolean type, bool, defined in linux/stddef.h
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> index c9d8c10..6c2e438 100644
> --- a/drivers/staging/rtl8192u/r8192U.h
> +++ b/drivers/staging/rtl8192u/r8192U.h
> @@ -40,8 +40,6 @@
> #define RTL8192U
> #define RTL819xU_MODULE_NAME "rtl819xU"
> /* HW security */
> -#define FALSE 0
> -#define TRUE 1
> #define MAX_KEY_LEN 61
> #define KEY_BUF_SIZE 5
The patches in this series all look good to me, but the order is wrong:
You should first change all users of the macro and remove it in the final
patch. Alternatively you could submit a single larger patch to do it
all at once. There is not really a reason to split it up by file if
all the changes are for the same driver and are completely trivial.
Arnd
next prev parent reply other threads:[~2015-02-24 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1424798953.git.ksenija.stanojevic@gmail.com>
2015-02-24 17:30 ` [PATCH 1/6] Staging: rtl8192u: Remove TRUE and FALSE macros Ksenija Stanojevic
2015-02-24 19:03 ` Arnd Bergmann [this message]
2015-02-24 19:07 ` [Outreachy kernel] " Ksenija Stanojević
2015-02-24 19:29 ` Julia Lawall
2015-02-24 19:32 ` Ksenija Stanojević
2015-02-24 17:31 ` [PATCH 2/6] Staging: rtl8192u: Replace TRUE with true Ksenija Stanojevic
2015-02-24 19:33 ` [Outreachy kernel] " Julia Lawall
2015-02-24 19:48 ` Ksenija Stanojević
2015-02-24 19:51 ` Julia Lawall
2015-02-24 17:32 ` [PATCH 3/6] Staging: rtl8192u: Replace TRUE and FALSE macros Ksenija Stanojevic
2015-02-24 19:35 ` [Outreachy kernel] " Julia Lawall
2015-02-24 17:33 ` [PATCH 4/6] " Ksenija Stanojevic
2015-02-24 17:33 ` [PATCH 5/6] Staging: rtl8192u: Repace " Ksenija Stanojevic
2015-02-24 17:34 ` [PATCH 6/6] " Ksenija Stanojevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23670050.lCeLkYodT8@wuerfel \
--to=arnd@arndb.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.