From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Keerthy <j-keerthy@ti.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, grygorii.strashko@ti.com,
t-kristo@ti.com
Subject: Re: [PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe
Date: Tue, 12 Jun 2018 07:45:08 +0200 [thread overview]
Message-ID: <2368406.Am5sO8QqEf@ws-stein> (raw)
In-Reply-To: <1528781273-18098-1-git-send-email-j-keerthy@ti.com>
On Tuesday, June 12, 2018, 7:27:52 AM CEST Keerthy wrote:
> This is needed in case of PROBE_DEFER if IRQ resource is not yet ready.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> [...]
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> [...]
> @@ -168,7 +168,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> {
> static int ctrl_num, bank_base;
> int gpio, bank, ret = 0;
> - unsigned ngpio, nbank;
> + unsigned ngpio, nbank, bank_irq;
bank_irq should be an int, not unsigned, no?
> struct davinci_gpio_controller *chips;
> struct davinci_gpio_platform_data *pdata;
> struct device *dev = &pdev->dev;
> @@ -209,6 +209,12 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> if (IS_ERR(gpio_base))
> return PTR_ERR(gpio_base);
>
> + bank_irq = platform_get_irq(pdev, 0);
> + if (bank_irq < 0) {
This won't work using an unsigned.
Best regards,
Alexander
next prev parent reply other threads:[~2018-06-12 5:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 5:27 [PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe Keerthy
2018-06-12 5:27 ` Keerthy
2018-06-12 5:27 ` [PATCH v2 2/2] gpio: davinci: Do not assume continuous IRQ numbering Keerthy
2018-06-12 5:27 ` Keerthy
2018-06-12 5:45 ` Alexander Stein [this message]
2018-06-12 5:51 ` [PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe Keerthy
2018-06-12 5:51 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2368406.Am5sO8QqEf@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.